wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 858203 - mark more reftests as needs-focus; r=dholbert

Browse Source 
1. Start headless X server.  Start basic window manager on it.
2. Run reftests with said X server.  Take note of failing tests.
3. Disable all reftests that need focus:

   find $topsrcdir -name '*.list' | xargs sed -i -e '/needs-focus/s/^/#/'

4. Make reftest.js:Focus never focus the window and always return true.
5. Start reftests with said X server again.  Once the tests begin
   running, start a xterm on the same X server.  The window manager will
   focus this xterm and will not return focus to the browser.
6. Compare now-failing tests with baseline.  Mark all such tests as
   needs-focus.

Comments on specific tests:

editor/reftests/
- spellcheck-input-ref.html and spellcheck-textarea-ref.html focus
  input elements and don't work right without the window having focus.
- spellcheck-hyphen-invalid-ref.html and
  spellcheck-hyphen-multiple-invalid-ref.html use @autofocus on
  textarea.
- 674212-spellcheck.html, 338427-2.html, and
  462758-grabbers-resizers.html all wait for onfocus for div elements.

layout/reftests/bugs/
- 652301-1b.html focuses a bogus element with an onfocus handler.

layout/reftests/selection/
- pseudo-element-of-native-anonymous-ref.html .select()s an <input>.
This commit is contained in:
Nathan Froyd 2013-04-04 15:02:30 -04:00
parent 9f42555ba9
commit d07142b841
3 changed files with 31 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
editor/reftests/reftest.list
View File

@ -17,46 +17,46 @@ needs-focus == passwd-4.html passwd-ref.html
== emptypasswd-1.html emptypasswd-ref.html
== emptypasswd-2.html emptypasswd-ref.html
== caret_on_positioned.html caret_on_positioned-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-disabled.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-disabled.html spellcheck-input-ref.html
== spellcheck-input-attr-before.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-before.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-before.html spellcheck-input-ref.html
== spellcheck-input-attr-after.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-after.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-after.html spellcheck-input-ref.html
== spellcheck-input-attr-inherit.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-inherit.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-inherit.html spellcheck-input-ref.html
== spellcheck-input-attr-dynamic.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-dynamic.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-dynamic.html spellcheck-input-ref.html
== spellcheck-input-attr-dynamic-inherit.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-dynamic-inherit.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-dynamic-inherit.html spellcheck-input-ref.html
== spellcheck-input-property-dynamic.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-property-dynamic.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-property-dynamic.html spellcheck-input-ref.html
== spellcheck-input-property-dynamic-inherit.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-property-dynamic-inherit.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-property-dynamic-inherit.html spellcheck-input-ref.html
== spellcheck-input-attr-dynamic-override.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-dynamic-override.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-dynamic-override.html spellcheck-input-ref.html
== spellcheck-input-attr-dynamic-override-inherit.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-attr-dynamic-override-inherit.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-attr-dynamic-override-inherit.html spellcheck-input-ref.html
== spellcheck-input-property-dynamic-override.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-property-dynamic-override.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-property-dynamic-override.html spellcheck-input-ref.html
== spellcheck-input-property-dynamic-override-inherit.html spellcheck-input-nofocus-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-input-property-dynamic-override-inherit.html spellcheck-input-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-input-property-dynamic-override-inherit.html spellcheck-input-ref.html
== spellcheck-textarea-attr.html spellcheck-textarea-nofocus-ref.html
#the random-if(Android) tests pass on android native, but fail on android-xul, see bug 728942
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr.html spellcheck-textarea-ref.html
needs-focus == spellcheck-textarea-focused.html spellcheck-textarea-ref.html
needs-focus == spellcheck-textarea-focused-reframe.html spellcheck-textarea-ref.html
needs-focus == spellcheck-textarea-focused-notreadonly.html spellcheck-textarea-ref2.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-nofocus.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-disabled.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr-dynamic.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr-dynamic-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-property-dynamic.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-property-dynamic-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr-dynamic-override.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-attr-dynamic-override-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-property-dynamic-override.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) != spellcheck-textarea-property-dynamic-override-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-nofocus.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-disabled.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr-dynamic.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr-dynamic-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-property-dynamic.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-property-dynamic-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr-dynamic-override.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-attr-dynamic-override-inherit.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-property-dynamic-override.html spellcheck-textarea-ref.html
skip-if(B2G) random-if(Android) needs-focus != spellcheck-textarea-property-dynamic-override-inherit.html spellcheck-textarea-ref.html
needs-focus == caret_on_focus.html caret_on_focus-ref.html
needs-focus != caret_on_textarea_lastline.html caret_on_textarea_lastline-ref.html
needs-focus == input-text-onfocus-reframe.html input-text-onfocus-reframe-ref.html
@ -65,13 +65,13 @@ needs-focus == caret_after_reframe.html caret_after_reframe-ref.html
== nobogusnode-1.html nobogusnode-ref.html
== nobogusnode-2.html nobogusnode-ref.html
== spellcheck-hyphen-valid.html spellcheck-hyphen-valid-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-hyphen-invalid.html spellcheck-hyphen-invalid-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-hyphen-invalid.html spellcheck-hyphen-invalid-ref.html
== spellcheck-slash-valid.html spellcheck-slash-valid-ref.html
== spellcheck-period-valid.html spellcheck-period-valid-ref.html
== spellcheck-space-valid.html spellcheck-space-valid-ref.html
== spellcheck-comma-valid.html spellcheck-comma-valid-ref.html
== spellcheck-hyphen-multiple-valid.html spellcheck-hyphen-multiple-valid-ref.html
skip-if(B2G) fails-if(Android) != spellcheck-hyphen-multiple-invalid.html spellcheck-hyphen-multiple-invalid-ref.html
skip-if(B2G) fails-if(Android) needs-focus != spellcheck-hyphen-multiple-invalid.html spellcheck-hyphen-multiple-invalid-ref.html
== spellcheck-dotafterquote-valid.html spellcheck-dotafterquote-valid-ref.html
== spellcheck-url-valid.html spellcheck-url-valid-ref.html
== unneeded_scroll.html unneeded_scroll-ref.html
@ -83,10 +83,10 @@ skip-if(B2G) == 642800.html 642800-ref.html
!= selection_visibility_after_reframe-3.html selection_visibility_after_reframe-ref.html
== 672709.html 672709-ref.html
== 338427-1.html 338427-1-ref.html
skip-if(Android||B2G) == 674212-spellcheck.html 674212-spellcheck-ref.html
skip-if(Android||B2G) == 338427-2.html 338427-2-ref.html
skip-if(Android||B2G) needs-focus == 674212-spellcheck.html 674212-spellcheck-ref.html
skip-if(Android||B2G) needs-focus == 338427-2.html 338427-2-ref.html
skip-if(Android||B2G) needs-focus == 338427-3.html 338427-3-ref.html
skip-if(Android||B2G) == 462758-grabbers-resizers.html 462758-grabbers-resizers-ref.html
skip-if(Android||B2G) needs-focus == 462758-grabbers-resizers.html 462758-grabbers-resizers-ref.html
== readwrite-non-editable.html readwrite-non-editable-ref.html
== readwrite-editable.html readwrite-editable-ref.html
== readonly-non-editable.html readonly-non-editable-ref.html

2
layout/reftests/bugs/reftest.list
View File

@ -1658,7 +1658,7 @@ skip-if(B2G) == 641770-1.html 641770-1-ref.html
== 641856-1.html 641856-1-ref.html
== 645491-1.html 645491-1-ref.html
needs-focus == 652301-1a.html 652301-1-ref.html
== 652301-1b.html 652301-1-ref.html
needs-focus == 652301-1b.html 652301-1-ref.html
== 645768-1.html 645768-1-ref.html
fails-if(layersGPUAccelerated&&cocoaWidget) == 650228-1.html 650228-1-ref.html # Quartz alpha blending doesn't match GL alpha blending
== 653930-1.html 653930-1-ref.html

2
layout/reftests/selection/reftest.list
View File

@ -25,7 +25,7 @@
== extend-4a.html extend-4-ref.html
== extend-4b.html extend-4-ref.html
# these 3 random-if(Android) are a difference of Native & Xul, see bug 739714
random-if(Android||B2G) != pseudo-element-of-native-anonymous.html pseudo-element-of-native-anonymous-ref.html # bug 676641
random-if(Android||B2G) needs-focus != pseudo-element-of-native-anonymous.html pseudo-element-of-native-anonymous-ref.html # bug 676641
# These tests uses Highlight and HighlightText color keywords, they are not same as text selection color on Mac.
random-if(Android||B2G) fails-if(cocoaWidget) == non-themed-widget.html non-themed-widget-ref.html # bug 773482
random-if(Android||B2G) fails-if(cocoaWidget) == themed-widget.html themed-widget-ref.html