wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1183954, Don't leak nsStructuredCloneContainer (use of 'auto' is error prone), r=leak

Browse Source
This commit is contained in:
Olli Pettay 2015-08-02 12:34:26 +03:00
parent 8579f450a0
commit cb6eb89bc1
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dom/notification/Notification.cpp
View File

@ -1972,7 +1972,8 @@ Notification::GetData(JSContext* aCx,
{
if (mData.isNull() && !mDataAsBase64.IsEmpty()) {
nsresult rv;
auto container = new nsStructuredCloneContainer();
nsRefPtr<nsStructuredCloneContainer> container =
new nsStructuredCloneContainer();
rv = container->InitFromBase64(mDataAsBase64, JS_STRUCTURED_CLONE_VERSION,
aCx);
if (NS_WARN_IF(NS_FAILED(rv))) {
@ -2008,7 +2009,8 @@ Notification::InitFromJSVal(JSContext* aCx, JS::Handle<JS::Value> aData,
if (!mDataAsBase64.IsEmpty() || aData.isNull()) {
return;
}
auto dataObjectContainer = new nsStructuredCloneContainer();
nsRefPtr<nsStructuredCloneContainer> dataObjectContainer =
new nsStructuredCloneContainer();
aRv = dataObjectContainer->InitFromJSVal(aData, aCx);
if (NS_WARN_IF(aRv.Failed())) {
return;
@ -2025,7 +2027,8 @@ void Notification::InitFromBase64(JSContext* aCx, const nsAString& aData,
}
// To and fro to ensure it is valid base64.
auto container = new nsStructuredCloneContainer();
nsRefPtr<nsStructuredCloneContainer> container =
new nsStructuredCloneContainer();
aRv = container->InitFromBase64(aData, JS_STRUCTURED_CLONE_VERSION,
aCx);
if (NS_WARN_IF(aRv.Failed())) {