wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 983344. r=sfink

Browse Source
This commit is contained in:
Jeff Walden 2014-03-14 13:47:49 -07:00
parent 159be50008
commit cb1f566a90
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
js/src/vm/TypedArrayObject.cpp
View File

@ -907,6 +907,10 @@ class TypedArrayObjectTemplate : public TypedArrayObject
copyFromArray(JSContext *cx, HandleObject thisTypedArrayObj,
HandleObject ar, uint32_t len, uint32_t offset = 0)
{
// Exit early if nothing to copy, to simplify loop conditions below.
if (len == 0)
return true;
Rooted<TypedArrayObject*> thisTypedArray(cx, &thisTypedArrayObj->as<TypedArrayObject>());
JS_ASSERT(offset <= thisTypedArray->length());
JS_ASSERT(len <= thisTypedArray->length() - offset);
@ -914,7 +918,9 @@ class TypedArrayObjectTemplate : public TypedArrayObject
return copyFromTypedArray(cx, thisTypedArray, ar, offset);
JSRuntime *runtime = cx->runtime();
#ifdef DEBUG
uint64_t gcNumber = runtime->gcNumber;
#endif
NativeType *dest = static_cast<NativeType*>(thisTypedArray->viewData()) + offset;
SkipRoot skipDest(cx, &dest);
@ -929,33 +935,33 @@ class TypedArrayObjectTemplate : public TypedArrayObject
*/
const Value *src = ar->getDenseElements();
SkipRoot skipSrc(cx, &src);
for (uint32_t i = 0; i < len; ++i) {
uint32_t i = 0;
do {
NativeType n;
if (!nativeFromValue(cx, src[i], &n))
return false;
dest[i] = n;
}
} while (++i < len);
JS_ASSERT(runtime->gcNumber == gcNumber);
} else {
RootedValue v(cx);
for (uint32_t i = 0; i < len; ++i) {
uint32_t i = 0;
do {
if (!JSObject::getElement(cx, ar, ar, i, &v))
return false;
NativeType n;
if (!nativeFromValue(cx, v, &n))
return false;
/*
* Detect when a GC has occurred so we can update the dest
* pointers in case it has been moved.
*/
if (runtime->gcNumber != gcNumber) {
dest = static_cast<NativeType*>(thisTypedArray->viewData()) + offset;
gcNumber = runtime->gcNumber;
}
len = Min(len, thisTypedArray->length());
if (i >= len)
break;
// Compute every iteration in case getElement acts wacky.
dest = static_cast<NativeType*>(thisTypedArray->viewData()) + offset;
dest[i] = n;
}
} while (++i < len);
}
return true;