From ca6eb3b2e6154dacb813f3167bdbe259c657a066 Mon Sep 17 00:00:00 2001 From: Jeff Walden Date: Wed, 7 Jan 2015 10:06:03 -0600 Subject: [PATCH] Bug 1112774 - Remove JS_DoubleTo{Ui,I}nt32 in favor of JS::To{Ui,I}nt32. r=jorendorff --HG-- extra : rebase_source : 0f526faad2330aea9b8738d476aed5ce9aefde1e --- dom/canvas/CanvasRenderingContext2D.cpp | 25 +++++++++++++------------ js/src/jsapi.cpp | 12 ------------ js/src/jsapi.h | 6 ------ 3 files changed, 13 insertions(+), 30 deletions(-) diff --git a/dom/canvas/CanvasRenderingContext2D.cpp b/dom/canvas/CanvasRenderingContext2D.cpp index 2104589657a..3fd0a0935c0 100644 --- a/dom/canvas/CanvasRenderingContext2D.cpp +++ b/dom/canvas/CanvasRenderingContext2D.cpp @@ -68,6 +68,7 @@ #include "jsapi.h" #include "jsfriendapi.h" +#include "js/Conversions.h" #include "mozilla/Alignment.h" #include "mozilla/Assertions.h" @@ -4820,10 +4821,10 @@ CanvasRenderingContext2D::GetImageData(JSContext* aCx, double aSx, return nullptr; } - int32_t x = JS_DoubleToInt32(aSx); - int32_t y = JS_DoubleToInt32(aSy); - int32_t wi = JS_DoubleToInt32(aSw); - int32_t hi = JS_DoubleToInt32(aSh); + int32_t x = JS::ToInt32(aSx); + int32_t y = JS::ToInt32(aSy); + int32_t wi = JS::ToInt32(aSw); + int32_t hi = JS::ToInt32(aSh); // Handle negative width and height by flipping the rectangle over in the // relevant direction. @@ -5016,7 +5017,7 @@ CanvasRenderingContext2D::PutImageData(ImageData& imageData, double dx, DebugOnly inited = arr.Init(imageData.GetDataObject()); MOZ_ASSERT(inited); - error = PutImageData_explicit(JS_DoubleToInt32(dx), JS_DoubleToInt32(dy), + error = PutImageData_explicit(JS::ToInt32(dx), JS::ToInt32(dy), imageData.Width(), imageData.Height(), &arr, false, 0, 0, 0, 0); } @@ -5032,13 +5033,13 @@ CanvasRenderingContext2D::PutImageData(ImageData& imageData, double dx, DebugOnly inited = arr.Init(imageData.GetDataObject()); MOZ_ASSERT(inited); - error = PutImageData_explicit(JS_DoubleToInt32(dx), JS_DoubleToInt32(dy), + error = PutImageData_explicit(JS::ToInt32(dx), JS::ToInt32(dy), imageData.Width(), imageData.Height(), &arr, true, - JS_DoubleToInt32(dirtyX), - JS_DoubleToInt32(dirtyY), - JS_DoubleToInt32(dirtyWidth), - JS_DoubleToInt32(dirtyHeight)); + JS::ToInt32(dirtyX), + JS::ToInt32(dirtyY), + JS::ToInt32(dirtyWidth), + JS::ToInt32(dirtyHeight)); } // void putImageData (in ImageData d, in float x, in float y); @@ -5206,8 +5207,8 @@ CanvasRenderingContext2D::CreateImageData(JSContext* cx, double sw, return nullptr; } - int32_t wi = JS_DoubleToInt32(sw); - int32_t hi = JS_DoubleToInt32(sh); + int32_t wi = JS::ToInt32(sw); + int32_t hi = JS::ToInt32(sh); uint32_t w = Abs(wi); uint32_t h = Abs(hi); diff --git a/js/src/jsapi.cpp b/js/src/jsapi.cpp index 42c72a9fa2e..fa325d05fd0 100644 --- a/js/src/jsapi.cpp +++ b/js/src/jsapi.cpp @@ -452,18 +452,6 @@ JS_DoubleIsInt32(double d, int32_t *ip) return mozilla::NumberIsInt32(d, ip); } -JS_PUBLIC_API(int32_t) -JS_DoubleToInt32(double d) -{ - return ToInt32(d); -} - -JS_PUBLIC_API(uint32_t) -JS_DoubleToUint32(double d) -{ - return ToUint32(d); -} - JS_PUBLIC_API(JSType) JS_TypeOfValue(JSContext *cx, HandleValue value) { diff --git a/js/src/jsapi.h b/js/src/jsapi.h index f1cde1d8836..57978766bba 100644 --- a/js/src/jsapi.h +++ b/js/src/jsapi.h @@ -1099,12 +1099,6 @@ JS_ValueToSource(JSContext *cx, JS::Handle v); extern JS_PUBLIC_API(bool) JS_DoubleIsInt32(double d, int32_t *ip); -extern JS_PUBLIC_API(int32_t) -JS_DoubleToInt32(double d); - -extern JS_PUBLIC_API(uint32_t) -JS_DoubleToUint32(double d); - extern JS_PUBLIC_API(JSType) JS_TypeOfValue(JSContext *cx, JS::Handle v);