diff --git a/browser/base/content/browser-plugins.js b/browser/base/content/browser-plugins.js index 9abd1847931..5c1e41c5a1e 100644 --- a/browser/base/content/browser-plugins.js +++ b/browser/base/content/browser-plugins.js @@ -389,6 +389,14 @@ var gPluginHandler = { } } + let closeIcon = this.getPluginUI(plugin, "closeIcon"); + if (closeIcon) { + closeIcon.addEventListener("click", function(aEvent) { + if (aEvent.button == 0 && aEvent.isTrusted) + gPluginHandler.hideClickToPlayOverlay(plugin); + }, true); + } + if (shouldShowNotification) { this._showClickToPlayNotification(browser, plugin, false); } @@ -595,11 +603,6 @@ var gPluginHandler = { if (overlay) { overlay.addEventListener("click", gPluginHandler._overlayClickListener, true); - let closeIcon = this.getPluginUI(aPlugin, "closeIcon"); - closeIcon.addEventListener("click", function(aEvent) { - if (aEvent.button == 0 && aEvent.isTrusted) - gPluginHandler.hideClickToPlayOverlay(aPlugin); - }, true); } }, diff --git a/browser/base/content/test/general/browser.ini b/browser/base/content/test/general/browser.ini index deb6c3fcf31..22ca7138a36 100644 --- a/browser/base/content/test/general/browser.ini +++ b/browser/base/content/test/general/browser.ini @@ -115,6 +115,7 @@ skip-if = toolkit == "gtk2" || toolkit == "gtk3" # browser_CTP_context_menu.js run-if = crashreporter [browser_CTP_data_urls.js] [browser_CTP_drag_drop.js] +[browser_CTP_hide_overlay.js] [browser_CTP_multi_allow.js] [browser_CTP_nonplugins.js] [browser_CTP_notificationBar.js] diff --git a/browser/base/content/test/general/browser_CTP_hide_overlay.js b/browser/base/content/test/general/browser_CTP_hide_overlay.js new file mode 100644 index 00000000000..7b4fcb7e3b7 --- /dev/null +++ b/browser/base/content/test/general/browser_CTP_hide_overlay.js @@ -0,0 +1,76 @@ +var rootDir = getRootDirectory(gTestPath); +const gTestRoot = rootDir; +const gHttpTestRoot = rootDir.replace("chrome://mochitests/content/", "http://127.0.0.1:8888/"); + +var gTestBrowser = null; +var gNextTest = null; +var gPluginHost = Components.classes["@mozilla.org/plugin/host;1"].getService(Components.interfaces.nsIPluginHost); + +Components.utils.import("resource://gre/modules/Services.jsm"); + +function test() { + waitForExplicitFinish(); + registerCleanupFunction(function() { + clearAllPluginPermissions(); + Services.prefs.clearUserPref("extensions.blocklist.suppressUI"); + }); + Services.prefs.setBoolPref("extensions.blocklist.suppressUI", true); + + let newTab = gBrowser.addTab(); + gBrowser.selectedTab = newTab; + gTestBrowser = gBrowser.selectedBrowser; + gTestBrowser.addEventListener("load", pageLoad, true); + + Services.prefs.setBoolPref("plugins.click_to_play", true); + setTestPluginEnabledState(Ci.nsIPluginTag.STATE_DISABLED); + + prepareTest(runAfterPluginBindingAttached(test1), gHttpTestRoot + "plugin_test.html"); +} + +function finishTest() { + clearAllPluginPermissions(); + gTestBrowser.removeEventListener("load", pageLoad, true); + gBrowser.removeCurrentTab(); + window.focus(); + finish(); +} + +function pageLoad() { + // The plugin events are async dispatched and can come after the load event + // This just allows the events to fire before we then go on to test the states + executeSoon(gNextTest); +} + +function prepareTest(nextTest, url) { + gNextTest = nextTest; + gTestBrowser.contentWindow.location = url; +} + +// Due to layout being async, "PluginBindAttached" may trigger later. +// This wraps a function to force a layout flush, thus triggering it, +// and schedules the function execution so they're definitely executed +// afterwards. +function runAfterPluginBindingAttached(func) { + return function() { + let doc = gTestBrowser.contentDocument; + let elems = doc.getElementsByTagName('embed'); + if (elems.length < 1) { + elems = doc.getElementsByTagName('object'); + } + elems[0].clientTop; + executeSoon(func); + }; +} + +// Tests that the overlay can be hidded for disabled plugins using the close icon. +function test1() { + var doc = gTestBrowser.contentDocument; + var plugin = doc.getElementById("test"); + ok(plugin, "Test 1, Found plugin in page"); + var overlay = doc.getAnonymousElementByAttribute(plugin, "anonid", "main"); + ok(overlay.classList.contains("visible"), "Test 1, Plugin overlay should exist, not be hidden"); + var closeIcon = doc.getAnonymousElementByAttribute(plugin, "anonid", "closeIcon") + EventUtils.synthesizeMouseAtCenter(closeIcon, {}, gTestBrowser.contentWindow); + var condition = function() !overlay.classList.contains("visible"); + waitForCondition(condition, finishTest, "Test 1, Waited too long for the overlay to become invisible."); +}