Backed out changeset d6b0ffe1a7b3 (bug 1231378)

memory/volatile/VolatileBuffer.h

@@ -88,11 +88,7 @@ private:
 
 class VolatileBufferPtr_base {
 public:
-  explicit VolatileBufferPtr_base(VolatileBuffer* vbuf)
-    : mVBuf(vbuf)
-    , mMapping(nullptr)
-    , mPurged(false)
-  {
+  explicit VolatileBufferPtr_base(VolatileBuffer* vbuf) : mVBuf(vbuf) {
     Lock();
   }
 

netwerk/dns/ChildDNSService.cpp

@@ -43,7 +43,6 @@ NS_IMPL_ISUPPORTS(ChildDNSService,
 ChildDNSService::ChildDNSService()
   : mFirstTime(true)
   , mOffline(false)
-  , mDisablePrefetch(false)
   , mPendingRequestsLock("DNSPendingRequestsLock")
 {
   MOZ_ASSERT(IsNeckoChild());

netwerk/dns/DNS.cpp

@@ -261,9 +261,6 @@ NetAddrElement::~NetAddrElement()
 
 AddrInfo::AddrInfo(const char *host, const PRAddrInfo *prAddrInfo,
                    bool disableIPv4, bool filterNameCollision, const char *cname)
-  : mHostName(nullptr)
-  , mCanonicalName(nullptr)
-  , ttl(NO_TTL_DATA)
 {
   MOZ_ASSERT(prAddrInfo, "Cannot construct AddrInfo with a null prAddrInfo pointer!");
   const uint32_t nameCollisionAddr = htonl(0x7f003535); // 127.0.53.53
@@ -284,9 +281,6 @@ AddrInfo::AddrInfo(const char *host, const PRAddrInfo *prAddrInfo,
 }
 
 AddrInfo::AddrInfo(const char *host, const char *cname)
-  : mHostName(nullptr)
-  , mCanonicalName(nullptr)
-  , ttl(NO_TTL_DATA)
 {
   Init(host, cname);
 }

netwerk/dns/DNSRequestParent.cpp

@@ -20,8 +20,7 @@ namespace mozilla {
 namespace net {
 
 DNSRequestParent::DNSRequestParent()
-  : mFlags(0)
-  , mIPCClosed(false)
+  : mIPCClosed(false)
 {
 
 }

netwerk/dns/nsDNSService2.cpp

@@ -480,12 +480,8 @@ private:
 
 nsDNSService::nsDNSService()
     : mLock("nsDNSServer.mLock")
-    , mDisableIPv6(false)
-    , mDisablePrefetch(false)
     , mFirstTime(true)
     , mOffline(false)
-    , mNotifyResolution(false)
-    , mOfflineLocalhost(false)
 {
 }
 

netwerk/dns/nsIDNService.cpp

@@ -132,9 +132,6 @@ void nsIDNService::prefsChanged(nsIPrefBranch *prefBranch, const char16_t *pref)
 }
 
 nsIDNService::nsIDNService()
-  : mNamePrepHandle(0)
-  , mShowPunycode(false)
-  , mIDNUseWhitelist(false)
 {
 #ifdef IDNA2008
   uint32_t IDNAOptions = UIDNA_CHECK_BIDI | UIDNA_CHECK_CONTEXTJ;

storage/mozStorageBindingParams.cpp

@@ -108,7 +108,6 @@ BindingParams::BindingParams(mozIStorageBindingParamsArray *aOwningArray,
 : mLocked(false)
 , mOwningArray(aOwningArray)
 , mOwningStatement(aOwningStatement)
-, mParamCount(0)
 {
   (void)mOwningStatement->GetParameterCount(&mParamCount);
   mParameters.SetCapacity(mParamCount);

storage/mozStorageRow.h

@@ -24,8 +24,6 @@ public:
   NS_DECL_MOZISTORAGEROW
   NS_DECL_MOZISTORAGEVALUEARRAY
 
-  Row() : mNumCols(0) {}
-
   /**
    * Initializes the object with the given statement.  Copies the values from
    * the statement.

storage/mozStorageStatementData.h

@@ -44,7 +44,6 @@ public:
     NS_PRECONDITION(mStatementOwner, "Must have a statement owner!");
   }
   StatementData()
-  : mStatement(nullptr)
   {
   }
   ~StatementData()

storage/mozStorageStatementParams.cpp

@@ -21,8 +21,7 @@ namespace storage {
 //// StatementParams
 
 StatementParams::StatementParams(mozIStorageStatement *aStatement) :
-    mStatement(aStatement),
-    mParamCount(0)
+    mStatement(aStatement)
 {
   NS_ASSERTION(mStatement != nullptr, "mStatement is null");
   (void)mStatement->GetParameterCount(&mParamCount);

tools/profiler/public/GeckoProfilerImpl.h

@@ -432,7 +432,6 @@ public:
   // we only copy the strings at save time, so to take multiple parameters we'd need to copy them then.
   SamplerStackFramePrintfRAII(const char *aInfo,
     js::ProfileEntry::Category aCategory, uint32_t line, const char *aFormat, ...)
-    : mHandle(nullptr)
   {
     if (profiler_is_active() && !profiler_in_privacy_mode()) {
       va_list args;

uriloader/prefetch/OfflineCacheUpdateChild.cpp

@@ -76,7 +76,6 @@ NS_IMPL_RELEASE(OfflineCacheUpdateChild)
 OfflineCacheUpdateChild::OfflineCacheUpdateChild(nsIDOMWindow* aWindow)
     : mState(STATE_UNINITIALIZED)
     , mIsUpgrade(false)
-    , mSucceeded(false)
     , mAppID(NECKO_NO_APP_ID)
     , mInBrowser(false)
     , mWindow(aWindow)

uriloader/prefetch/nsOfflineCacheUpdate.cpp

@@ -687,7 +687,6 @@ nsOfflineManifestItem::nsOfflineManifestItem(nsIURI *aURI,
                                nsIApplicationCache::ITEM_MANIFEST)
     , mParserState(PARSE_INIT)
     , mNeedsUpdate(true)
-    , mStrictFileOriginPolicy(false)
     , mManifestHashInitialized(false)
 {
     ReadStrictFileOriginPolicyPref();
@@ -1169,7 +1168,6 @@ nsOfflineCacheUpdate::nsOfflineCacheUpdate()
     , mRescheduleCount(0)
     , mPinnedEntryRetriesCount(0)
     , mPinned(false)
-    , mByteProgress(0)
 {
 }
 

widget/BasicEvents.h

@@ -190,7 +190,6 @@ protected:
   }
 
   WidgetEvent()
-    : time(0)
   {
     MOZ_COUNT_CTOR(WidgetEvent);
   }
@@ -571,7 +570,6 @@ protected:
   }
 
   WidgetInputEvent()
-    : modifiers(0)
   {
   }
 

widget/MouseEvents.h

@@ -74,11 +74,6 @@ private:
 
 protected:
   WidgetMouseEventBase()
-    : button(0)
-    , buttons(0)
-    , pressure(0)
-    , hitCluster(false)
-    , inputSource(nsIDOMMouseEvent::MOZ_SOURCE_MOUSE)
   {
   }
 
@@ -200,9 +195,6 @@ public:
 
 protected:
   WidgetMouseEvent()
-    : acceptActivation(false)
-    , ignoreRootScrollFrame(false)
-    , clickCount(0)
   {
   }
 
@@ -324,8 +316,6 @@ private:
   friend class mozilla::dom::PBrowserChild;
 protected:
   WidgetDragEvent()
-    : userCancelled(false)
-    , mDefaultPreventedOnContent(false)
   {
   }
 public:
@@ -383,8 +373,6 @@ class WidgetMouseScrollEvent : public WidgetMouseEventBase
 {
 private:
   WidgetMouseScrollEvent()
-    : delta(0)
-    , isHorizontal(false)
   {
   }
 
@@ -448,20 +436,6 @@ private:
   friend class mozilla::dom::PBrowserChild;
 
   WidgetWheelEvent()
-    : deltaX(0.0)
-    , deltaY(0.0)
-    , deltaZ(0.0)
-    , deltaMode(nsIDOMWheelEvent::DOM_DELTA_PIXEL)
-    , customizedByUserPrefs(false)
-    , isMomentum(false)
-    , mIsNoLineOrPageDelta(false)
-    , lineOrPageDeltaX(0)
-    , lineOrPageDeltaY(0)
-    , scrollType(SCROLL_DEFAULT)
-    , overflowDeltaX(0.0)
-    , overflowDeltaY(0.0)
-    , mViewPortIsOverscrolled(false)
-    , mCanTriggerSwipe(false)
   {
   }
 
@@ -631,9 +605,6 @@ class WidgetPointerEvent : public WidgetMouseEvent
   friend class mozilla::dom::PBrowserChild;
 
   WidgetPointerEvent()
-    : width(0)
-    , height(0)
-    , isPrimary(true)
   {
   }
 

widget/ScreenProxy.cpp

@@ -20,11 +20,7 @@ using namespace mozilla::dom;
 static NS_DEFINE_CID(kAppShellCID, NS_APPSHELL_CID);
 
 ScreenProxy::ScreenProxy(nsScreenManagerProxy* aScreenManager, ScreenDetails aDetails)
-  : mContentsScaleFactor(0)
-  , mScreenManager(aScreenManager)
-  , mId(0)
-  , mPixelDepth(0)
-  , mColorDepth(0)
+  : mScreenManager(aScreenManager)
   , mCacheValid(false)
   , mCacheWillInvalidate(false)
 {

widget/TextEvents.h

@@ -82,20 +82,6 @@ private:
 
 protected:
   WidgetKeyboardEvent()
-    : keyCode(0)
-    , charCode(0)
-    , location(nsIDOMKeyEvent::DOM_KEY_LOCATION_STANDARD)
-    , isChar(false)
-    , mIsRepeat(false)
-    , mIsComposing(false)
-    , mKeyNameIndex(mozilla::KEY_NAME_INDEX_Unidentified)
-    , mCodeNameIndex(CODE_NAME_INDEX_UNKNOWN)
-    , mNativeKeyEvent(nullptr)
-    , mUniqueId(0)
-#ifdef XP_MACOSX
-    , mNativeKeyCode(0)
-    , mNativeModifierFlags(0)
-#endif
   {
   }
 
@@ -484,9 +470,6 @@ private:
   friend class dom::PBrowserChild;
 
   WidgetQueryContentEvent()
-    : mSucceeded(false)
-    , mUseNativeLineBreak(true)
-    , mWithFontRanges(false)
   {
     MOZ_CRASH("WidgetQueryContentEvent is created without proper arguments");
   }
@@ -667,7 +650,6 @@ private:
     , mReversed(false)
     , mExpandToClusterBoundary(true)
     , mSucceeded(false)
-    , mUseNativeLineBreak(true)
   {
   }
 

widget/nsFilePickerProxy.cpp

@@ -16,7 +16,6 @@ using namespace mozilla::dom;
 NS_IMPL_ISUPPORTS(nsFilePickerProxy, nsIFilePicker)
 
 nsFilePickerProxy::nsFilePickerProxy()
-  : mSelectedType(0)
 {
 }
 

widget/xremoteclient/XRemoteClient.cpp

@@ -62,12 +62,9 @@ XRemoteClient::XRemoteClient()
   mInitialized = false;
   mMozVersionAtom = 0;
   mMozLockAtom = 0;
-  mMozCommandLineAtom = 0;
   mMozResponseAtom = 0;
   mMozWMStateAtom = 0;
   mMozUserAtom = 0;
-  mMozProfileAtom = 0;
-  mMozProgramAtom = 0;
   mLockData = 0;
   if (!sRemoteLm)
     sRemoteLm = PR_NewLogModule("XRemoteClient");