wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 899623 - Ensure activeTileset is bound before calling methods on it. r=jimm

Browse Source
This commit is contained in:
Sam Foster 2013-07-30 12:16:58 -07:00
parent bf4b322de3
commit bcffc55516
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
browser/metro/base/content/appbar.js
View File

@ -36,7 +36,7 @@ var Appbar = {
break;
case 'MozAppbarDismissing':
if (this.activeTileset) {
if (this.activeTileset && ('isBound' in this.activeTileset)) {
this.activeTileset.clearSelection();
}
this.clearContextualActions();
@ -146,7 +146,7 @@ var Appbar = {
dispatchContextualAction: function(aActionName){
let activeTileset = this.activeTileset;
if (activeTileset) {
if (activeTileset && ('isBound' in this.activeTileset)) {
// fire event on the richgrid, others can listen
// but we keep coupling loose so grid doesn't need to know about appbar
let event = document.createEvent("Events");
@ -234,8 +234,11 @@ var Appbar = {
_onTileSelectionChanged: function _onTileSelectionChanged(aEvent){
let activeTileset = aEvent.target;
// deselect tiles in other tile groups
if (this.activeTileset && this.activeTileset !== activeTileset) {
// deselect tiles in other tile groups,
// ensure previousyl-activeTileset is bound before calling methods on it
if (this.activeTileset &&
('isBound' in this.activeTileset) &&
this.activeTileset !== activeTileset) {
this.activeTileset.clearSelection();
}
// keep track of which view is the target/scope for the contextual actions