Bug 1164310, part 1 - Make the code for bypassing mobile security checks more general so that it can be used on non-mobile. r=baku

dom/filesystem/DeviceStorageFileSystem.cpp

@@ -36,8 +36,8 @@ DeviceStorageFileSystem::DeviceStorageFileSystem(
   mString.Append('-');
   mString.Append(mStorageName);
 
-  mIsTesting =
-    mozilla::Preferences::GetBool("device.storage.prompt.testing", false);
+  mRequiresPermissionChecks =
+    !mozilla::Preferences::GetBool("device.storage.prompt.testing", false);
 
   // Get the permission name required to access the file system.
   nsresult rv =

dom/filesystem/FileSystemBase.cpp

@@ -42,7 +42,7 @@ FileSystemBase::FromString(const nsAString& aString)
 
 FileSystemBase::FileSystemBase()
   : mShutdown(false)
-  , mIsTesting(false)
+  , mRequiresPermissionChecks(true)
 {
 }
 

dom/filesystem/FileSystemBase.h

@@ -85,9 +85,9 @@ public:
   }
 
   bool
-  IsTesting() const
+  RequiresPermissionChecks() const
   {
-    return mIsTesting;
+    return mRequiresPermissionChecks;
   }
 protected:
   virtual ~FileSystemBase();
@@ -100,7 +100,7 @@ protected:
   // The permission name required to access the file system.
   nsCString mPermission;
 
-  bool mIsTesting;
+  bool mRequiresPermissionChecks;
 };
 
 } // namespace dom

dom/filesystem/FileSystemPermissionRequest.cpp

@@ -122,7 +122,7 @@ FileSystemPermissionRequest::Run()
     return NS_OK;
   }
 
-  if (filesystem->IsTesting()) {
+  if (!filesystem->RequiresPermissionChecks()) {
     Allow(JS::UndefinedHandleValue);
     return NS_OK;
   }

dom/filesystem/FileSystemRequestParent.cpp

@@ -58,7 +58,7 @@ FileSystemRequestParent::Dispatch(ContentParent* aParent,
     return false;
   }
 
-  if (!mFileSystem->IsTesting()) {
+  if (mFileSystem->RequiresPermissionChecks()) {
     // Check the content process permission.
 
     nsCString access;