Bug 1061023 - Fix more bad implicit constructors in DOM; r=baku

--HG--
extra : rebase_source : c80c5f9d7ae28286513cdb52ad76b46c240bdd5d
This commit is contained in:
Ehsan Akhgari 2014-09-01 18:26:43 -04:00
parent a6d74d5db4
commit bc7cc3893c
105 changed files with 171 additions and 170 deletions

View File

@ -29,7 +29,7 @@ public:
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(MediaKeyMessageEvent, Event)
protected:
virtual ~MediaKeyMessageEvent();
MediaKeyMessageEvent(EventTarget* aOwner);
explicit MediaKeyMessageEvent(EventTarget* aOwner);
JS::Heap<JSObject*> mMessage;
nsString mDestinationURL;

View File

@ -18,7 +18,7 @@ namespace dom {
class MediaStreamAudioSourceNodeEngine : public AudioNodeEngine
{
public:
MediaStreamAudioSourceNodeEngine(AudioNode* aNode)
explicit MediaStreamAudioSourceNodeEngine(AudioNode* aNode)
: AudioNodeEngine(aNode), mEnabled(false) {}
bool IsEnabled() const { return mEnabled; }

View File

@ -39,7 +39,7 @@ public:
return activity.forget();
}
Activity(nsPIDOMWindow* aWindow);
explicit Activity(nsPIDOMWindow* aWindow);
protected:
nsresult Initialize(nsPIDOMWindow* aWindow,

View File

@ -18,7 +18,7 @@ namespace dom {
class AnimationEffect MOZ_FINAL : public nsWrapperCache
{
public:
AnimationEffect(Animation* aAnimation)
explicit AnimationEffect(Animation* aAnimation)
: mAnimation(aAnimation)
{
SetIsDOMBinding();

View File

@ -54,7 +54,7 @@ class ArchiveReaderEvent : public nsRunnable
public:
NS_DECL_NSIRUNNABLE
ArchiveReaderEvent(ArchiveReader* aArchiveReader);
explicit ArchiveReaderEvent(ArchiveReader* aArchiveReader);
protected:
virtual ~ArchiveReaderEvent();

View File

@ -23,8 +23,8 @@ class ArchiveRequestEvent : public nsRunnable
public:
NS_DECL_NSIRUNNABLE
ArchiveRequestEvent(ArchiveRequest* request)
: mRequest(request)
explicit ArchiveRequestEvent(ArchiveRequest* aRequest)
: mRequest(aRequest)
{
MOZ_COUNT_CTOR(ArchiveRequestEvent);
}

View File

@ -14544,7 +14544,7 @@ class CGEventClass(CGBindingImplClass):
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(${nativeType}, ${parentType})
protected:
virtual ~${nativeType}();
${nativeType}(mozilla::dom::EventTarget* aOwner);
explicit ${nativeType}(mozilla::dom::EventTarget* aOwner);
""",
nativeType=self.descriptor.nativeType.split('::')[-1],

View File

@ -269,7 +269,7 @@ public:
StackFrame)
// aStack must not be null.
JSStackFrame(JS::Handle<JSObject*> aStack);
explicit JSStackFrame(JS::Handle<JSObject*> aStack);
static already_AddRefed<nsIStackFrame>
CreateStack(JSContext* aCx, int32_t aMaxDepth = -1);

View File

@ -27,7 +27,7 @@ class TestCImplementedInterface2 : public nsISupports,
public nsWrapperCache
{
public:
TestCImplementedInterface2(nsPIDOMWindow* aParent)
explicit TestCImplementedInterface2(nsPIDOMWindow* aParent)
{}
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(TestCImplementedInterface2)

View File

@ -11,7 +11,7 @@
class RwLockAutoEnterRead
{
public:
RwLockAutoEnterRead(PRRWLock* aRwLock)
explicit RwLockAutoEnterRead(PRRWLock* aRwLock)
: mRwLock(aRwLock)
{
MOZ_ASSERT(mRwLock);
@ -30,7 +30,7 @@ protected:
class RwLockAutoEnterWrite
{
public:
RwLockAutoEnterWrite(PRRWLock* aRwLock)
explicit RwLockAutoEnterWrite(PRRWLock* aRwLock)
: mRwLock(aRwLock)
{
MOZ_ASSERT(mRwLock);

View File

@ -30,7 +30,7 @@ class RecorderProfileManager;
class CameraControlImpl : public ICameraControl
{
public:
CameraControlImpl(uint32_t aCameraId);
explicit CameraControlImpl(uint32_t aCameraId);
virtual void AddListener(CameraControlListener* aListener) MOZ_OVERRIDE;
virtual void RemoveListener(CameraControlListener* aListener) MOZ_OVERRIDE;

View File

@ -23,7 +23,7 @@ class CameraPreviewMediaStream : public MediaStream
typedef mozilla::layers::Image Image;
public:
CameraPreviewMediaStream(DOMMediaStream* aWrapper);
explicit CameraPreviewMediaStream(DOMMediaStream* aWrapper);
virtual void AddAudioOutput(void* aKey) MOZ_OVERRIDE;
virtual void SetAudioOutputVolume(void* aKey, float aVolume) MOZ_OVERRIDE;

View File

@ -262,7 +262,7 @@ public:
nsresult GetJsObject(JSContext* aCx, JSObject** aObject) const;
protected:
RecorderProfileManager(uint32_t aCameraId);
explicit RecorderProfileManager(uint32_t aCameraId);
virtual ~RecorderProfileManager();
uint32_t mCameraId;

View File

@ -40,7 +40,7 @@ public:
// Great Renaming proposed in bug 983177.
static bool HasSupport(JSContext* aCx, JSObject* aGlobal);
CameraCapabilities(nsPIDOMWindow* aWindow);
explicit CameraCapabilities(nsPIDOMWindow* aWindow);
// Populate the camera capabilities interface from the specific
// camera control object.

View File

@ -81,7 +81,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIDOMEVENTLISTENER
StartRecordingHelper(nsDOMCameraControl* aDOMCameraControl)
explicit StartRecordingHelper(nsDOMCameraControl* aDOMCameraControl)
: mDOMCameraControl(aDOMCameraControl)
{
MOZ_COUNT_CTOR(StartRecordingHelper);

View File

@ -145,7 +145,7 @@ protected:
NS_INLINE_DECL_REFCOUNTING(DOMCameraConfiguration)
DOMCameraConfiguration();
DOMCameraConfiguration(const dom::CameraConfiguration& aConfiguration);
explicit DOMCameraConfiguration(const dom::CameraConfiguration& aConfiguration);
// Additional configuration options that aren't exposed to the DOM
uint32_t mMaxFocusAreas;

View File

@ -31,7 +31,7 @@ DOMCameraControlListener::~DOMCameraControlListener()
class DOMCameraControlListener::DOMCallback : public nsRunnable
{
public:
DOMCallback(nsMainThreadPtrHandle<nsDOMCameraControl> aDOMCameraControl)
explicit DOMCallback(nsMainThreadPtrHandle<nsDOMCameraControl> aDOMCameraControl)
: mDOMCameraControl(aDOMCameraControl)
{
MOZ_COUNT_CTOR(DOMCameraControlListener::DOMCallback);
@ -276,7 +276,7 @@ DOMCameraControlListener::OnShutter()
class Callback : public DOMCallback
{
public:
Callback(nsMainThreadPtrHandle<nsDOMCameraControl> aDOMCameraControl)
explicit Callback(nsMainThreadPtrHandle<nsDOMCameraControl> aDOMCameraControl)
: DOMCallback(aDOMCameraControl)
{ }

View File

@ -22,7 +22,7 @@ namespace mozilla {
class FallbackCameraControl : public CameraControlImpl
{
public:
FallbackCameraControl(uint32_t aCameraId) : CameraControlImpl(aCameraId) { }
explicit FallbackCameraControl(uint32_t aCameraId) : CameraControlImpl(aCameraId) { }
virtual nsresult Set(uint32_t aKey, const nsAString& aValue) MOZ_OVERRIDE { return NS_ERROR_NOT_IMPLEMENTED; }
virtual nsresult Get(uint32_t aKey, nsAString& aValue) MOZ_OVERRIDE { return NS_ERROR_NOT_IMPLEMENTED; }

View File

@ -240,7 +240,7 @@ protected:
class ICameraControlParameterSetAutoEnter
{
public:
ICameraControlParameterSetAutoEnter(ICameraControl* aCameraControl)
explicit ICameraControlParameterSetAutoEnter(ICameraControl* aCameraControl)
: mCameraControl(aCameraControl)
{
mCameraControl->BeginBatchParameterSet();

View File

@ -35,7 +35,7 @@ struct ImageCacheEntryData {
, mSourceSurface(aOther.mSourceSurface)
, mSize(aOther.mSize)
{}
ImageCacheEntryData(const ImageCacheKey& aKey)
explicit ImageCacheEntryData(const ImageCacheKey& aKey)
: mImage(aKey.mImage)
, mILC(nullptr)
, mCanvas(aKey.mCanvas)
@ -61,8 +61,8 @@ public:
typedef ImageCacheKey KeyType;
typedef const ImageCacheKey* KeyTypePointer;
ImageCacheEntry(const KeyType *key) :
mData(new ImageCacheEntryData(*key)) {}
explicit ImageCacheEntry(const KeyType* aKey) :
mData(new ImageCacheEntryData(*aKey)) {}
ImageCacheEntry(const ImageCacheEntry &toCopy) :
mData(new ImageCacheEntryData(*toCopy.mData)) {}
~ImageCacheEntry() {}
@ -115,7 +115,7 @@ class ImageCacheObserver MOZ_FINAL : public nsIObserver
public:
NS_DECL_ISUPPORTS
ImageCacheObserver(ImageCache* aImageCache)
explicit ImageCacheObserver(ImageCache* aImageCache)
: mImageCache(aImageCache)
{
RegisterMemoryPressureEvent();

View File

@ -298,7 +298,7 @@ class AdjustedTarget
public:
typedef CanvasRenderingContext2D::ContextState ContextState;
AdjustedTarget(CanvasRenderingContext2D *ctx,
explicit AdjustedTarget(CanvasRenderingContext2D* ctx,
mgfx::Rect *aBounds = nullptr)
: mCtx(nullptr)
{
@ -438,7 +438,7 @@ NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(CanvasPattern, mContext)
class CanvasRenderingContext2DUserData : public LayerUserData {
public:
CanvasRenderingContext2DUserData(CanvasRenderingContext2D *aContext)
explicit CanvasRenderingContext2DUserData(CanvasRenderingContext2D *aContext)
: mContext(aContext)
{
aContext->mUserDatas.AppendElement(this);

View File

@ -15,7 +15,7 @@ namespace dom {
class TextMetrics MOZ_FINAL : public NonRefcountedDOMObject
{
public:
TextMetrics(float w) : width(w)
explicit TextMetrics(float aValue) : width(aValue)
{
MOZ_COUNT_CTOR(TextMetrics);
}

View File

@ -26,7 +26,7 @@ class WebGLBuffer MOZ_FINAL
, public WebGLContextBoundObject
{
public:
WebGLBuffer(WebGLContext *context);
explicit WebGLBuffer(WebGLContext* aContext);
void Delete();

View File

@ -1129,7 +1129,7 @@ namespace mozilla {
class WebGLContextUserData : public LayerUserData {
public:
WebGLContextUserData(HTMLCanvasElement *aContent)
explicit WebGLContextUserData(HTMLCanvasElement* aContent)
: mContent(aContent)
{}
@ -1510,8 +1510,8 @@ class UpdateContextLossStatusTask : public nsRunnable
nsRefPtr<WebGLContext> mContext;
public:
UpdateContextLossStatusTask(WebGLContext* context)
: mContext(context)
explicit UpdateContextLossStatusTask(WebGLContext* aContext)
: mContext(aContext)
{
}

View File

@ -30,7 +30,7 @@ class WebGLContextLossHandler
public:
MOZ_DECLARE_REFCOUNTED_TYPENAME(WebGLContextLossHandler)
WebGLContextLossHandler(WebGLContext* webgl);
explicit WebGLContextLossHandler(WebGLContext* aWebgl);
~WebGLContextLossHandler();
void RunTimer();

View File

@ -36,7 +36,7 @@ struct GLComponents
: mComponents(0)
{ }
GLComponents(GLenum format);
explicit GLComponents(GLenum aFormat);
// Returns true iff other has all (or more) of
// the components present in this GLComponents

View File

@ -144,8 +144,8 @@ public:
// Constructor. Takes a reference to the WebGLElementArrayCache that is to be
// the parent. Does not initialize the tree. Should be followed by a call
// to Update() to attempt initializing the tree.
WebGLElementArrayCacheTree(WebGLElementArrayCache& p)
: mParent(p)
explicit WebGLElementArrayCacheTree(WebGLElementArrayCache& aValue)
: mParent(aValue)
{
}

View File

@ -23,7 +23,7 @@ class WebGLExtensionBase
, public WebGLContextBoundObject
{
public:
WebGLExtensionBase(WebGLContext*);
explicit WebGLExtensionBase(WebGLContext* aValue);
WebGLContext *GetParentObject() const {
return Context();
@ -288,7 +288,7 @@ class WebGLExtensionVertexArray
: public WebGLExtensionBase
{
public:
WebGLExtensionVertexArray(WebGLContext*);
explicit WebGLExtensionVertexArray(WebGLContext* aValue);
virtual ~WebGLExtensionVertexArray();
already_AddRefed<WebGLVertexArray> CreateVertexArrayOES();
@ -305,7 +305,7 @@ class WebGLExtensionInstancedArrays
: public WebGLExtensionBase
{
public:
WebGLExtensionInstancedArrays(WebGLContext* context);
explicit WebGLExtensionInstancedArrays(WebGLContext* aContext);
virtual ~WebGLExtensionInstancedArrays();
void DrawArraysInstancedANGLE(GLenum mode, GLint first,
@ -324,7 +324,7 @@ class WebGLExtensionBlendMinMax
: public WebGLExtensionBase
{
public:
WebGLExtensionBlendMinMax(WebGLContext*);
explicit WebGLExtensionBlendMinMax(WebGLContext* aValue);
virtual ~WebGLExtensionBlendMinMax();
static bool IsSupported(const WebGLContext*);

View File

@ -31,7 +31,7 @@ class WebGLProgram MOZ_FINAL
, public WebGLContextBoundObject
{
public:
WebGLProgram(WebGLContext *context);
explicit WebGLProgram(WebGLContext* aContext);
void Delete();

View File

@ -27,7 +27,7 @@ public:
// -------------------------------------------------------------------------
// CONSTRUCTOR
WebGLQuery(WebGLContext *context);
explicit WebGLQuery(WebGLContext* aContext);
// -------------------------------------------------------------------------
// MEMBER FUNCTIONS

View File

@ -35,7 +35,7 @@ class WebGLTexture MOZ_FINAL
, public WebGLFramebufferAttachable
{
public:
WebGLTexture(WebGLContext *context);
explicit WebGLTexture(WebGLContext* aContext);
void Delete();

View File

@ -15,7 +15,7 @@ struct WebGLUniformInfo {
bool isArray;
ShDataType type;
WebGLUniformInfo(uint32_t s = 0, bool a = false, ShDataType t = SH_NONE)
explicit WebGLUniformInfo(uint32_t s = 0, bool a = false, ShDataType t = SH_NONE)
: arraySize(s), isArray(a), type(t) {}
int ElementSize() const {

View File

@ -58,13 +58,13 @@ namespace mozilla {
// implementations not expecting characters outside the GLSL ES set.
class StripComments {
public:
StripComments(const nsAString& str)
explicit StripComments(const nsAString& aStr)
: m_parseState(BeginningOfLine)
, m_end(str.EndReading())
, m_current(str.BeginReading())
, m_end(aStr.EndReading())
, m_current(aStr.BeginReading())
, m_position(0)
{
m_result.SetLength(str.Length());
m_result.SetLength(aStr.Length());
parse();
}

View File

@ -74,7 +74,7 @@ public:
// -----------------------------------------------------------------------------
// PROTECTED
protected:
WebGLVertexArray(WebGLContext* context);
explicit WebGLVertexArray(WebGLContext* aContext);
virtual ~WebGLVertexArray() {
MOZ_ASSERT(IsDeleted());

View File

@ -19,8 +19,8 @@ public:
virtual void GenVertexArray() MOZ_OVERRIDE { };
private:
WebGLVertexArrayFake(WebGLContext *context)
: WebGLVertexArray(context)
explicit WebGLVertexArrayFake(WebGLContext* aContext)
: WebGLVertexArray(aContext)
{ }
~WebGLVertexArrayFake() {

View File

@ -19,8 +19,8 @@ public:
virtual void GenVertexArray() MOZ_OVERRIDE;
private:
WebGLVertexArrayGL(WebGLContext* context)
: WebGLVertexArray(context)
explicit WebGLVertexArrayGL(WebGLContext* aContext)
: WebGLVertexArray(aContext)
{ }
~WebGLVertexArrayGL() {

View File

@ -24,7 +24,7 @@ public:
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(CryptoKeyPair)
public:
CryptoKeyPair(nsIGlobalObject* aGlobal)
explicit CryptoKeyPair(nsIGlobalObject* aGlobal)
: mGlobal(aGlobal)
, mPublicKey(new CryptoKey(aGlobal))
, mPrivateKey(new CryptoKey(aGlobal))

View File

@ -110,7 +110,7 @@ enum TelemetryAlgorithm {
class ClearException
{
public:
ClearException(JSContext* aCx)
explicit ClearException(JSContext* aCx)
: mCx(aCx)
{}
@ -379,8 +379,8 @@ WebCryptoTask::CallCallback(nsresult rv)
class FailureTask : public WebCryptoTask
{
public:
FailureTask(nsresult rv) {
mEarlyRv = rv;
explicit FailureTask(nsresult aRv) {
mEarlyRv = aRv;
}
};

View File

@ -31,7 +31,7 @@ class VersionChangeListener MOZ_FINAL : public nsIDOMEventListener
public:
NS_DECL_ISUPPORTS
VersionChangeListener(IDBDatabase* aDatabase)
explicit VersionChangeListener(IDBDatabase* aDatabase)
: mDatabase(aDatabase)
{}

View File

@ -1790,7 +1790,7 @@ public:
NS_FORWARD_NSICONTENTPERMISSIONREQUEST(mCursor->);
DeviceStorageCursorRequest(nsDOMDeviceStorageCursor* aCursor)
explicit DeviceStorageCursorRequest(nsDOMDeviceStorageCursor* aCursor)
: mCursor(aCursor) { }
private:

View File

@ -34,7 +34,7 @@ enum LineBreakType
class MOZ_STACK_CLASS ContentEventHandler
{
public:
ContentEventHandler(nsPresContext* aPresContext);
explicit ContentEventHandler(nsPresContext* aPresContext);
// NS_QUERY_SELECTED_TEXT event handler
nsresult OnQuerySelectedText(WidgetQueryContentEvent* aEvent);

View File

@ -71,7 +71,7 @@ private:
class EventTargetChainItem
{
private:
EventTargetChainItem(EventTarget* aTarget);
explicit EventTargetChainItem(EventTarget* aTarget);
public:
EventTargetChainItem()
: mFlags(0)

View File

@ -3544,7 +3544,7 @@ EventStateManager::SetCursor(int32_t aCursor, imgIContainer* aContainer,
class MOZ_STACK_CLASS ESMEventCB : public EventDispatchingCallback
{
public:
ESMEventCB(nsIContent* aTarget) : mTarget(aTarget) {}
explicit ESMEventCB(nsIContent* aTarget) : mTarget(aTarget) {}
virtual void HandleEvent(EventChainPostVisitor& aVisitor)
{

View File

@ -386,7 +386,7 @@ IMEContentObserver::NotifySelectionChanged(nsIDOMDocument* aDOMDocument,
class PositionChangeEvent MOZ_FINAL : public nsRunnable
{
public:
PositionChangeEvent(IMEContentObserver* aDispatcher)
explicit PositionChangeEvent(IMEContentObserver* aDispatcher)
: mDispatcher(aDispatcher)
{
MOZ_ASSERT(mDispatcher);
@ -1037,7 +1037,7 @@ IMEContentObserver::MaybeNotifyIMEOfPositionChange()
class AsyncMergeableNotificationsFlusher : public nsRunnable
{
public:
AsyncMergeableNotificationsFlusher(IMEContentObserver* aIMEContentObserver)
explicit AsyncMergeableNotificationsFlusher(IMEContentObserver* aIMEContentObserver)
: mIMEContentObserver(aIMEContentObserver)
{
MOZ_ASSERT(mIMEContentObserver);

View File

@ -746,7 +746,7 @@ IMEStateManager::GetNewIMEState(nsPresContext* aPresContext,
// Helper class, used for IME enabled state change notification
class IMEEnabledStateChangedEvent : public nsRunnable {
public:
IMEEnabledStateChangedEvent(uint32_t aState)
explicit IMEEnabledStateChangedEvent(uint32_t aState)
: mState(aState)
{
}

View File

@ -21,7 +21,7 @@ class PaintRequest MOZ_FINAL : public nsIDOMPaintRequest
, public nsWrapperCache
{
public:
PaintRequest(nsIDOMEvent* aParent)
explicit PaintRequest(nsIDOMEvent* aParent)
: mParent(aParent)
{
mRequest.mFlags = 0;
@ -59,7 +59,7 @@ class PaintRequestList MOZ_FINAL : public nsISupports,
public nsWrapperCache
{
public:
PaintRequestList(nsIDOMEvent *aParent) : mParent(aParent)
explicit PaintRequestList(nsIDOMEvent *aParent) : mParent(aParent)
{
SetIsDOMBinding();
}

View File

@ -33,7 +33,7 @@ public:
AsyncWork(nsIRequestObserver* aObserver, nsISupports* aCtxt);
protected:
AsyncHelper(nsISupports* aStream)
explicit AsyncHelper(nsISupports* aStream)
: mStream(aStream),
mStatus(NS_OK)
{ }

View File

@ -152,7 +152,7 @@ private:
class AsyncFlusher : public AsyncHelper
{
public:
AsyncFlusher(nsISupports* aStream)
explicit AsyncFlusher(nsISupports* aStream)
: AsyncHelper(aStream)
{ }
protected:

View File

@ -256,7 +256,7 @@ public:
NS_DECL_NSIRUNNABLE
private:
FinishHelper(FileHandleBase* aFileHandle);
explicit FinishHelper(FileHandleBase* aFileHandle);
~FinishHelper()
{ }

View File

@ -92,7 +92,7 @@ private:
private:
inline
FileHandleQueue(FileHandleBase* aFileHandle);
explicit FileHandleQueue(FileHandleBase* aFileHandle);
~FileHandleQueue();

View File

@ -50,7 +50,7 @@ public:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIRUNNABLE
CloseRunnable(FileHelper* aFileHelper)
explicit CloseRunnable(FileHelper* aFileHelper)
: mFileHelper(aFileHelper)
{ }
@ -66,7 +66,7 @@ public:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIRUNNABLE
DestroyRunnable(FileHelper* aFileHelper)
explicit DestroyRunnable(FileHelper* aFileHelper)
: mFileHelper(aFileHelper)
{ }

View File

@ -150,7 +150,7 @@ CreateFileTask::Work()
class AutoClose
{
public:
AutoClose(nsIOutputStream* aStream)
explicit AutoClose(nsIOutputStream* aStream)
: mStream(aStream)
{
MOZ_ASSERT(aStream);

View File

@ -41,7 +41,7 @@ class MOZ_STACK_CLASS TransactionPoolEventTarget : public StackBasedEventTarget
public:
NS_DECL_NSIEVENTTARGET
TransactionPoolEventTarget(IDBTransaction* aTransaction)
explicit TransactionPoolEventTarget(IDBTransaction* aTransaction)
: mTransaction(aTransaction)
{ }

View File

@ -47,7 +47,7 @@ public:
}
protected:
HelperBase(IDBRequest* aRequest)
explicit HelperBase(IDBRequest* aRequest)
: mRequest(aRequest)
{ }

View File

@ -43,7 +43,7 @@ namespace {
class CursorHelper : public AsyncConnectionHelper
{
public:
CursorHelper(IDBCursor* aCursor)
explicit CursorHelper(IDBCursor* aCursor)
: AsyncConnectionHelper(aCursor->Transaction(), aCursor->Request()),
mCursor(aCursor), mActor(nullptr)
{

View File

@ -52,7 +52,7 @@ namespace {
class NoRequestDatabaseHelper : public AsyncConnectionHelper
{
public:
NoRequestDatabaseHelper(IDBTransaction* aTransaction)
explicit NoRequestDatabaseHelper(IDBTransaction* aTransaction)
: AsyncConnectionHelper(aTransaction, nullptr)
{
NS_ASSERTION(IndexedDatabaseManager::IsMainProcess(), "Wrong process!");

View File

@ -134,7 +134,7 @@ public:
}
protected:
IDBVersionChangeEvent(mozilla::dom::EventTarget* aOwner)
explicit IDBVersionChangeEvent(mozilla::dom::EventTarget* aOwner)
: Event(aOwner, nullptr, nullptr)
{
SetIsDOMBinding();

View File

@ -65,7 +65,7 @@ public:
IMPL_EVENT_HANDLER(progress)
private:
IDBFileRequest(nsPIDOMWindow* aWindow);
explicit IDBFileRequest(nsPIDOMWindow* aWindow);
~IDBFileRequest();
void

View File

@ -456,7 +456,7 @@ TransactionThreadPool::AbortTransactionsForDatabase(IDBDatabase* aDatabase)
struct MOZ_STACK_CLASS TransactionSearchInfo
{
TransactionSearchInfo(nsIOfflineStorage* aDatabase)
explicit TransactionSearchInfo(nsIOfflineStorage* aDatabase)
: db(aDatabase), found(false)
{
}

View File

@ -62,7 +62,7 @@ protected:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIRUNNABLE
TransactionQueue(IDBTransaction* aTransaction);
explicit TransactionQueue(IDBTransaction* aTransaction);
void Unblock();
@ -84,7 +84,7 @@ protected:
struct TransactionInfo
{
TransactionInfo(IDBTransaction* aTransaction)
explicit TransactionInfo(IDBTransaction* aTransaction)
{
MOZ_COUNT_CTOR(TransactionInfo);

View File

@ -103,7 +103,7 @@ public:
class IPCDeleteDatabaseHelper : public AsyncConnectionHelper
{
public:
IPCDeleteDatabaseHelper(IDBRequest* aRequest)
explicit IPCDeleteDatabaseHelper(IDBRequest* aRequest)
: AsyncConnectionHelper(static_cast<IDBDatabase*>(nullptr), aRequest)
{ }

View File

@ -21,7 +21,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIDELETEDMESSAGEINFO
DeletedMessageInfo(const DeletedMessageInfoData& aData);
explicit DeletedMessageInfo(const DeletedMessageInfoData& aData);
DeletedMessageInfo(int32_t* aMessageIds,
uint32_t aMsgCount,

View File

@ -58,7 +58,7 @@ public:
uint64_t aExpiryDate,
bool aReadReportRequested);
MmsMessage(const mobilemessage::MmsMessageData& aData);
explicit MmsMessage(const mobilemessage::MmsMessageData& aData);
static nsresult Create(int32_t aId,
uint64_t aThreadId,

View File

@ -22,7 +22,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIMOBILEMESSAGECALLBACK
MobileMessageCallback(DOMRequest* aDOMRequest);
explicit MobileMessageCallback(DOMRequest* aDOMRequest);
private:
~MobileMessageCallback();

View File

@ -31,7 +31,7 @@ public:
uint64_t aUnreadCount,
mobilemessage::MessageType aLastMessageType);
MobileMessageThread(const ThreadData& aData);
explicit MobileMessageThread(const ThreadData& aData);
static nsresult Create(uint64_t aId,
const JS::Value& aParticipants,

View File

@ -35,7 +35,7 @@ public:
uint64_t aDeliveryTimestamp,
bool aRead);
SmsMessage(const mobilemessage::SmsMessageData& aData);
explicit SmsMessage(const mobilemessage::SmsMessageData& aData);
static nsresult Create(int32_t aId,
uint64_t aThreadId,

View File

@ -497,7 +497,7 @@ UDPSocket::Init(const nsString& aLocalAddress,
class OpenSocketRunnable MOZ_FINAL : public nsRunnable
{
public:
OpenSocketRunnable(UDPSocket* aSocket) : mSocket(aSocket)
explicit OpenSocketRunnable(UDPSocket* aSocket) : mSocket(aSocket)
{ }
NS_IMETHOD Run() MOZ_OVERRIDE

View File

@ -33,8 +33,8 @@ public:
NS_DECL_ISUPPORTS_INHERITED
NS_DECL_NSICONTENTPERMISSIONREQUEST
DesktopNotificationRequest(DesktopNotification* notification)
: mDesktopNotification(notification) {}
explicit DesktopNotificationRequest(DesktopNotification* aNotification)
: mDesktopNotification(aNotification) {}
NS_IMETHOD Run() MOZ_OVERRIDE
{

View File

@ -184,7 +184,7 @@ public:
NS_DECL_ISUPPORTS
NS_DECL_NSIOBSERVER
NotificationObserver(Notification* aNotification)
explicit NotificationObserver(Notification* aNotification)
: mNotification(aNotification) {}
protected:

View File

@ -101,8 +101,8 @@ NPObjectIsOutOfProcessProxy(NPObject *obj)
class AutoJSExceptionReporter
{
public:
AutoJSExceptionReporter(JSContext *cx)
: mCx(cx)
explicit AutoJSExceptionReporter(JSContext* aCx)
: mCx(aCx)
{
}

View File

@ -380,13 +380,13 @@ class MOZ_STACK_CLASS NPPAutoPusher : public NPPStack,
protected PluginDestructionGuard
{
public:
NPPAutoPusher(NPP npp)
: PluginDestructionGuard(npp),
explicit NPPAutoPusher(NPP aNpp)
: PluginDestructionGuard(aNpp),
mOldNPP(sCurrentNPP)
{
NS_ASSERTION(npp, "Uh, null npp passed to NPPAutoPusher!");
NS_ASSERTION(aNpp, "Uh, null aNpp passed to NPPAutoPusher!");
sCurrentNPP = npp;
sCurrentNPP = aNpp;
}
~NPPAutoPusher()

View File

@ -1153,7 +1153,7 @@ nsNPAPIPluginInstance::IsWindowless(bool* isWindowless)
class MOZ_STACK_CLASS AutoPluginLibraryCall
{
public:
AutoPluginLibraryCall(nsNPAPIPluginInstance* aThis)
explicit AutoPluginLibraryCall(nsNPAPIPluginInstance* aThis)
: mThis(aThis), mGuard(aThis), mLibrary(nullptr)
{
nsNPAPIPlugin* plugin = mThis->GetPlugin();
@ -1669,7 +1669,7 @@ class CarbonEventModelFailureEvent : public nsRunnable {
public:
nsCOMPtr<nsIContent> mContent;
CarbonEventModelFailureEvent(nsIContent* aContent)
explicit CarbonEventModelFailureEvent(nsIContent* aContent)
: mContent(aContent)
{}

View File

@ -3634,7 +3634,7 @@ class nsPluginDestroyRunnable : public nsRunnable,
public PRCList
{
public:
nsPluginDestroyRunnable(nsNPAPIPluginInstance *aInstance)
explicit nsPluginDestroyRunnable(nsNPAPIPluginInstance *aInstance)
: mInstance(aInstance)
{
PR_INIT_CLIST(this);

View File

@ -102,7 +102,7 @@ class nsPluginDOMContextMenuListener : public nsIDOMEventListener
virtual ~nsPluginDOMContextMenuListener();
public:
nsPluginDOMContextMenuListener(nsIContent* aContent);
explicit nsPluginDOMContextMenuListener(nsIContent* aContent);
NS_DECL_ISUPPORTS
NS_DECL_NSIDOMEVENTLISTENER

View File

@ -38,7 +38,7 @@ class nsPluginByteRangeStreamListener
, public nsIInterfaceRequestor
{
public:
nsPluginByteRangeStreamListener(nsIWeakReference* aWeakPtr);
explicit nsPluginByteRangeStreamListener(nsIWeakReference* aWeakPtr);
NS_DECL_ISUPPORTS
NS_DECL_NSIREQUESTOBSERVER

View File

@ -30,7 +30,7 @@ class nsIChannel;
class CachedFileHolder
{
public:
CachedFileHolder(nsIFile* cacheFile);
explicit CachedFileHolder(nsIFile* cacheFile);
~CachedFileHolder();
void AddRef();

View File

@ -117,9 +117,9 @@ static char* CFStringRefToUTF8Buffer(CFStringRef cfString)
class AutoCFTypeObject {
public:
AutoCFTypeObject(CFTypeRef object)
explicit AutoCFTypeObject(CFTypeRef aObject)
{
mObject = object;
mObject = aObject;
}
~AutoCFTypeObject()
{

View File

@ -25,7 +25,7 @@ namespace plugins {
*/
class PluginBackgroundDestroyerParent : public PPluginBackgroundDestroyerParent {
public:
PluginBackgroundDestroyerParent(gfxASurface* aDyingBackground);
explicit PluginBackgroundDestroyerParent(gfxASurface* aDyingBackground);
virtual ~PluginBackgroundDestroyerParent();

View File

@ -349,7 +349,7 @@ PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginUsesDOMForCursor(
class NotificationSink : public CompositionNotifySink
{
public:
NotificationSink(PluginInstanceParent *aInstance) : mInstance(aInstance)
explicit NotificationSink(PluginInstanceParent* aInstance) : mInstance(aInstance)
{ }
virtual void DidComposite() { mInstance->DidComposite(); }

View File

@ -743,10 +743,10 @@ void NotifyBrowserOfPopCursor()
struct WindowInfo {
uint32_t window_id;
CGRect bounds;
WindowInfo(NSWindow* window) {
NSInteger window_num = [window windowNumber];
explicit WindowInfo(NSWindow* aWindow) {
NSInteger window_num = [aWindow windowNumber];
window_id = window_num > 0 ? window_num : 0;
bounds = NSRectToCGRect([window frame]);
bounds = NSRectToCGRect([aWindow frame]);
}
};

View File

@ -87,7 +87,7 @@ protected:
public:
// aFilePath is UTF8, not native!
PluginModuleParent(const char* aFilePath);
explicit PluginModuleParent(const char* aFilePath);
virtual ~PluginModuleParent();
virtual void SetPlugin(nsNPAPIPlugin* plugin) MOZ_OVERRIDE

View File

@ -19,7 +19,7 @@ protected:
typedef mozilla::ipc::ProcessChild ProcessChild;
public:
PluginProcessChild(ProcessHandle parentHandle) : ProcessChild(parentHandle)
explicit PluginProcessChild(ProcessHandle aParentHandle) : ProcessChild(aParentHandle)
{ }
virtual ~PluginProcessChild()

View File

@ -25,7 +25,7 @@ namespace plugins {
class PluginProcessParent : public mozilla::ipc::GeckoChildProcessHost
{
public:
PluginProcessParent(const std::string& aPluginFilePath);
explicit PluginProcessParent(const std::string& aPluginFilePath);
~PluginProcessParent();
/**

View File

@ -36,7 +36,7 @@ class PluginScriptableObjectParent : public PPluginScriptableObjectParent
friend class PluginInstanceParent;
public:
PluginScriptableObjectParent(ScriptableObjectType aType);
explicit PluginScriptableObjectParent(ScriptableObjectType aType);
virtual ~PluginScriptableObjectParent();
void

View File

@ -258,7 +258,7 @@ template<class ActorType, class Traits=ProtectedActorTraits<ActorType> >
class ProtectedActor
{
public:
ProtectedActor(ActorType* aActor) : mActor(aActor)
explicit ProtectedActor(ActorType* aActor) : mActor(aActor)
{
if (!Traits::Nullable()) {
NS_ASSERTION(mActor, "This should never be null!");

View File

@ -41,7 +41,7 @@ NS_IMPL_ISUPPORTS0(PromiseNativeHandler)
class PromiseTask MOZ_FINAL : public nsRunnable
{
public:
PromiseTask(Promise* aPromise)
explicit PromiseTask(Promise* aPromise)
: mPromise(aPromise)
{
MOZ_ASSERT(aPromise);

View File

@ -341,7 +341,7 @@ class ResetOrClearRunnable MOZ_FINAL : public nsRunnable,
public:
NS_DECL_ISUPPORTS_INHERITED
ResetOrClearRunnable(bool aClear)
explicit ResetOrClearRunnable(bool aClear)
: mCallbackState(Pending),
mClear(aClear)
{ }
@ -412,7 +412,7 @@ class FinalizeOriginEvictionRunnable MOZ_FINAL : public nsRunnable
};
public:
FinalizeOriginEvictionRunnable(nsTArray<nsCString>& aOrigins)
explicit FinalizeOriginEvictionRunnable(nsTArray<nsCString>& aOrigins)
: mCallbackState(Pending)
{
mOrigins.SwapElements(aOrigins);
@ -504,7 +504,7 @@ bool gTestingEnabled = false;
class WaitForTransactionsToFinishRunnable MOZ_FINAL : public nsRunnable
{
public:
WaitForTransactionsToFinishRunnable(SynchronizedOp* aOp)
explicit WaitForTransactionsToFinishRunnable(SynchronizedOp* aOp)
: mOp(aOp), mCountdown(1)
{
NS_ASSERTION(mOp, "Why don't we have a runnable?");

View File

@ -21,7 +21,7 @@ class StorageMatcher : public ValueType
struct Closure
{
Closure(SelfType& aSelf)
explicit Closure(SelfType& aSelf)
: mSelf(aSelf), mPattern(EmptyCString()), mIndexes(nullptr)
{ }

View File

@ -122,7 +122,7 @@ namespace
class MOZ_STACK_CLASS nsSMILTimedElement::AutoIntervalUpdateBatcher
{
public:
AutoIntervalUpdateBatcher(nsSMILTimedElement& aTimedElement)
explicit AutoIntervalUpdateBatcher(nsSMILTimedElement& aTimedElement)
: mTimedElement(aTimedElement),
mDidSetFlag(!aTimedElement.mDeferIntervalUpdates)
{
@ -160,7 +160,7 @@ private:
class MOZ_STACK_CLASS nsSMILTimedElement::AutoIntervalUpdater
{
public:
AutoIntervalUpdater(nsSMILTimedElement& aTimedElement)
explicit AutoIntervalUpdater(nsSMILTimedElement& aTimedElement)
: mTimedElement(aTimedElement) { }
~AutoIntervalUpdater()
@ -471,7 +471,7 @@ namespace
class MOZ_STACK_CLASS RemoveByCreator
{
public:
RemoveByCreator(const nsSMILTimeValueSpec* aCreator) : mCreator(aCreator)
explicit RemoveByCreator(const nsSMILTimeValueSpec* aCreator) : mCreator(aCreator)
{ }
bool operator()(nsSMILInstanceTime* aInstanceTime, uint32_t /*aIndex*/)
@ -1338,7 +1338,7 @@ namespace
class MOZ_STACK_CLASS RemoveByFunction
{
public:
RemoveByFunction(nsSMILTimedElement::RemovalTestFunction aFunction)
explicit RemoveByFunction(nsSMILTimedElement::RemovalTestFunction aFunction)
: mFunction(aFunction) { }
bool operator()(nsSMILInstanceTime* aInstanceTime, uint32_t /*aIndex*/)
{
@ -1416,7 +1416,7 @@ namespace
class MOZ_STACK_CLASS RemoveReset
{
public:
RemoveReset(const nsSMILInstanceTime* aCurrentIntervalBegin)
explicit RemoveReset(const nsSMILInstanceTime* aCurrentIntervalBegin)
: mCurrentIntervalBegin(aCurrentIntervalBegin) { }
bool operator()(nsSMILInstanceTime* aInstanceTime, uint32_t /*aIndex*/)
{
@ -1614,7 +1614,7 @@ namespace
class MOZ_STACK_CLASS RemoveFiltered
{
public:
RemoveFiltered(nsSMILTimeValue aCutoff) : mCutoff(aCutoff) { }
explicit RemoveFiltered(nsSMILTimeValue aCutoff) : mCutoff(aCutoff) { }
bool operator()(nsSMILInstanceTime* aInstanceTime, uint32_t /*aIndex*/)
{
// We can filter instance times that:

View File

@ -24,7 +24,7 @@ public:
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(CallsList)
CallsList(Telephony* aTelephony, TelephonyCallGroup* aGroup = nullptr);
explicit CallsList(Telephony* aTelephony, TelephonyCallGroup* aGroup = nullptr);
nsPIDOMWindow*
GetParentObject() const;

View File

@ -39,7 +39,7 @@ public:
NS_DECL_ISUPPORTS
NS_FORWARD_SAFE_NSITELEPHONYLISTENER(mTelephony)
Listener(Telephony* aTelephony)
explicit Listener(Telephony* aTelephony)
: mTelephony(aTelephony)
{
MOZ_ASSERT(mTelephony);

View File

@ -18,7 +18,7 @@ class TelephonyIPCService;
class TelephonyChild : public PTelephonyChild
{
public:
TelephonyChild(TelephonyIPCService* aService);
explicit TelephonyChild(TelephonyIPCService* aService);
protected:
virtual ~TelephonyChild();

View File

@ -33,7 +33,7 @@ class WorkerDataStore MOZ_FINAL : public DOMEventTargetHelper
public:
NS_DECL_ISUPPORTS_INHERITED
WorkerDataStore(WorkerGlobalScope* aScope);
explicit WorkerDataStore(WorkerGlobalScope* aScope);
// WebIDL (internal functions)
@ -137,4 +137,4 @@ private:
} //namespace dom
} //namespace mozilla
#endif
#endif

View File

@ -28,7 +28,7 @@ public:
NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(WorkerDataStoreCursor)
NS_DECL_CYCLE_COLLECTION_NATIVE_CLASS(WorkerDataStoreCursor)
WorkerDataStoreCursor(WorkerDataStore* aWorkerStore);
explicit WorkerDataStoreCursor(WorkerDataStore* aWorkerStore);
// WebIDL (internal functions)
@ -65,4 +65,4 @@ private:
} //namespace dom
} //namespace mozilla
#endif
#endif

View File

@ -22,7 +22,7 @@ public:
NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(Performance)
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(Performance)
Performance(WorkerPrivate* aWorkerPrivate);
explicit Performance(WorkerPrivate* aWorkerPrivate);
private:
~Performance();

View File

@ -918,7 +918,7 @@ class WorkerBackgroundChildCallback MOZ_FINAL :
bool* mDone;
public:
WorkerBackgroundChildCallback(bool* aDone)
explicit WorkerBackgroundChildCallback(bool* aDone)
: mDone(aDone)
{
MOZ_ASSERT(!NS_IsMainThread());
@ -955,7 +955,7 @@ class WorkerThreadPrimaryRunnable MOZ_FINAL : public nsRunnable
nsRefPtr<RuntimeService::WorkerThread> mThread;
public:
FinishedRunnable(already_AddRefed<RuntimeService::WorkerThread> aThread)
explicit FinishedRunnable(already_AddRefed<RuntimeService::WorkerThread> aThread)
: mThread(aThread)
{
MOZ_ASSERT(mThread);
@ -1034,7 +1034,7 @@ class RuntimeService::WorkerThread MOZ_FINAL : public nsThread
WorkerPrivate* mWorkerPrivate;
public:
Observer(WorkerPrivate* aWorkerPrivate)
explicit Observer(WorkerPrivate* aWorkerPrivate)
: mWorkerPrivate(aWorkerPrivate)
{
MOZ_ASSERT(aWorkerPrivate);

View File

@ -78,7 +78,7 @@ private:
WorkerPrivate* mWorkerPrivate;
SharedWorkerInfo* mSharedWorkerInfo;
MatchSharedWorkerInfo(WorkerPrivate* aWorkerPrivate)
explicit MatchSharedWorkerInfo(WorkerPrivate* aWorkerPrivate)
: mWorkerPrivate(aWorkerPrivate), mSharedWorkerInfo(nullptr)
{ }
};

View File

@ -28,7 +28,7 @@ class InstallPhaseEvent : public Event
nsRefPtr<Promise> mPromise;
protected:
InstallPhaseEvent(mozilla::dom::EventTarget* aOwner);
explicit InstallPhaseEvent(mozilla::dom::EventTarget* aOwner);
~InstallPhaseEvent() {}
public:
@ -80,7 +80,7 @@ class InstallEvent MOZ_FINAL : public InstallPhaseEvent
nsRefPtr<ServiceWorker> mActiveWorker;
protected:
InstallEvent(mozilla::dom::EventTarget* aOwner);
explicit InstallEvent(mozilla::dom::EventTarget* aOwner);
~InstallEvent() {}
public:

View File

@ -203,7 +203,7 @@ class FinishFetchOnMainThreadRunnable : public nsRunnable
{
nsMainThreadPtrHandle<ServiceWorkerUpdateInstance> mUpdateInstance;
public:
FinishFetchOnMainThreadRunnable
explicit FinishFetchOnMainThreadRunnable
(const nsMainThreadPtrHandle<ServiceWorkerUpdateInstance>& aUpdateInstance)
: mUpdateInstance(aUpdateInstance)
{ }
@ -1213,7 +1213,7 @@ class FinishActivationRunnable : public nsRunnable
nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo> mRegistration;
public:
FinishActivationRunnable(const nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo>& aRegistration)
explicit FinishActivationRunnable(const nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo>& aRegistration)
: mRegistration(aRegistration)
{
MOZ_ASSERT(!NS_IsMainThread());
@ -1300,7 +1300,7 @@ class FinishActivateHandler : public PromiseNativeHandler
nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo> mRegistration;
public:
FinishActivateHandler(const nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo>& aRegistration)
explicit FinishActivateHandler(const nsMainThreadPtrHandle<ServiceWorkerRegistrationInfo>& aRegistration)
: mRegistration(aRegistration)
{
MOZ_ASSERT(!NS_IsMainThread());

View File

@ -31,7 +31,7 @@ class URLProxy MOZ_FINAL
public:
NS_INLINE_DECL_THREADSAFE_REFCOUNTING(URLProxy)
URLProxy(mozilla::dom::URL* aURL)
explicit URLProxy(mozilla::dom::URL* aURL)
: mURL(aURL)
{
AssertIsOnMainThread();
@ -265,7 +265,7 @@ public:
class TeardownURLRunnable : public nsRunnable
{
public:
TeardownURLRunnable(URLProxy* aURLProxy)
explicit TeardownURLRunnable(URLProxy* aURLProxy)
: mURLProxy(aURLProxy)
{
}

Some files were not shown because too many files have changed in this diff Show More