From bb51fe3a839ac4539bde7ad5b1fffa7ba485d7e7 Mon Sep 17 00:00:00 2001 From: Dave Hylands Date: Wed, 4 Feb 2015 14:05:45 -0800 Subject: [PATCH] Bug 1129231 - Remove a couple JS octal constant warnings. r=fabrice --- b2g/components/DirectoryProvider.js | 2 +- dom/system/gonk/VolumeManagerLog.h | 2 +- dom/system/gonk/nsVolumeService.cpp | 2 ++ toolkit/crashreporter/CrashSubmit.jsm | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/b2g/components/DirectoryProvider.js b/b2g/components/DirectoryProvider.js index 3e9f81eca68..58eb8b4c4fd 100644 --- a/b2g/components/DirectoryProvider.js +++ b/b2g/components/DirectoryProvider.js @@ -227,7 +227,7 @@ DirectoryProvider.prototype = { // subdir doesn't exist, and the parent is writable, so try to // create it. This can fail if a file named updates exists. try { - dir.create(Ci.nsIFile.DIRECTORY_TYPE, 0770); + dir.create(Ci.nsIFile.DIRECTORY_TYPE, parseInt('0770', 8)); } catch (e) { // The create failed for some reason. We can't use it. log("Error: " + dir.path + " unable to create directory"); diff --git a/dom/system/gonk/VolumeManagerLog.h b/dom/system/gonk/VolumeManagerLog.h index 793f4889c9c..373a3575927 100644 --- a/dom/system/gonk/VolumeManagerLog.h +++ b/dom/system/gonk/VolumeManagerLog.h @@ -6,7 +6,7 @@ #define mozilla_system_volumemanagerlog_h__ #undef USE_DEBUG -#define USE_DEBUG 0 +#define USE_DEBUG 1 #if !defined(VOLUME_MANAGER_LOG_TAG) #define VOLUME_MANAGER_LOG_TAG "VolumeManager" diff --git a/dom/system/gonk/nsVolumeService.cpp b/dom/system/gonk/nsVolumeService.cpp index a4858d67433..64af019f9d6 100644 --- a/dom/system/gonk/nsVolumeService.cpp +++ b/dom/system/gonk/nsVolumeService.cpp @@ -268,6 +268,7 @@ nsVolumeService::GetVolumesForIPC(nsTArray* aResult) volInfo->isUnmounting() = vol->mIsUnmounting; volInfo->isRemovable() = vol->mIsRemovable; volInfo->isHotSwappable() = vol->mIsHotSwappable; + DBG("GetVolumesForIPC: adding '%s'", vol->NameStr().get()); } } @@ -295,6 +296,7 @@ nsVolumeService::RecvVolumesFromParent(const nsTArray& aVolumes) volInfo.isUnmounting(), volInfo.isRemovable(), volInfo.isHotSwappable()); + DBG("RecvVolumesFromParent: got '%s'", vol->NameStr().get()); UpdateVolume(vol, false); } } diff --git a/toolkit/crashreporter/CrashSubmit.jsm b/toolkit/crashreporter/CrashSubmit.jsm index fe3a6d3cd3f..932f2ec9664 100644 --- a/toolkit/crashreporter/CrashSubmit.jsm +++ b/toolkit/crashreporter/CrashSubmit.jsm @@ -86,7 +86,7 @@ function getDir(name) { function writeFile(dirName, fileName, data) { let path = getDir(dirName); if (!path.exists()) - path.create(Ci.nsIFile.DIRECTORY_TYPE, 0700); + path.create(Ci.nsIFile.DIRECTORY_TYPE, parseInt('0700', 8)); path.append(fileName); var fs = Cc["@mozilla.org/network/file-output-stream;1"]. createInstance(Ci.nsIFileOutputStream);