Backed out changeset 3af0cab9d0de (bug 1098126)

media/libstagefright/binding/Index.cpp

@@ -75,94 +75,8 @@ RangeFinder::Contains(MediaByteRange aByteRange)
   return false;
 }
 
-SampleIterator::SampleIterator(Index* aIndex)
-  : mIndex(aIndex)
-  , mCurrentMoof(0)
-  , mCurrentSample(0)
-{
-}
-
-MP4Sample* SampleIterator::GetNext()
-{
-  nsAutoPtr<MP4Sample> sample(Get());
-  if (!sample) {
-    return nullptr;
-  }
-
-  // Do the blocking read
-  sample->data = sample->extra_buffer = new uint8_t[sample->size];
-
-  size_t bytesRead;
-  mIndex->mSource->ReadAt(sample->byte_offset, sample->data, sample->size,
-                          &bytesRead);
-
-  // Lets just return what we've got so that we propagate the error
-  sample->size = bytesRead;
-
-  Next();
-
-  return sample.forget();
-}
-
-MP4Sample* SampleIterator::Get()
-{
-  if (!mIndex->mMoofParser) {
-    return nullptr;
-  }
-
-  nsTArray<Moof>& moofs = mIndex->mMoofParser->mMoofs;
-  while (true) {
-    if (mCurrentMoof >= moofs.Length()) {
-      return nsAutoPtr<MP4Sample>();
-    }
-    if (mCurrentSample < moofs[mCurrentMoof].mIndex.Length()) {
-      break;
-    }
-    mCurrentSample = 0;
-    ++mCurrentMoof;
-  }
-  Sample& s = moofs[mCurrentMoof].mIndex[mCurrentSample];
-  nsAutoPtr<MP4Sample> sample(new MP4Sample());
-  sample->decode_timestamp = s.mDecodeTime;
-  sample->composition_timestamp = s.mCompositionRange.start;
-  sample->duration = s.mCompositionRange.end - s.mCompositionRange.start;
-  sample->byte_offset = s.mByteRange.mStart;
-  sample->is_sync_point = s.mSync;
-
-  sample->size = s.mByteRange.mEnd - s.mByteRange.mStart;
-
-  return sample.forget();
-}
-
-void SampleIterator::Next()
-{
-  ++mCurrentSample;
-}
-
-void SampleIterator::Seek(Microseconds aTime)
-{
-  size_t syncMoof = 0;
-  size_t syncSample = 0;
-  mCurrentMoof = 0;
-  mCurrentSample = 0;
-  while (true) {
-    nsAutoPtr<MP4Sample> sample(Get());
-    if (sample->composition_timestamp > aTime) {
-      break;
-    }
-    if (sample->is_sync_point) {
-      syncMoof = mCurrentMoof;
-      syncSample = mCurrentSample;
-    }
-    Next();
-  }
-  mCurrentMoof = syncMoof;
-  mCurrentSample = syncSample;
-}
-
 Index::Index(const stagefright::Vector<MediaSource::Indice>& aIndex,
              Stream* aSource, uint32_t aTrackId)
-  : mSource(aSource)
 {
   if (aIndex.isEmpty()) {
     mMoofParser = new MoofParser(aSource, aTrackId);

media/libstagefright/binding/MoofParser.cpp

@@ -210,7 +210,6 @@ Moof::ParseTrun(Box& aBox, Tfhd& aTfhd, Tfdt& aTfdt, Mdhd& aMdhd, Edts& aEdts)
     sample.mByteRange = MediaByteRange(offset, offset + sampleSize);
     offset += sampleSize;
 
-    sample.mDecodeTime = decodeTime;
     sample.mCompositionRange = Interval<Microseconds>(
       aMdhd.ToMicroseconds((int64_t)decodeTime + ctsOffset - aEdts.mMediaStart),
       aMdhd.ToMicroseconds((int64_t)decodeTime + ctsOffset + sampleDuration - aEdts.mMediaStart));

media/libstagefright/binding/include/mp4_demuxer/DecoderData.h

@@ -165,6 +165,7 @@ public:
 
   void Prepend(const uint8_t* aData, size_t aSize);
 
+private:
   nsAutoArrayPtr<uint8_t> extra_buffer;
 };
 }

media/libstagefright/binding/include/mp4_demuxer/Index.h

@@ -14,30 +14,13 @@ namespace mp4_demuxer
 template <typename T> class Interval;
 class MoofParser;
 class Sample;
-class Index;
-
-class SampleIterator
-{
-public:
-  SampleIterator(Index* aIndex);
-  MP4Sample* GetNext();
-  void Seek(Microseconds aTime);
-
-private:
-  MP4Sample* Get();
-  void Next();
-  nsRefPtr<Index> mIndex;
-  size_t mCurrentMoof;
-  size_t mCurrentSample;
-};
 
 class Index
 {
 public:
-  NS_INLINE_DECL_THREADSAFE_REFCOUNTING(Index)
-
   Index(const stagefright::Vector<stagefright::MediaSource::Indice>& aIndex,
         Stream* aSource, uint32_t aTrackId);
+  ~Index();
 
   void UpdateMoofIndex(const nsTArray<mozilla::MediaByteRange>& aByteRanges);
   Microseconds GetEndCompositionIfBuffered(
@@ -46,14 +29,8 @@ public:
     const nsTArray<mozilla::MediaByteRange>& aByteRanges,
     nsTArray<Interval<Microseconds>>* aTimeRanges);
   uint64_t GetEvictionOffset(Microseconds aTime);
-  bool IsFragmented() { return mMoofParser; }
-
-  friend class SampleIterator;
 
 private:
-  ~Index();
-
-  Stream* mSource;
   nsTArray<Sample> mIndex;
   nsAutoPtr<MoofParser> mMoofParser;
 };

media/libstagefright/binding/include/mp4_demuxer/MoofParser.h

@@ -108,7 +108,6 @@ public:
 struct Sample
 {
   mozilla::MediaByteRange mByteRange;
-  Microseconds mDecodeTime;
   Interval<Microseconds> mCompositionRange;
   bool mSync;
 };

media/libstagefright/binding/mp4_demuxer.cpp

@@ -26,13 +26,11 @@ struct StageFrightPrivate
 
   sp<MediaSource> mAudio;
   MediaSource::ReadOptions mAudioOptions;
-  nsAutoPtr<SampleIterator> mAudioIterator;
 
   sp<MediaSource> mVideo;
   MediaSource::ReadOptions mVideoOptions;
-  nsAutoPtr<SampleIterator> mVideoIterator;
 
-  nsTArray<nsRefPtr<Index>> mIndexes;
+  nsTArray<nsAutoPtr<Index>> mIndexes;
 };
 
 class DataSourceAdapter : public DataSource
@@ -102,31 +100,21 @@ MP4Demuxer::Init()
     }
 
     if (!mPrivate->mAudio.get() && !strncmp(mimeType, "audio/", 6)) {
-      sp<MediaSource> track = e->getTrack(i);
-      if (track->start() != OK) {
+      mPrivate->mAudio = e->getTrack(i);
+      if (mPrivate->mAudio->start() != OK) {
         return false;
       }
-      mPrivate->mAudio = track;
       mAudioConfig.Update(metaData, mimeType);
-      nsRefPtr<Index> index = new Index(mPrivate->mAudio->exportIndex(),
-                                        mSource, mAudioConfig.mTrackId);
-      mPrivate->mIndexes.AppendElement(index);
-      if (index->IsFragmented()) {
-        mPrivate->mAudioIterator = new SampleIterator(index);
-      }
+      mPrivate->mIndexes.AppendElement(new Index(
+        mPrivate->mAudio->exportIndex(), mSource, mAudioConfig.mTrackId));
     } else if (!mPrivate->mVideo.get() && !strncmp(mimeType, "video/", 6)) {
-      sp<MediaSource> track = e->getTrack(i);
-      if (track->start() != OK) {
+      mPrivate->mVideo = e->getTrack(i);
+      if (mPrivate->mVideo->start() != OK) {
         return false;
       }
-      mPrivate->mVideo = track;
       mVideoConfig.Update(metaData, mimeType);
-      nsRefPtr<Index> index = new Index(mPrivate->mVideo->exportIndex(),
-                                        mSource, mVideoConfig.mTrackId);
-      mPrivate->mIndexes.AppendElement(index);
-      if (index->IsFragmented()) {
-        mPrivate->mVideoIterator = new SampleIterator(index);
-      }
+      mPrivate->mIndexes.AppendElement(new Index(
+        mPrivate->mVideo->exportIndex(), mSource, mVideoConfig.mTrackId));
     }
   }
   sp<MetaData> metaData = e->getMetaData();
@@ -162,32 +150,20 @@ MP4Demuxer::CanSeek()
 void
 MP4Demuxer::SeekAudio(Microseconds aTime)
 {
-  if (mPrivate->mAudioIterator) {
-    mPrivate->mAudioIterator->Seek(aTime);
-  } else {
-    mPrivate->mAudioOptions.setSeekTo(
-      aTime, MediaSource::ReadOptions::SEEK_PREVIOUS_SYNC);
-  }
+  mPrivate->mAudioOptions.setSeekTo(
+    aTime, MediaSource::ReadOptions::SEEK_PREVIOUS_SYNC);
 }
 
 void
 MP4Demuxer::SeekVideo(Microseconds aTime)
 {
-  if (mPrivate->mVideoIterator) {
-    mPrivate->mVideoIterator->Seek(aTime);
-  } else {
-    mPrivate->mVideoOptions.setSeekTo(
-      aTime, MediaSource::ReadOptions::SEEK_PREVIOUS_SYNC);
-  }
+  mPrivate->mVideoOptions.setSeekTo(
+    aTime, MediaSource::ReadOptions::SEEK_PREVIOUS_SYNC);
 }
 
 MP4Sample*
 MP4Demuxer::DemuxAudioSample()
 {
-  if (mPrivate->mAudioIterator) {
-    return mPrivate->mAudioIterator->GetNext();
-  }
-
   nsAutoPtr<MP4Sample> sample(new MP4Sample());
   status_t status =
     mPrivate->mAudio->read(&sample->mMediaBuffer, &mPrivate->mAudioOptions);
@@ -205,14 +181,6 @@ MP4Demuxer::DemuxAudioSample()
 MP4Sample*
 MP4Demuxer::DemuxVideoSample()
 {
-  if (mPrivate->mVideoIterator) {
-    nsAutoPtr<MP4Sample> sample(mPrivate->mVideoIterator->GetNext());
-    if (sample) {
-      sample->prefix_data = mVideoConfig.annex_b;
-    }
-    return sample.forget();
-  }
-
   nsAutoPtr<MP4Sample> sample(new MP4Sample());
   status_t status =
     mPrivate->mVideo->read(&sample->mMediaBuffer, &mPrivate->mVideoOptions);