Bug 1264820 - Measure IPC reply size in telemetry (r=mccr8) a=ritu

This commit is contained in:
Bill McCloskey 2016-04-26 13:50:56 -07:00
parent e01fa0d23d
commit ba550c9717
2 changed files with 16 additions and 2 deletions

View File

@ -753,7 +753,7 @@ MessageChannel::Send(Message* aMsg)
{ {
if (aMsg->capacity() >= kMinTelemetryMessageSize) { if (aMsg->capacity() >= kMinTelemetryMessageSize) {
Telemetry::Accumulate(Telemetry::IPC_MESSAGE_SIZE, Telemetry::Accumulate(Telemetry::IPC_MESSAGE_SIZE,
nsCString(aMsg->name()), aMsg->capacity()); nsDependentCString(aMsg->name()), aMsg->capacity());
} }
CxxStackFrame frame(*this, OUT_MESSAGE, aMsg); CxxStackFrame frame(*this, OUT_MESSAGE, aMsg);
@ -1042,7 +1042,7 @@ MessageChannel::Send(Message* aMsg, Message* aReply)
{ {
if (aMsg->capacity() >= kMinTelemetryMessageSize) { if (aMsg->capacity() >= kMinTelemetryMessageSize) {
Telemetry::Accumulate(Telemetry::IPC_MESSAGE_SIZE, Telemetry::Accumulate(Telemetry::IPC_MESSAGE_SIZE,
nsCString(aMsg->name()), aMsg->capacity()); nsDependentCString(aMsg->name()), aMsg->capacity());
} }
nsAutoPtr<Message> msg(aMsg); nsAutoPtr<Message> msg(aMsg);
@ -1227,6 +1227,10 @@ MessageChannel::Send(Message* aMsg, Message* aReply)
MOZ_RELEASE_ASSERT(reply->is_sync()); MOZ_RELEASE_ASSERT(reply->is_sync());
*aReply = Move(*reply); *aReply = Move(*reply);
if (aReply->capacity() >= kMinTelemetryMessageSize) {
Telemetry::Accumulate(Telemetry::IPC_REPLY_SIZE,
nsDependentCString(aReply->name()), aReply->capacity());
}
return true; return true;
} }

View File

@ -10428,6 +10428,16 @@
"keyed": true, "keyed": true,
"description": "Measures the size of IPC messages by message name" "description": "Measures the size of IPC messages by message name"
}, },
"IPC_REPLY_SIZE": {
"alert_emails": ["wmccloskey@mozilla.com"],
"bug_numbers": [1264820],
"expires_in_version": "55",
"kind": "exponential",
"high": 8000000,
"n_buckets": 50,
"keyed": true,
"description": "Measures the size of IPC messages by message name"
},
"MESSAGE_MANAGER_MESSAGE_SIZE": { "MESSAGE_MANAGER_MESSAGE_SIZE": {
"alert_emails": ["wmccloskey@mozilla.com"], "alert_emails": ["wmccloskey@mozilla.com"],
"bug_numbers": [1260908], "bug_numbers": [1260908],