From b89ba90a7bde86cc0174303f46a7851be745bc93 Mon Sep 17 00:00:00 2001
From: Michael Comella <michael.l.comella@gmail.com>
Date: Tue, 10 Mar 2015 18:01:39 -0700
Subject: [PATCH] Bug 1127445 - Fix inconsistencies between v11 and v14.
 r=margaret

---
 .../base/resources/menu-large-v11/browser_app_menu.xml       | 5 ++++-
 mobile/android/base/resources/menu-v11/browser_app_menu.xml  | 5 ++++-
 .../base/resources/menu-xlarge-v11/browser_app_menu.xml      | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml b/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
index d89f5d4ac9d..e3d659f14af 100644
--- a/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml
@@ -35,8 +35,11 @@
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
-    <!-- We only show the quick share items so no need for an icon or title -->
+    <!-- We only show the quick share items so no need for an icon or title.
+
+         The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"
diff --git a/mobile/android/base/resources/menu-v11/browser_app_menu.xml b/mobile/android/base/resources/menu-v11/browser_app_menu.xml
index c8d16419f99..f52870922e8 100644
--- a/mobile/android/base/resources/menu-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-v11/browser_app_menu.xml
@@ -35,8 +35,11 @@
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
-    <!-- We only show the quick share items so no need for an icon or title -->
+    <!-- We only show the quick share items so no need for an icon or title.
+
+         The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"
diff --git a/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml b/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
index 899f165c665..78e7b6d7e32 100644
--- a/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
+++ b/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml
@@ -35,8 +35,11 @@
           android:title="@string/share"
           android:showAsAction="ifRoom"/>
 
-    <!-- We only show the quick share items so no need for an icon or title -->
+    <!-- We only show the quick share items so no need for an icon or title.
+
+         The visibility is changed dynamically for v14+ - hide for previous versions. -->
     <item android:id="@+id/quickshare"
+          android:visibility="gone"
           android:showAsAction="collapseActionView"/>
 
     <item android:id="@+id/new_tab"