Bug 1125665 - Fix -Wunused-private-field warning in PLDHashTable and mark xpcom/glue as FAIL_ON_WARNINGS. r=froydnj

xpcom/glue/moz.build

@@ -112,3 +112,5 @@ LOCAL_INCLUDES += [
 
 if CONFIG['ENABLE_TESTS']:
     DIRS += ['tests/gtest']
+
+FAIL_ON_WARNINGS = True

xpcom/glue/nomozalloc/moz.build

@@ -40,3 +40,5 @@ USE_STATIC_LIBS = True
 
 # Don't use STL wrappers here (i.e. wrapped <new>); they require mozalloc
 DISABLE_STL_WRAPPING = True
+
+FAIL_ON_WARNINGS = True

xpcom/glue/pldhash.h

@@ -184,9 +184,12 @@ private:
    * |mRecursionLevel| is only used in debug builds, but is present in opt
    * builds to avoid binary compatibility problems when mixing DEBUG and
    * non-DEBUG components.  (Actually, even if it were removed,
-   * sizeof(PLDHashTable) wouldn't change, due to struct padding.)
+   * sizeof(PLDHashTable) wouldn't change, due to struct padding.) Make it
+   * protected to suppress -Wunused-private-field warnings in opt builds.
    */
+protected:
   mutable uint16_t    mRecursionLevel;/* used to detect unsafe re-entry */
+private:
   uint32_t            mEntrySize;     /* number of bytes in an entry */
   uint32_t            mEntryCount;    /* number of entries in table */
   uint32_t            mRemovedCount;  /* removed entry sentinels in table */

xpcom/glue/standalone/moz.build

@@ -42,3 +42,5 @@ LOCAL_INCLUDES += [
 
 # Don't use STL wrappers here (i.e. wrapped <new>); they require mozalloc
 DISABLE_STL_WRAPPING = True
+
+FAIL_ON_WARNINGS = True

xpcom/glue/standalone/staticruntime/moz.build

@@ -37,3 +37,5 @@ USE_STATIC_LIBS = True
 
 # Don't use STL wrappers here (i.e. wrapped <new>); they require mozalloc
 DISABLE_STL_WRAPPING = True
+
+FAIL_ON_WARNINGS = True

xpcom/glue/staticruntime/moz.build

@@ -35,3 +35,5 @@ USE_STATIC_LIBS = True
 
 # Don't use STL wrappers here (i.e. wrapped <new>); they require mozalloc
 DISABLE_STL_WRAPPING = True
+
+FAIL_ON_WARNINGS = True