wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 545752 - DB Statements aren't finalized in HistoryStore [r=mconnor] (CLOSED TREE)

Browse Source 
Also nullifies the cached service so we don't leak.
This commit is contained in:
Paul O’Shannessy 2010-08-03 19:01:42 -07:00
parent 7ebaddc528
commit b3b7520797
1 changed files with 28 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
services/sync/modules/engines/history.js
View File

@ -86,27 +86,44 @@ HistoryEngine.prototype = {
function HistoryStore(name) {
Store.call(this, name);
// Explicitly nullify our references to our cached services so we don't leak
Observers.add("places-shutdown", function() {
for each([query, stmt] in Iterator(this._stmts))
stmt.finalize();
this.__hsvc = null;
this._stmts = [];
}, this);
}
HistoryStore.prototype = {
__proto__: Store.prototype,
__hsvc: null,
get _hsvc() {
let hsvc = Cc["@mozilla.org/browser/nav-history-service;1"].
getService(Ci.nsINavHistoryService);
hsvc.QueryInterface(Ci.nsIGlobalHistory2);
hsvc.QueryInterface(Ci.nsIBrowserHistory);
hsvc.QueryInterface(Ci.nsPIPlacesDatabase);
this.__defineGetter__("_hsvc", function() hsvc);
return hsvc;
if (!this.__hsvc)
this.__hsvc = Cc["@mozilla.org/browser/nav-history-service;1"].
getService(Ci.nsINavHistoryService).
QueryInterface(Ci.nsIGlobalHistory2).
QueryInterface(Ci.nsIBrowserHistory).
QueryInterface(Ci.nsPIPlacesDatabase);
return this.__hsvc;
},
get _db() {
return this._hsvc.DBConnection;
},
_stmts: [],
_getStmt: function(query) {
if (query in this._stmts)
return this._stmts[query];
this._log.trace("Creating SQL statement: " + query);
return this._stmts[query] = this._db.createStatement(query);
},
get _visitStm() {
this._log.trace("Creating SQL statement: _visitStm");
let stm = this._db.createStatement(
return this._getStmt(
"SELECT visit_type type, visit_date date " +
"FROM moz_historyvisits_view " +
"WHERE place_id = (" +
@ -114,13 +131,10 @@ HistoryStore.prototype = {
"FROM moz_places_view " +
"WHERE url = :url) " +
"ORDER BY date DESC LIMIT 10");
this.__defineGetter__("_visitStm", function() stm);
return stm;
},
get _urlStm() {
this._log.trace("Creating SQL statement: _urlStm");
let stm = this._db.createStatement(
return this._getStmt(
"SELECT url, title, frecency " +
"FROM moz_places_view " +
"WHERE id = (" +
@ -130,20 +144,15 @@ HistoryStore.prototype = {
"SELECT id " +
"FROM moz_anno_attributes " +
"WHERE name = '" + GUID_ANNO + "'))");
this.__defineGetter__("_urlStm", function() stm);
return stm;
},
get _allUrlStm() {
this._log.trace("Creating SQL statement: _allUrlStm");
let stm = this._db.createStatement(
return this._getStmt(
"SELECT url " +
"FROM moz_places_view " +
"WHERE last_visit_date > :cutoff_date " +
"ORDER BY frecency DESC " +
"LIMIT :max_results");
this.__defineGetter__("_allUrlStm", function() stm);
return stm;
},
// See bug 320831 for why we use SQL here