Bug 900776 - Trace actor reports NaN time when exiting frames; r=fitzgen

This commit is contained in:
Jake Bailey 2013-08-02 17:26:30 -07:00
parent 78d822448e
commit b1dabe726f
3 changed files with 16 additions and 1 deletions

View File

@ -286,7 +286,10 @@ TraceActor.prototype = {
sequence: this._sequence++
};
this._handleEvent(TraceTypes.Events.exitFrame, packet, { value: aValue });
this._handleEvent(TraceTypes.Events.exitFrame, packet, {
value: aValue,
startTime: this._startTime
});
this.conn.send(packet);
}

View File

@ -40,6 +40,8 @@ function test_enter_exit_frame()
'enteredFrame response should have type "enteredFrame"');
do_check_eq(typeof aPacket.sequence, "number",
'enteredFrame response should have sequence number');
do_check_true(!isNaN(aPacket.sequence),
'enteredFrame sequence should be a number');
do_check_eq(typeof aPacket.name, "string",
'enteredFrame response should have function name');
packetNames[aPacket.sequence] = aPacket.name;
@ -51,6 +53,8 @@ function test_enter_exit_frame()
'exitedFrame response should have type "exitedFrame"');
do_check_eq(typeof aPacket.sequence, "number",
'exitedFrame response should have sequence number');
do_check_true(!isNaN(aPacket.sequence),
'exitedFrame sequence should be a number');
});
start_trace()

View File

@ -37,12 +37,16 @@ function test_enter_exit_frame()
'enteredFrame response should have type "enteredFrame"');
do_check_eq(typeof aPacket.sequence, "number",
'enteredFrame response should have sequence number');
do_check_true(!isNaN(aPacket.sequence),
'enteredFrame sequence should be a number');
do_check_eq(typeof aPacket.name, "string",
'enteredFrame response should have function name');
do_check_eq(typeof aPacket.callsite, "object",
'enteredFrame response should have callsite');
do_check_eq(typeof aPacket.time, "number",
'enteredFrame response should have time');
do_check_true(!isNaN(aPacket.time),
'enteredFrame time should be a number');
packets[aPacket.sequence] = aPacket;
});
@ -51,8 +55,12 @@ function test_enter_exit_frame()
'exitedFrame response should have type "exitedFrame"');
do_check_eq(typeof aPacket.sequence, "number",
'exitedFrame response should have sequence number');
do_check_true(!isNaN(aPacket.sequence),
'exitedFrame sequence should be a number');
do_check_eq(typeof aPacket.time, "number",
'exitedFrame response should have time');
do_check_true(!isNaN(aPacket.time),
'exitedFrame time should be a number');
packets[aPacket.sequence] = aPacket;
});