wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

merge backout

Browse Source
This commit is contained in:
Marco Bonardo 2010-01-16 06:46:35 -08:00
commit b06d9fd4a0
3 changed files with 134 additions and 134 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

222
toolkit/components/places/src/nsNavBookmarks.cpp
View File

@ -1210,9 +1210,8 @@ nsNavBookmarks::InsertBookmark(PRInt64 aFolder,
rv = AddBookmarkToHash(childID, 0); rv = AddBookmarkToHash(childID, 0);
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemAdded(*aNewBookmarkId, aFolder, index, TYPE_BOOKMARK));
OnItemAdded(*aNewBookmarkId, aFolder, index, TYPE_BOOKMARK));
// If the bookmark has been added to a tag container, notify all // If the bookmark has been added to a tag container, notify all
// bookmark-folder result nodes which contain a bookmark for the new // bookmark-folder result nodes which contain a bookmark for the new
@ -1228,11 +1227,13 @@ nsNavBookmarks::InsertBookmark(PRInt64 aFolder,
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i++) { for (PRUint32 i = 0; i < bookmarks.Length(); i++) {
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(bookmarks[i],
OnItemChanged(bookmarks[i], NS_LITERAL_CSTRING("tags"), NS_LITERAL_CSTRING("tags"),
PR_FALSE, EmptyCString(), 0, PR_FALSE,
TYPE_BOOKMARK)); EmptyCString(),
0,
TYPE_BOOKMARK));
} }
} }
} }
@ -1283,9 +1284,8 @@ nsNavBookmarks::RemoveItem(PRInt64 aItemId)
return NS_OK; return NS_OK;
} }
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnBeforeItemRemoved(aItemId, itemType));
OnBeforeItemRemoved(aItemId, itemType));
mozStorageTransaction transaction(mDBConn, PR_FALSE); mozStorageTransaction transaction(mDBConn, PR_FALSE);
@ -1328,9 +1328,8 @@ nsNavBookmarks::RemoveItem(PRInt64 aItemId)
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
} }
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemRemoved(aItemId, folderId, childIndex, itemType));
OnItemRemoved(aItemId, folderId, childIndex, itemType));
if (itemType == TYPE_BOOKMARK) { if (itemType == TYPE_BOOKMARK) {
// If the removed bookmark was a child of a tag container, notify all // If the removed bookmark was a child of a tag container, notify all
@ -1350,11 +1349,13 @@ nsNavBookmarks::RemoveItem(PRInt64 aItemId)
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i++) { for (PRUint32 i = 0; i < bookmarks.Length(); i++) {
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(bookmarks[i],
OnItemChanged(bookmarks[i], NS_LITERAL_CSTRING("tags"),
NS_LITERAL_CSTRING("tags"), PR_FALSE, PR_FALSE,
EmptyCString(), 0, TYPE_BOOKMARK)); EmptyCString(),
0,
TYPE_BOOKMARK));
} }
} }
} }
@ -1475,9 +1476,8 @@ nsNavBookmarks::CreateContainerWithID(PRInt64 aItemId,
rv = transaction.Commit(); rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemAdded(*aNewFolder, aParent, index, containerType));
OnItemAdded(*aNewFolder, aParent, index, containerType));
*aIndex = index; *aIndex = index;
return NS_OK; return NS_OK;
@ -1521,9 +1521,8 @@ nsNavBookmarks::InsertSeparator(PRInt64 aParent,
rv = transaction.Commit(); rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemAdded(*aNewItemId, aParent, index, TYPE_SEPARATOR));
OnItemAdded(*aNewItemId, aParent, index, TYPE_SEPARATOR));
return NS_OK; return NS_OK;
} }
@ -1614,9 +1613,8 @@ nsNavBookmarks::RemoveFolder(PRInt64 aFolderId)
{ {
NS_ENSURE_TRUE(aFolderId != mRoot, NS_ERROR_INVALID_ARG); NS_ENSURE_TRUE(aFolderId != mRoot, NS_ERROR_INVALID_ARG);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnBeforeItemRemoved(aFolderId, TYPE_FOLDER));
OnBeforeItemRemoved(aFolderId, TYPE_FOLDER));
mozStorageTransaction transaction(mDBConn, PR_FALSE); mozStorageTransaction transaction(mDBConn, PR_FALSE);
@ -1694,9 +1692,8 @@ nsNavBookmarks::RemoveFolder(PRInt64 aFolderId)
mToolbarFolder = 0; mToolbarFolder = 0;
} }
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemRemoved(aFolderId, parent, index, TYPE_FOLDER));
OnItemRemoved(aFolderId, parent, index, TYPE_FOLDER));
return NS_OK; return NS_OK;
} }
@ -1827,9 +1824,8 @@ nsNavBookmarks::RemoveFolderChildren(PRInt64 aFolderId)
folderChildrenInfo child = folderChildrenArray[i]; folderChildrenInfo child = folderChildrenArray[i];
// Notify observers that we are about to remove this child. // Notify observers that we are about to remove this child.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnBeforeItemRemoved(child.itemId, child.itemType));
OnBeforeItemRemoved(child.itemId, child.itemType));
if (child.itemType == TYPE_FOLDER) { if (child.itemType == TYPE_FOLDER) {
foldersToRemove.AppendLiteral(","); foldersToRemove.AppendLiteral(",");
@ -1904,10 +1900,11 @@ nsNavBookmarks::RemoveFolderChildren(PRInt64 aFolderId)
for (PRInt32 i = folderChildrenArray.Length() - 1; i >= 0 ; i--) { for (PRInt32 i = folderChildrenArray.Length() - 1; i >= 0 ; i--) {
folderChildrenInfo child = folderChildrenArray[i]; folderChildrenInfo child = folderChildrenArray[i];
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemRemoved(child.itemId,
OnItemRemoved(child.itemId, child.parentId, child.index, child.parentId,
child.itemType)); child.index,
child.itemType));
if (child.itemType == TYPE_BOOKMARK) { if (child.itemType == TYPE_BOOKMARK) {
// If the removed bookmark was a child of a tag container, notify all // If the removed bookmark was a child of a tag container, notify all
@ -1925,11 +1922,13 @@ nsNavBookmarks::RemoveFolderChildren(PRInt64 aFolderId)
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i++) { for (PRUint32 i = 0; i < bookmarks.Length(); i++) {
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(bookmarks[i],
OnItemChanged(bookmarks[i], NS_LITERAL_CSTRING("tags"),
NS_LITERAL_CSTRING("tags"), PR_FALSE, PR_FALSE,
EmptyCString(), 0, TYPE_BOOKMARK)); EmptyCString(),
0,
TYPE_BOOKMARK));
} }
} }
} }
@ -2096,10 +2095,10 @@ nsNavBookmarks::MoveItem(PRInt64 aItemId, PRInt64 aNewParent, PRInt32 aIndex)
rv = transaction.Commit(); rv = transaction.Commit();
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, // notify bookmark observers
nsINavBookmarkObserver, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
OnItemMoved(aItemId, oldParent, oldIndex, aNewParent, OnItemMoved(aItemId, oldParent, oldIndex, aNewParent,
newIndex, itemType)); newIndex, itemType));
// notify dynamic container provider if there is one // notify dynamic container provider if there is one
if (!folderType.IsEmpty()) { if (!folderType.IsEmpty()) {
@ -2150,12 +2149,12 @@ nsNavBookmarks::SetItemDateAdded(PRInt64 aItemId, PRTime aDateAdded)
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// Note: mDBSetItemDateAdded also sets lastModified to aDateAdded. // Note: mDBSetItemDateAdded also sets lastModified to aDateAdded.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(aItemId, NS_LITERAL_CSTRING("dateAdded"),
OnItemChanged(aItemId, NS_LITERAL_CSTRING("dateAdded"), PR_FALSE,
PR_FALSE, nsPrintfCString(16, "%lld", aDateAdded),
nsPrintfCString(16, "%lld", aDateAdded), aDateAdded,
aDateAdded, itemType)); itemType));
return NS_OK; return NS_OK;
} }
@ -2194,12 +2193,13 @@ nsNavBookmarks::SetItemLastModified(PRInt64 aItemId, PRTime aLastModified)
aItemId, aLastModified); aItemId, aLastModified);
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(aItemId,
OnItemChanged(aItemId, NS_LITERAL_CSTRING("lastModified"), NS_LITERAL_CSTRING("lastModified"),
PR_FALSE, PR_FALSE,
nsPrintfCString(16, "%lld", aLastModified), nsPrintfCString(16, "%lld", aLastModified),
aLastModified, itemType)); aLastModified,
itemType));
return NS_OK; return NS_OK;
} }
@ -2342,10 +2342,13 @@ nsNavBookmarks::SetItemTitle(PRInt64 aItemId, const nsACString& aTitle)
rv = statement->Execute(); rv = statement->Execute();
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(aItemId,
OnItemChanged(aItemId, NS_LITERAL_CSTRING("title"), PR_FALSE, NS_LITERAL_CSTRING("title"),
aTitle, lastModified, itemType)); PR_FALSE,
aTitle,
lastModified,
itemType));
return NS_OK; return NS_OK;
} }
@ -2769,10 +2772,9 @@ nsNavBookmarks::ChangeBookmarkURI(PRInt64 aBookmarkId, nsIURI* aNewURI)
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// Pass the new URI to OnItemChanged. // Pass the new URI to OnItemChanged.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(aBookmarkId, NS_LITERAL_CSTRING("uri"), PR_FALSE, spec,
OnItemChanged(aBookmarkId, NS_LITERAL_CSTRING("uri"), lastModified, TYPE_BOOKMARK));
PR_FALSE, spec, lastModified, TYPE_BOOKMARK));
return NS_OK; return NS_OK;
} }
@ -2932,10 +2934,9 @@ nsNavBookmarks::SetItemIndex(PRInt64 aItemId, PRInt32 aNewIndex)
rv = stmt->Execute(); rv = stmt->Execute();
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemMoved(aItemId, parent, oldIndex, parent,
OnItemMoved(aItemId, parent, oldIndex, parent, aNewIndex, aNewIndex, itemType));
itemType));
return NS_OK; return NS_OK;
} }
@ -3024,11 +3025,10 @@ nsNavBookmarks::SetKeywordForBookmark(PRInt64 aBookmarkId,
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// Pass the new keyword to OnItemChanged. // Pass the new keyword to OnItemChanged.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(aBookmarkId, NS_LITERAL_CSTRING("keyword"),
OnItemChanged(aBookmarkId, NS_LITERAL_CSTRING("keyword"), PR_FALSE, NS_ConvertUTF16toUTF8(aKeyword),
PR_FALSE, NS_ConvertUTF16toUTF8(aKeyword), lastModified, TYPE_BOOKMARK));
lastModified, TYPE_BOOKMARK));
return NS_OK; return NS_OK;
} }
@ -3124,8 +3124,8 @@ nsNavBookmarks::BeginUpdateBatch()
if (mBatchHasTransaction) if (mBatchHasTransaction)
conn->BeginTransaction(); conn->BeginTransaction();
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnBeginUpdateBatch()); OnBeginUpdateBatch());
} }
return NS_OK; return NS_OK;
} }
@ -3138,8 +3138,8 @@ nsNavBookmarks::EndUpdateBatch()
if (mBatchHasTransaction) if (mBatchHasTransaction)
mDBConn->CommitTransaction(); mDBConn->CommitTransaction();
mBatchHasTransaction = PR_FALSE; mBatchHasTransaction = PR_FALSE;
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnEndUpdateBatch()); OnEndUpdateBatch());
} }
return NS_OK; return NS_OK;
} }
@ -3209,9 +3209,8 @@ nsNavBookmarks::OnVisit(nsIURI* aURI, PRInt64 aVisitID, PRTime aTime,
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i++) for (PRUint32 i = 0; i < bookmarks.Length(); i++)
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemVisited(bookmarks[i], aVisitID, aTime));
OnItemVisited(bookmarks[i], aVisitID, aTime));
} }
} }
return NS_OK; return NS_OK;
@ -3240,12 +3239,13 @@ nsNavBookmarks::OnDeleteURI(nsIURI* aURI)
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i ++) for (PRUint32 i = 0; i < bookmarks.Length(); i ++)
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(bookmarks[i],
OnItemChanged(bookmarks[i], NS_LITERAL_CSTRING("cleartime"),
NS_LITERAL_CSTRING("cleartime"), PR_FALSE,
PR_FALSE, EmptyCString(), 0, EmptyCString(),
TYPE_BOOKMARK)); 0,
TYPE_BOOKMARK));
} }
} }
return NS_OK; return NS_OK;
@ -3295,13 +3295,13 @@ nsNavBookmarks::OnPageChanged(nsIURI* aURI, PRUint32 aWhat,
NS_ENSURE_STATE(queries.Count() == 1); NS_ENSURE_STATE(queries.Count() == 1);
NS_ENSURE_STATE(queries[0]->Folders().Length() == 1); NS_ENSURE_STATE(queries[0]->Folders().Length() == 1);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(queries[0]->Folders()[0],
OnItemChanged(queries[0]->Folders()[0], NS_LITERAL_CSTRING("favicon"),
NS_LITERAL_CSTRING("favicon"), PR_FALSE,
PR_FALSE, NS_ConvertUTF16toUTF8(aValue),
NS_ConvertUTF16toUTF8(aValue), 0,
0, TYPE_BOOKMARK)); TYPE_BOOKMARK));
} }
else { else {
// query for all bookmarks for that URI, notify for each // query for all bookmarks for that URI, notify for each
@ -3311,13 +3311,13 @@ nsNavBookmarks::OnPageChanged(nsIURI* aURI, PRUint32 aWhat,
if (bookmarks.Length()) { if (bookmarks.Length()) {
for (PRUint32 i = 0; i < bookmarks.Length(); i ++) for (PRUint32 i = 0; i < bookmarks.Length(); i ++)
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavBookmarkObserver,
nsINavBookmarkObserver, OnItemChanged(bookmarks[i],
OnItemChanged(bookmarks[i], NS_LITERAL_CSTRING("favicon"),
NS_LITERAL_CSTRING("favicon"), PR_FALSE,
PR_FALSE, NS_ConvertUTF16toUTF8(aValue),
NS_ConvertUTF16toUTF8(aValue), 0,
0, TYPE_BOOKMARK)); TYPE_BOOKMARK));
} }
} }
} }
@ -3355,10 +3355,10 @@ nsNavBookmarks::OnItemAnnotationSet(PRInt64 aItemId, const nsACString& aName)
aItemId, lastModified); aItemId, lastModified);
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavBookmarkObserver, nsINavBookmarkObserver,
OnItemChanged(aItemId, aName, PR_TRUE, EmptyCString(), OnItemChanged(aItemId, aName, PR_TRUE, EmptyCString(),
lastModified, itemType)); lastModified, itemType));
return NS_OK; return NS_OK;
} }
@ -3384,10 +3384,10 @@ nsNavBookmarks::OnItemAnnotationRemoved(PRInt64 aItemId, const nsACString& aName
aItemId, lastModified); aItemId, lastModified);
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavBookmarkObserver, nsINavBookmarkObserver,
OnItemChanged(aItemId, aName, PR_TRUE, EmptyCString(), OnItemChanged(aItemId, aName, PR_TRUE, EmptyCString(),
lastModified, itemType)); lastModified, itemType));
return NS_OK; return NS_OK;
} }

44
toolkit/components/places/src/nsNavHistory.cpp
View File

@ -2782,10 +2782,9 @@ nsNavHistory::AddVisit(nsIURI* aURI, PRTime aTime, nsIURI* aReferringURI,
PRUint32 added = 0; PRUint32 added = 0;
if (!hidden && aTransitionType != TRANSITION_EMBED && if (!hidden && aTransitionType != TRANSITION_EMBED &&
aTransitionType != TRANSITION_DOWNLOAD) { aTransitionType != TRANSITION_DOWNLOAD) {
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver,
nsINavHistoryObserver, OnVisit(aURI, *aVisitID, aTime, aSessionID,
OnVisit(aURI, *aVisitID, aTime, aSessionID, referringVisitID, aTransitionType, &added));
referringVisitID, aTransitionType, &added));
} }
// Normally docshell sends the link visited observer notification for us (this // Normally docshell sends the link visited observer notification for us (this
@ -4220,8 +4219,8 @@ nsNavHistory::BeginUpdateBatch()
if (mBatchHasTransaction) if (mBatchHasTransaction)
mDBConn->BeginTransaction(); mDBConn->BeginTransaction();
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver,
nsINavHistoryObserver, OnBeginUpdateBatch()); OnBeginUpdateBatch());
} }
return NS_OK; return NS_OK;
} }
@ -4234,8 +4233,8 @@ nsNavHistory::EndUpdateBatch()
if (mBatchHasTransaction) if (mBatchHasTransaction)
mDBConn->CommitTransaction(); mDBConn->CommitTransaction();
mBatchHasTransaction = PR_FALSE; mBatchHasTransaction = PR_FALSE;
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver,
nsINavHistoryObserver, OnEndUpdateBatch()); OnEndUpdateBatch());
} }
return NS_OK; return NS_OK;
} }
@ -4548,16 +4547,16 @@ nsNavHistory::RemovePage(nsIURI *aURI)
NS_ENSURE_ARG(aURI); NS_ENSURE_ARG(aURI);
// Before we remove, we have to notify our observers! // Before we remove, we have to notify our observers!
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavHistoryObserver, OnBeforeDeleteURI(aURI)); nsINavHistoryObserver, OnBeforeDeleteURI(aURI));
nsIURI** URIs = &aURI; nsIURI** URIs = &aURI;
nsresult rv = RemovePages(URIs, 1, PR_FALSE); nsresult rv = RemovePages(URIs, 1, PR_FALSE);
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// Notify our observers that the URI has been removed. // Notify our observers that the URI has been removed.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavHistoryObserver, OnDeleteURI(aURI)); nsINavHistoryObserver, OnDeleteURI(aURI));
return NS_OK; return NS_OK;
} }
@ -4880,8 +4879,8 @@ nsNavHistory::RemoveAllPages()
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// Expiration will take care of orphans. // Expiration will take care of orphans.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavHistoryObserver, OnClearHistory()); nsINavHistoryObserver, OnClearHistory());
// privacy cleanup, if there's an old history.dat around, just delete it // privacy cleanup, if there's an old history.dat around, just delete it
nsCOMPtr<nsIFile> oldHistoryFile; nsCOMPtr<nsIFile> oldHistoryFile;
@ -5501,13 +5500,14 @@ nsNavHistory::NotifyOnPageExpired(nsIURI *aURI, PRTime aVisitTime,
{ {
if (aWholeEntry) { if (aWholeEntry) {
// Notify our observers that the page has been removed. // Notify our observers that the page has been removed.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavHistoryObserver, OnDeleteURI(aURI)); nsINavHistoryObserver, OnDeleteURI(aURI));
} }
else { else {
// Notify our observers that some visits for the page have been removed. // Notify our observers that some visits for the page have been removed.
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers,
nsINavHistoryObserver, OnDeleteVisits(aURI, aVisitTime)); nsINavHistoryObserver,
OnDeleteVisits(aURI, aVisitTime));
} }
return NS_OK; return NS_OK;
@ -6939,8 +6939,8 @@ void
nsNavHistory::SendPageChangedNotification(nsIURI* aURI, PRUint32 aWhat, nsNavHistory::SendPageChangedNotification(nsIURI* aURI, PRUint32 aWhat,
const nsAString& aValue) const nsAString& aValue)
{ {
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver,
nsINavHistoryObserver, OnPageChanged(aURI, aWhat, aValue)); OnPageChanged(aURI, aWhat, aValue));
} }
// nsNavHistory::TitleForDomain // nsNavHistory::TitleForDomain
@ -7072,8 +7072,8 @@ nsNavHistory::SetPageTitleInternal(nsIURI* aURI, const nsAString& aTitle)
NS_ENSURE_SUCCESS(rv, rv); NS_ENSURE_SUCCESS(rv, rv);
// observers (have to check first if it's bookmarked) // observers (have to check first if it's bookmarked)
NOTIFY_OBSERVERS(mCanNotify, mCacheObservers, mObservers, ENUMERATE_OBSERVERS(mCanNotify, mCacheObservers, mObservers, nsINavHistoryObserver,
nsINavHistoryObserver, OnTitleChanged(aURI, aTitle)); OnTitleChanged(aURI, aTitle));
return NS_OK; return NS_OK;
} }

2
toolkit/components/places/src/nsPlacesMacros.h
View File

@ -39,7 +39,7 @@
// Call a method on each observer in a category cache, then call the same // Call a method on each observer in a category cache, then call the same
// method on the observer array. // method on the observer array.
#define NOTIFY_OBSERVERS(canFire, cache, array, type, method) \ #define ENUMERATE_OBSERVERS(canFire, cache, array, type, method) \
PR_BEGIN_MACRO \ PR_BEGIN_MACRO \
if (canFire) { \ if (canFire) { \
const nsCOMArray<type> &entries = cache.GetEntries(); \ const nsCOMArray<type> &entries = cache.GetEntries(); \