wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 961523 - Never show a snippet again after a user dismisses it. r=bnicholson

Browse Source
This commit is contained in:
Margaret Leibovic 2014-02-20 18:04:08 -08:00
parent ee790c9883
commit aff331a47a
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
mobile/android/components/Snippets.js
View File

@ -30,6 +30,9 @@ const SNIPPETS_GEO_LAST_UPDATE_PREF = "browser.snippets.geoLastUpdate";
// Pref where we'll cache the user's country.
const SNIPPETS_COUNTRY_CODE_PREF = "browser.snippets.countryCode";
// Pref where we store an array IDs of snippets that should not be shown again
const SNIPPETS_REMOVED_IDS_PREF = "browser.snippets.removedIds";
// How frequently we update the user's country code from the server (30 days).
const SNIPPETS_GEO_UPDATE_INTERVAL_MS = 86400000*30;
@ -169,6 +172,17 @@ function updateBanner(response) {
gMessageIds = [];
let messages = JSON.parse(response);
try {
let removedSnippetIds = JSON.parse(Services.prefs.getCharPref(SNIPPETS_REMOVED_IDS_PREF));
messages = messages.filter(function(message) {
// Only include the snippet if it has not been previously removed.
return removedSnippetIds.indexOf(message.id) === -1;
});
} catch (e) {
// If the pref doesn't exist, there aren't any snippets to filter out.
}
messages.forEach(function(message) {
// Don't add this message to the banner if it's not supposed to be shown in this country.
if ("target_geo" in message && message.target_geo != gCountryCode) {
@ -181,6 +195,11 @@ function updateBanner(response) {
let parentId = gChromeWin.BrowserApp.selectedTab.id;
gChromeWin.BrowserApp.addTab(message.url, { parentId: parentId });
},
ondismiss: function() {
// Remove this snippet from the banner, and store its id so we'll never show it again.
Home.banner.remove(id);
removeSnippet(message.id);
},
onshown: function() {
// 10% of the time, record the snippet id and a timestamp
if (Math.random() < .1) {
@ -193,6 +212,23 @@ function updateBanner(response) {
});
}
/**
* Appends snippet id to the end of `snippets-removed.txt`
*
* @param snippetId unique id for snippet, sent from snippets server
*/
function removeSnippet(snippetId) {
let removedSnippetIds;
try {
removedSnippetIds = JSON.parse(Services.prefs.getCharPref(SNIPPETS_REMOVED_IDS_PREF));
} catch (e) {
removedSnippetIds = [];
}
removedSnippetIds.push(snippetId);
Services.prefs.setCharPref(SNIPPETS_REMOVED_IDS_PREF, JSON.stringify(removedSnippetIds));
}
/**
* Appends snippet id and timestamp to the end of `snippets-stats.txt`.
*