diff --git a/accessible/atk/DocAccessibleWrap.cpp b/accessible/atk/DocAccessibleWrap.cpp index 0d05332bfde..d78d724b430 100644 --- a/accessible/atk/DocAccessibleWrap.cpp +++ b/accessible/atk/DocAccessibleWrap.cpp @@ -14,9 +14,8 @@ using namespace mozilla::a11y; //////////////////////////////////////////////////////////////////////////////// DocAccessibleWrap:: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - DocAccessible(aDocument, aRootContent, aPresShell), mActivated(false) + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell) : + DocAccessible(aDocument, aPresShell), mActivated(false) { } diff --git a/accessible/atk/DocAccessibleWrap.h b/accessible/atk/DocAccessibleWrap.h index 5eb4a5ed447..e5fc8e5e47b 100644 --- a/accessible/atk/DocAccessibleWrap.h +++ b/accessible/atk/DocAccessibleWrap.h @@ -19,8 +19,7 @@ namespace a11y { class DocAccessibleWrap : public DocAccessible { public: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell); virtual ~DocAccessibleWrap(); bool mActivated; diff --git a/accessible/base/DocManager.cpp b/accessible/base/DocManager.cpp index c82f2f01b7c..08bb581b092 100644 --- a/accessible/base/DocManager.cpp +++ b/accessible/base/DocManager.cpp @@ -470,17 +470,15 @@ DocManager::CreateDocOrRootAccessible(nsIDocument* aDocument) // We only create root accessibles for the true root, otherwise create a // doc accessible. - nsIContent *rootElm = nsCoreUtils::GetRoleContent(aDocument); RefPtr docAcc = isRootDoc ? - new RootAccessibleWrap(aDocument, rootElm, presShell) : - new DocAccessibleWrap(aDocument, rootElm, presShell); + new RootAccessibleWrap(aDocument, presShell) : + new DocAccessibleWrap(aDocument, presShell); // Cache the document accessible into document cache. mDocAccessibleCache.Put(aDocument, docAcc); // Initialize the document accessible. docAcc->Init(); - docAcc->SetRoleMapEntry(aria::GetRoleMap(aDocument)); // Bind the document to the tree. if (isRootDoc) { diff --git a/accessible/generic/DocAccessible.cpp b/accessible/generic/DocAccessible.cpp index 269bef5ea9f..67609e280c3 100644 --- a/accessible/generic/DocAccessible.cpp +++ b/accessible/generic/DocAccessible.cpp @@ -76,9 +76,8 @@ static const uint32_t kRelationAttrsLen = ArrayLength(kRelationAttrs); // Constructor/desctructor DocAccessible:: - DocAccessible(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - HyperTextAccessibleWrap(aRootContent, this), + DocAccessible(nsIDocument* aDocument, nsIPresShell* aPresShell) : + HyperTextAccessibleWrap(nullptr, this), // XXX aaronl should we use an algorithm for the initial cache size? mAccessibleCache(kDefaultCacheLength), mNodeToAccessibleMap(kDefaultCacheLength), @@ -1465,7 +1464,7 @@ DocAccessible::DoInitialUpdate() // miss the notification (since content tree change notifications are ignored // prior to initial update). Make sure the content element is valid. nsIContent* contentElm = nsCoreUtils::GetRoleContent(mDocumentNode); - if (mContent != contentElm) { + if (contentElm) { mContent = contentElm; SetRoleMapEntry(aria::GetRoleMap(mContent)); } diff --git a/accessible/generic/DocAccessible.h b/accessible/generic/DocAccessible.h index d889572c631..7e68110687d 100644 --- a/accessible/generic/DocAccessible.h +++ b/accessible/generic/DocAccessible.h @@ -50,8 +50,7 @@ class DocAccessible : public HyperTextAccessibleWrap, public: - DocAccessible(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + DocAccessible(nsIDocument* aDocument, nsIPresShell* aPresShell); // nsIScrollPositionListener virtual void ScrollPositionWillChange(nscoord aX, nscoord aY) override {} diff --git a/accessible/generic/RootAccessible.cpp b/accessible/generic/RootAccessible.cpp index e1acc4b5a8e..1f8b6c70635 100644 --- a/accessible/generic/RootAccessible.cpp +++ b/accessible/generic/RootAccessible.cpp @@ -59,9 +59,8 @@ NS_IMPL_ISUPPORTS_INHERITED0(RootAccessible, DocAccessible) // Constructor/destructor RootAccessible:: - RootAccessible(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - DocAccessibleWrap(aDocument, aRootContent, aPresShell) + RootAccessible(nsIDocument* aDocument, nsIPresShell* aPresShell) : + DocAccessibleWrap(aDocument, aPresShell) { mType = eRootType; } diff --git a/accessible/generic/RootAccessible.h b/accessible/generic/RootAccessible.h index 8e015d51669..beb74cf4b60 100644 --- a/accessible/generic/RootAccessible.h +++ b/accessible/generic/RootAccessible.h @@ -22,8 +22,7 @@ class RootAccessible : public DocAccessibleWrap, NS_DECL_ISUPPORTS_INHERITED public: - RootAccessible(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + RootAccessible(nsIDocument* aDocument, nsIPresShell* aPresShell); // nsIDOMEventListener NS_IMETHOD HandleEvent(nsIDOMEvent* aEvent) override; diff --git a/accessible/mac/DocAccessibleWrap.h b/accessible/mac/DocAccessibleWrap.h index 0d9c2cc9edc..3e80a0d33c0 100644 --- a/accessible/mac/DocAccessibleWrap.h +++ b/accessible/mac/DocAccessibleWrap.h @@ -14,8 +14,7 @@ namespace a11y { class DocAccessibleWrap : public DocAccessible { public: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell); virtual ~DocAccessibleWrap(); }; diff --git a/accessible/mac/DocAccessibleWrap.mm b/accessible/mac/DocAccessibleWrap.mm index 54eadf09234..8a513f485a2 100644 --- a/accessible/mac/DocAccessibleWrap.mm +++ b/accessible/mac/DocAccessibleWrap.mm @@ -10,9 +10,8 @@ using namespace mozilla::a11y; DocAccessibleWrap:: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - DocAccessible(aDocument, aRootContent, aPresShell) + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell) : + DocAccessible(aDocument, aPresShell) { } diff --git a/accessible/mac/RootAccessibleWrap.h b/accessible/mac/RootAccessibleWrap.h index 9415bed81d5..aa53e06ac0e 100644 --- a/accessible/mac/RootAccessibleWrap.h +++ b/accessible/mac/RootAccessibleWrap.h @@ -18,8 +18,7 @@ namespace a11y { class RootAccessibleWrap : public RootAccessible { public: - RootAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + RootAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell); virtual ~RootAccessibleWrap(); Class GetNativeType (); diff --git a/accessible/mac/RootAccessibleWrap.mm b/accessible/mac/RootAccessibleWrap.mm index ea6e1c7ffa9..60674c99c20 100644 --- a/accessible/mac/RootAccessibleWrap.mm +++ b/accessible/mac/RootAccessibleWrap.mm @@ -16,9 +16,8 @@ using namespace mozilla::a11y; RootAccessibleWrap:: - RootAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - RootAccessible(aDocument, aRootContent, aPresShell) + RootAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell) : + RootAccessible(aDocument, aPresShell) { } diff --git a/accessible/windows/msaa/DocAccessibleWrap.cpp b/accessible/windows/msaa/DocAccessibleWrap.cpp index 16c0b2dfe8c..d2215a99695 100644 --- a/accessible/windows/msaa/DocAccessibleWrap.cpp +++ b/accessible/windows/msaa/DocAccessibleWrap.cpp @@ -25,9 +25,8 @@ using namespace mozilla::a11y; //////////////////////////////////////////////////////////////////////////////// DocAccessibleWrap:: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - DocAccessible(aDocument, aRootContent, aPresShell), mHWND(nullptr) + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell) : + DocAccessible(aDocument, aPresShell), mHWND(nullptr) { } diff --git a/accessible/windows/msaa/DocAccessibleWrap.h b/accessible/windows/msaa/DocAccessibleWrap.h index 18e58b0ab3a..8350782d7a0 100644 --- a/accessible/windows/msaa/DocAccessibleWrap.h +++ b/accessible/windows/msaa/DocAccessibleWrap.h @@ -15,8 +15,7 @@ namespace a11y { class DocAccessibleWrap : public DocAccessible { public: - DocAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + DocAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell); virtual ~DocAccessibleWrap(); DECL_IUNKNOWN_INHERITED diff --git a/accessible/windows/msaa/RootAccessibleWrap.cpp b/accessible/windows/msaa/RootAccessibleWrap.cpp index 0c232dd472a..3d0592f1ded 100644 --- a/accessible/windows/msaa/RootAccessibleWrap.cpp +++ b/accessible/windows/msaa/RootAccessibleWrap.cpp @@ -15,9 +15,8 @@ using namespace mozilla::a11y; // Constructor/desctructor RootAccessibleWrap:: - RootAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell) : - RootAccessible(aDocument, aRootContent, aPresShell) + RootAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell) : + RootAccessible(aDocument, aPresShell) { } diff --git a/accessible/windows/msaa/RootAccessibleWrap.h b/accessible/windows/msaa/RootAccessibleWrap.h index c616c26ca48..6aa6fefe38f 100644 --- a/accessible/windows/msaa/RootAccessibleWrap.h +++ b/accessible/windows/msaa/RootAccessibleWrap.h @@ -14,8 +14,7 @@ namespace a11y { class RootAccessibleWrap : public RootAccessible { public: - RootAccessibleWrap(nsIDocument* aDocument, nsIContent* aRootContent, - nsIPresShell* aPresShell); + RootAccessibleWrap(nsIDocument* aDocument, nsIPresShell* aPresShell); virtual ~RootAccessibleWrap(); // RootAccessible