wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 949174/964375/952311 - Encapsulate PanelInfo data behind getters (r=margaret)

Browse Source
This commit is contained in:
Lucas Rocha 2014-02-05 14:14:51 +00:00
parent ae65ae45e3
commit afc389a3d0
1 changed files with 26 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
mobile/android/base/home/PanelManager.java
View File

@ -7,6 +7,7 @@ package org.mozilla.gecko.home;
import org.mozilla.gecko.GeckoAppShell;
import org.mozilla.gecko.GeckoEvent;
import org.mozilla.gecko.home.HomeConfig.PanelConfig;
import org.mozilla.gecko.util.GeckoEventListener;
import org.mozilla.gecko.util.ThreadUtils;
@ -29,16 +30,31 @@ public class PanelManager implements GeckoEventListener {
private static final String LOGTAG = "GeckoPanelManager";
public class PanelInfo {
public final String id;
public final String title;
public final String layout;
public final JSONArray views;
private final String mId;
private final String mTitle;
private final JSONObject mJSONData;
public PanelInfo(String id, String title, String layout, JSONArray views) {
this.id = id;
this.title = title;
this.layout = layout;
this.views = views;
public PanelInfo(String id, String title, JSONObject jsonData) {
mId = id;
mTitle = title;
mJSONData = jsonData;
}
public String getId() {
return mId;
}
public String getTitle() {
return mTitle;
}
public PanelConfig toPanelConfig() {
try {
return new PanelConfig(mJSONData);
} catch (Exception e) {
Log.e(LOGTAG, "Failed to convert PanelInfo to PanelConfig", e);
return null;
}
}
}
@ -112,9 +128,7 @@ public class PanelManager implements GeckoEventListener {
private PanelInfo getPanelInfoFromJSON(JSONObject jsonPanelInfo) throws JSONException {
final String id = jsonPanelInfo.getString("id");
final String title = jsonPanelInfo.getString("title");
final String layout = jsonPanelInfo.getString("layout");
final JSONArray views = jsonPanelInfo.getJSONArray("views");
return new PanelInfo(id, title, layout, views);
return new PanelInfo(id, title, jsonPanelInfo);
}
}