Bug 1141607. Fix the initial value of outline-color to actually be correct. r=dbaron

This commit is contained in:
Boris Zbarsky 2015-04-28 14:48:39 -04:00
parent b18a5af885
commit aabf3a0648
6 changed files with 26 additions and 0 deletions

View File

@ -0,0 +1,5 @@
<!DOCTYPE html>
<span style="outline-width: 2px; outline-style: solid; color: green;
outline-color: green">
This should have a green outline.
</span>

View File

@ -0,0 +1,4 @@
<!DOCTYPE html>
<span style="outline-width: 2px; outline-style: solid; color: green">
This should have a green outline.
</span>

View File

@ -0,0 +1,5 @@
<!DOCTYPE html>
<span style="outline-width: 2px; outline-style: solid; color: green;
outline-color: initial">
This should have a green outline.
</span>

View File

@ -7,3 +7,5 @@ fuzzy-if(d2d,16,96) == outline-and-3d-transform-2.html outline-and-3d-transform-
== outline-overflow-inlineblock-abspos.html outline-overflow-inlineblock-ref.html
== outline-overflow-inlineblock-float.html outline-overflow-inlineblock-ref.html
pref(layout.css.outline-style-auto.enabled,true) skip-if((!gtk2Widget&&!winWidget&&!cocoaWidget)||Mulet) == outline-auto-001.html outline-auto-001-ref.html # only works on platforms that supports NS_THEME_FOCUS_OUTLINE # bug 1141511: Disable some gtk2Widget-dependant reftests on Mulet
== outline-initial-1a.html outline-initial-1-ref.html
== outline-initial-1b.html outline-initial-1-ref.html

View File

@ -608,6 +608,8 @@ nsStyleOutline::nsStyleOutline(nsPresContext* aPresContext)
mHasCachedOutline = false;
mTwipsPerPixel = aPresContext->DevPixelsToAppUnits(1);
SetOutlineInitialColor();
}
nsStyleOutline::nsStyleOutline(const nsStyleOutline& aSrc)

View File

@ -21,6 +21,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=531585
border-color: black; /* don't derive from color */
-moz-column-rule-color: black; /* don't derive from color */
text-decoration-color: black; /* don't derive from color */
outline-color: black; /* don't derive from color */
}
#four {
@ -72,6 +73,7 @@ var got_one_target_borderbottom = false;
var got_one_target_borderleft = false;
var got_one_target_columnrule = false;
var got_one_target_textdecorationcolor = false;
var got_one_target_outlinecolor = false;
var got_two_target = false;
var got_three_top = false;
var got_three_right = false;
@ -184,6 +186,12 @@ $("one").addEventListener("transitionend",
got_one_target_textdecorationcolor = true;
event.stopPropagation();
break;
case "outline-color":
ok(!got_one_target_outlinecolor,
"transitionend on one on target (outline-color)");
got_one_target_outlinecolor = true;
event.stopPropagation();
break;
default:
ok(false, "unexpected property name " + event.propertyName +
" for transitionend on one on target");