wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 602151 - Too many calls to OnValueChanged; r,a=bzbarsky

Browse Source
This commit is contained in:
Ehsan Akhgari 2010-10-06 16:31:09 -04:00
parent 8b577ba6df
commit a26e6baee2
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
content/html/content/src/nsTextEditorState.cpp
View File

@ -584,6 +584,8 @@ public:
*/
void SetFrame(nsTextControlFrame *aFrame){mFrame = aFrame;}
void SettingValue(PRBool aValue) { mSettingValue = aValue; }
NS_DECL_ISUPPORTS
NS_DECL_NSISELECTIONLISTENER
@ -620,6 +622,11 @@ protected:
* notification (when this state changes we update undo and redo menus)
*/
PRPackedBool mHadRedoItems;
/**
* Whether we're in the process of a SetValue call, and should therefore
* refrain from calling OnValueChanged.
*/
PRPackedBool mSettingValue;
};
@ -633,6 +640,7 @@ nsTextInputListener::nsTextInputListener(nsITextControlElement* aTxtCtrlElement)
, mSelectionWasCollapsed(PR_TRUE)
, mHadUndoItems(PR_FALSE)
, mHadRedoItems(PR_FALSE)
, mSettingValue(PR_FALSE)
{
}
@ -842,7 +850,9 @@ nsTextInputListener::EditAction()
// Fire input event
mFrame->FireOnInput();
mTxtCtrlElement->OnValueChanged(PR_TRUE);
if (!mSettingValue) {
mTxtCtrlElement->OnValueChanged(PR_TRUE);
}
return NS_OK;
}
@ -1715,6 +1725,8 @@ nsTextEditorState::SetValue(const nsAString& aValue, PRBool aUserInput)
flags |= nsIPlaintextEditor::eEditorDontEchoPassword;
mEditor->SetFlags(flags);
mTextListener->SettingValue(PR_TRUE);
// Also don't enforce max-length here
PRInt32 savedMaxLength;
plaintextEditor->GetMaxTextLength(&savedMaxLength);
@ -1725,6 +1737,9 @@ nsTextEditorState::SetValue(const nsAString& aValue, PRBool aUserInput)
} else {
plaintextEditor->InsertText(insertValue);
}
mTextListener->SettingValue(PR_FALSE);
if (!weakFrame.IsAlive()) {
// If the frame was destroyed because of a flush somewhere inside
// InsertText, mBoundFrame here will be false. But it's also possible