Bug 1167459 - Skip rendering function name nodes if there's no name available (e.g. for C++ pseudoframes), r=jsantell

This commit is contained in:
Victor Porof 2015-05-22 09:39:25 -04:00
parent 7c4d95ab24
commit 9fade2ebcf
2 changed files with 14 additions and 15 deletions

View File

@ -256,12 +256,16 @@ CallView.prototype = Heritage.extend(AbstractTreeItem.prototype, {
cell.setAttribute("type", "function");
cell.appendChild(arrowNode);
let nameNode = this.document.createElement("label");
nameNode.className = "plain call-tree-name";
nameNode.setAttribute("flex", "1");
nameNode.setAttribute("crop", "end");
nameNode.setAttribute("value", frameName);
cell.appendChild(nameNode);
// Don't render a name label node if there's no function name. A different
// location label node will be rendered instead.
if (frameName) {
let nameNode = this.document.createElement("label");
nameNode.className = "plain call-tree-name";
nameNode.setAttribute("flex", "1");
nameNode.setAttribute("crop", "end");
nameNode.setAttribute("value", frameName);
cell.appendChild(nameNode);
}
// Don't render detailed labels for meta category frames
if (!frameInfo.isMetaCategory) {

View File

@ -299,8 +299,11 @@
opacity: 0.6;
}
.call-tree-name {
-moz-margin-end: 4px !important;
}
.call-tree-url {
-moz-margin-start: 4px !important;
cursor: pointer;
}
@ -327,14 +330,6 @@
color: var(--theme-content-color2);
}
.call-tree-name[value=""],
.call-tree-url[value=""],
.call-tree-line[value=""],
.call-tree-column[value=""],
.call-tree-host[value=""] {
display: none;
}
.call-tree-zoom {
-moz-appearance: none;
background-color: transparent;