Bug 1108049 - Rename Loop panel iframe id to a more descriptive than just 'loop' (now 'loop-panel-iframe'). r=Standard8

This commit is contained in:
Vikram Jadhav 2015-01-14 20:15:38 +00:00
parent 2fa0d4f94a
commit 9e23f05420
3 changed files with 4 additions and 4 deletions

View File

@ -53,7 +53,7 @@ class Test1BrowserCall(MarionetteTestCase):
button.click()
# switch to the frame
frame = self.marionette.find_element(By.ID, "loop")
frame = self.marionette.find_element(By.ID, "loop-panel-iframe")
self.marionette.switch_to_frame(frame)
def load_and_verify_standalone_ui(self, url):

View File

@ -24,7 +24,7 @@ function* checkFxA401() {
let loopPanel = document.getElementById("loop-notification-panel");
yield loadLoopPanel();
let loopDoc = document.getElementById("loop").contentDocument;
let loopDoc = document.getElementById("loop-panel-iframe").contentDocument;
is(loopDoc.querySelector(".alert-error .message").textContent,
getLoopString("could_not_authenticate"),
"Check error bar message");
@ -293,7 +293,7 @@ add_task(function* basicAuthorizationAndRegistration() {
let statusChangedPromise = promiseObserverNotified("loop-status-changed");
yield loadLoopPanel({stayOnline: true});
yield statusChangedPromise;
let loopDoc = document.getElementById("loop").contentDocument;
let loopDoc = document.getElementById("loop-panel-iframe").contentDocument;
let visibleEmail = loopDoc.getElementsByClassName("user-identity")[0];
is(visibleEmail.textContent, "Guest", "Guest should be displayed on the panel when not logged in");
is(MozLoopService.userProfile, null, "profile should be null before log-in");

View File

@ -45,7 +45,7 @@ let PanelFrameInternal = {
*/
_attachNotificatonPanel: function(aWindow, aParent, aButton, aType, aOrigin, aSrc, aSize) {
aParent.hidden = false;
let notificationFrameId = aOrigin ? aType + "-status-" + aOrigin : aType;
let notificationFrameId = aOrigin ? aType + "-status-" + aOrigin : aType + "-panel-iframe";
let doc = aWindow.document;
let frame = doc.getElementById(notificationFrameId);