From 9d312cc7bf27fe4b0ee69880d610a5fbe96f8df2 Mon Sep 17 00:00:00 2001 From: Trevor Saunders Date: Wed, 25 May 2011 07:52:01 -0700 Subject: [PATCH] bug 659620 - Hang when trying to edit a page on WikiMo with NVDA running r=surkov From e0a6515b9f894ab39bcd6db51d43e24a677667b3 Mon Sep 17 00:00:00 2001 --- accessible/src/base/nsBaseWidgetAccessible.cpp | 3 +- .../tests/mochitest/actions/test_general.html | 21 ++++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) --- .../src/base/nsBaseWidgetAccessible.cpp | 3 +-- .../tests/mochitest/actions/test_general.html | 21 +++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/accessible/src/base/nsBaseWidgetAccessible.cpp b/accessible/src/base/nsBaseWidgetAccessible.cpp index b4b9ba8867d..49cea016674 100644 --- a/accessible/src/base/nsBaseWidgetAccessible.cpp +++ b/accessible/src/base/nsBaseWidgetAccessible.cpp @@ -141,7 +141,7 @@ nsLinkableAccessible::GetNumActions(PRUint8 *aNumActions) { NS_ENSURE_ARG_POINTER(aNumActions); - *aNumActions = mActionAcc ? 1 : 0; + *aNumActions = (mIsOnclick || mIsLink) ? 1 : 0; return NS_OK; } @@ -228,7 +228,6 @@ nsLinkableAccessible::BindToParent(nsAccessible* aParent, mIsOnclick = PR_FALSE; if (nsCoreUtils::HasClickListener(mContent)) { - mActionAcc = this; mIsOnclick = PR_TRUE; return; } diff --git a/accessible/tests/mochitest/actions/test_general.html b/accessible/tests/mochitest/actions/test_general.html index a51118d648b..0133c9c607c 100644 --- a/accessible/tests/mochitest/actions/test_general.html +++ b/accessible/tests/mochitest/actions/test_general.html @@ -36,9 +36,19 @@ ID: "li_clickable3", actionName: "click", events: CLICK_EVENTS + }, + { + ID: "onclick_img", + actionName: "click", + events: CLICK_EVENTS } ]; + testActions(actionsArray); + + getAccessible("onclick_img").takeFocus(); +is(getAccessible("link1").numActions, 1, "links should have one action"); +is(getAccessible("link2").numActions, 1, "link with onclick handler should have 1 action"); } SimpleTest.waitForExplicitFinish(); @@ -58,6 +68,11 @@ title="Expose click action if mouseup and mousedown are registered"> Mozilla Bug 423409 + + Mozilla Bug 659620 +

@@ -68,5 +83,11 @@
     
  • Clickable list item
  • Clickable list item
  • + + + + + linkable textleaf accessible +
    linkable textleaf accessible