wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 984015 - GUIDHelper.getItemId should deliver itself as |this| to its internal executeAsync callback. r=?

Browse Source 
This patch includes:

 * GUIDHelper.getItemGUID() must return a GUID.
 * GUIDHelper should resolve promises after other operations are finished.
 * GUIDHelper.getItemId should deliver itself as |this| to its internal executeAsync callback.
This commit is contained in:
Tetsuharu OHZEKI 2014-04-05 00:52:53 +09:00
parent 6a7faff5d3
commit 98e283add9
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
toolkit/components/places/PlacesUtils.jsm
View File

@ -1698,12 +1698,12 @@ let GUIDHelper = {
if (row)
itemId = row.getResultByIndex(0);
},
handleCompletion: function (aReason) {
handleCompletion: aReason => {
if (aReason == REASON_FINISHED && itemId != -1) {
deferred.resolve(itemId);
this.ensureObservingRemovedItems();
this.idsForGUIDs.set(aGUID, itemId);
deferred.resolve(itemId);
}
else if (itemId != -1) {
deferred.reject("no item found for the given guid");
@ -1719,7 +1719,7 @@ let GUIDHelper = {
getItemGUID: function (aItemId) {
if (this.GUIDsForIds.has(aItemId))
return Promise.resolve(this.GUIDsForIds.has(aItemId));
return Promise.resolve(this.GUIDsForIds.get(aItemId));
let deferred = Promise.defer();
let guid = "";
@ -1732,12 +1732,12 @@ let GUIDHelper = {
guid = row.getResultByIndex(1);
}
},
handleCompletion: function (aReason) {
handleCompletion: aReason => {
if (aReason == REASON_FINISHED && guid) {
deferred.resolve(guid);
this.ensureObservingRemovedItems();
this.GUIDsForIds.set(aItemId, guid);
deferred.resolve(guid);
}
else if (!guid) {
deferred.reject("no item found for the given itemId");