Bug 1135635 - Position sidebar allTabs menu absolutely to avoid oveflow jittering; r=bgrins

This commit is contained in:
Patrick Brosset 2015-04-23 10:34:01 +02:00
parent 3a1aca3407
commit 989b8eaec8
3 changed files with 11 additions and 11 deletions

View File

@ -120,7 +120,7 @@ ToolSidebar.prototype = {
let tabs = this._tabbox.tabs;
// Create a container and insert it first in the tabbox
let allTabsContainer = this._panelDoc.createElementNS(XULNS, "box");
let allTabsContainer = this._panelDoc.createElementNS(XULNS, "stack");
this._tabbox.insertBefore(allTabsContainer, tabs);
// Move the tabs inside and make them flex
@ -130,8 +130,10 @@ ToolSidebar.prototype = {
// Create the dropdown menu next to the tabs
this._allTabsBtn = this._panelDoc.createElementNS(XULNS, "toolbarbutton");
this._allTabsBtn.setAttribute("class", "devtools-sidebar-alltabs");
this._allTabsBtn.setAttribute("right", "0");
this._allTabsBtn.setAttribute("top", "0");
this._allTabsBtn.setAttribute("width", "15");
this._allTabsBtn.setAttribute("type", "menu");
this._allTabsBtn.setAttribute("label", l10n("sidebar.showAllTabs.label"));
this._allTabsBtn.setAttribute("tooltiptext", l10n("sidebar.showAllTabs.tooltip"));
this._allTabsBtn.setAttribute("hidden", "true");
allTabsContainer.appendChild(this._allTabsBtn);
@ -162,7 +164,7 @@ ToolSidebar.prototype = {
// Moving back the tabs as a first child of the tabbox
this._tabbox.insertBefore(tabs, this._tabbox.tabpanels);
this._tabbox.querySelector("box").remove();
this._tabbox.querySelector("stack").remove();
this._allTabsBtn = null;
},

View File

@ -71,11 +71,6 @@ browserConsoleCmd.commandkey=j
# This is the tooltip of the pick button in the toolbox toolbar
pickButton.tooltip=Pick an element from the page
# LOCALIZATION NOTE (sidebar.showAllTabs.label)
# This is the label shown in the show all tabs button in the tabbed side
# bar, when there's no enough space to show all tabs at once
sidebar.showAllTabs.label=
# LOCALIZATION NOTE (sidebar.showAllTabs.tooltip)
# This is the tooltip shown when hover over the '…' button in the tabbed side
# bar, when there's no enough space to show all tabs at once

View File

@ -26,8 +26,7 @@
/* Toolbars */
.devtools-toolbar,
.devtools-sidebar-tabs tabs,
.devtools-sidebar-alltabs {
.devtools-sidebar-tabs tabs {
-moz-appearance: none;
padding: 0;
border-width: 0;
@ -509,13 +508,17 @@
}
.devtools-sidebar-alltabs {
-moz-appearance: none;
height: 24px;
line-height: 24px;
padding: 0 4px;
margin: 0;
border-width: 0 0 1px 0;
-moz-border-start-width: 1px;
border-style: solid;
}
.devtools-sidebar-alltabs dropmarker {
.devtools-sidebar-alltabs .toolbarbutton-icon {
display: none;
}