Fix all clang warnings introduced by the Ionmonkey landing (and one or two predating it). No bug, r=dvander over IRC

--HG--
extra : rebase_source : 60d83d511c3e1cb7c1673f5c5e7800996716fcc1
This commit is contained in:
Jeff Walden 2012-09-17 18:02:29 -07:00
parent f62d70fbb8
commit 9199ae6951
6 changed files with 16 additions and 14 deletions

View File

@ -4641,7 +4641,6 @@ class MDeleteProperty
public BoxInputsPolicy
{
CompilerRootPropertyName name_;
bool needsBarrier_;
protected:
MDeleteProperty(MDefinition *val, HandlePropertyName name)
@ -5434,12 +5433,9 @@ class FlattenedMResumePointIter
MResumePoint *newest;
size_t numOperands_;
size_t resumePointIndex;
size_t operand;
public:
explicit FlattenedMResumePointIter(MResumePoint *newest)
: newest(newest), numOperands_(0), resumePointIndex(0), operand(0)
: newest(newest), numOperands_(0)
{}
bool init() {

View File

@ -185,7 +185,7 @@ MBasicBlock::inherit(MBasicBlock *pred)
for (size_t i = 0; i < stackDepth(); i++) {
MPhi *phi = MPhi::New(i);
if (!phi->addInput(pred->getSlot(i)))
return NULL;
return false;
addPhi(phi);
setSlot(i, phi);
entryResumePoint()->initOperand(i, phi);

View File

@ -197,6 +197,7 @@ class IonExitFrameLayout : public IonCommonFrameLayout
class IonNativeExitFrameLayout
{
protected: // only to silence a clang warning about unused private fields
IonExitFooterFrame footer_;
IonExitFrameLayout exit_;
uintptr_t argc_;
@ -224,6 +225,7 @@ class IonNativeExitFrameLayout
class IonDOMExitFrameLayout
{
protected: // only to silence a clang warning about unused private fields
IonExitFooterFrame footer_;
IonExitFrameLayout exit_;
JSObject *thisObj;
@ -257,6 +259,7 @@ class IonDOMExitFrameLayout
class IonDOMMethodExitFrameLayout
{
protected: // only to silence a clang warning about unused private fields
IonExitFooterFrame footer_;
IonExitFrameLayout exit_;
// This must be the last thing pushed, so as to stay common with

View File

@ -21,8 +21,6 @@
namespace js {
namespace ion {
static Register CallReg = ReturnReg;
class MacroAssemblerX86Shared : public Assembler
{
protected:

View File

@ -454,10 +454,11 @@ typedef size_t jsbitmap;
#if defined(__clang__)
# define JS_SILENCE_UNUSED_VALUE_IN_EXPR(expr) \
JS_BEGIN_MACRO \
_Pragma("(clang diagnostic push)") \
_Pragma("(clang diagnostic ignored \"-Wunused-value\")") \
{expr;} \
_Pragma("(clang diagnostic pop)") \
_Pragma("clang diagnostic push") \
/* If these _Pragmas cause warnings for you, try disabling ccache. */ \
_Pragma("clang diagnostic ignored \"-Wunused-value\"") \
{ expr; } \
_Pragma("clang diagnostic pop") \
JS_END_MACRO
#elif (__GNUC__ >= 5) || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)
# define JS_SILENCE_UNUSED_VALUE_IN_EXPR(expr) \

View File

@ -121,10 +121,12 @@ class AutoLockWorkerThreadState
AutoLockWorkerThreadState(JSRuntime *rt JS_GUARD_OBJECT_NOTIFIER_PARAM)
: rt(rt)
{
JS_GUARD_OBJECT_NOTIFIER_INIT;
#ifdef JS_PARALLEL_COMPILATION
rt->workerThreadState->lock();
#else
(void)this->rt;
#endif
JS_GUARD_OBJECT_NOTIFIER_INIT;
}
~AutoLockWorkerThreadState()
@ -145,10 +147,12 @@ class AutoUnlockWorkerThreadState
AutoUnlockWorkerThreadState(JSRuntime *rt JS_GUARD_OBJECT_NOTIFIER_PARAM)
: rt(rt)
{
JS_GUARD_OBJECT_NOTIFIER_INIT;
#ifdef JS_PARALLEL_COMPILATION
rt->workerThreadState->unlock();
#else
(void)this->rt;
#endif
JS_GUARD_OBJECT_NOTIFIER_INIT;
}
~AutoUnlockWorkerThreadState()