wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1249542 - Remove the prefs for History API push/pop/replaceState; r=bzbarsky

Browse Source 
These prefs don't even work properly, and they can break Web content in
pretty bad ways for the users who have them set.
This commit is contained in:
Ehsan Akhgari 2016-02-27 14:45:12 -05:00
parent b2953f8fc6
commit 90da955373
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dom/base/nsGlobalWindow.cpp
View File

@ -457,8 +457,6 @@ nsGlobalWindow::DOMMinTimeoutValue() const {
// CIDs // CIDs
static NS_DEFINE_CID(kXULControllersCID, NS_XULCONTROLLERS_CID); static NS_DEFINE_CID(kXULControllersCID, NS_XULCONTROLLERS_CID);
static const char sPopStatePrefStr[] = "browser.history.allowPopState";
#define NETWORK_UPLOAD_EVENT_NAME NS_LITERAL_STRING("moznetworkupload") #define NETWORK_UPLOAD_EVENT_NAME NS_LITERAL_STRING("moznetworkupload")
#define NETWORK_DOWNLOAD_EVENT_NAME NS_LITERAL_STRING("moznetworkdownload") #define NETWORK_DOWNLOAD_EVENT_NAME NS_LITERAL_STRING("moznetworkdownload")
@ -9917,11 +9915,6 @@ nsGlobalWindow::DispatchSyncPopState()
NS_ASSERTION(nsContentUtils::IsSafeToRunScript(), NS_ASSERTION(nsContentUtils::IsSafeToRunScript(),
"Must be safe to run script here."); "Must be safe to run script here.");
// Check that PopState hasn't been pref'ed off.
if (!Preferences::GetBool(sPopStatePrefStr, false)) {
return NS_OK;
}
nsresult rv = NS_OK; nsresult rv = NS_OK;
// Bail if the window is frozen. // Bail if the window is frozen.

11
dom/base/nsHistory.cpp
View File

@ -25,11 +25,6 @@
using namespace mozilla; using namespace mozilla;
using namespace mozilla::dom; using namespace mozilla::dom;
static const char* sAllowPushStatePrefStr =
"browser.history.allowPushState";
static const char* sAllowReplaceStatePrefStr =
"browser.history.allowReplaceState";
// //
// History class implementation // History class implementation
// //
@ -304,12 +299,6 @@ nsHistory::PushOrReplaceState(JSContext* aCx, JS::Handle<JS::Value> aData,
return; return;
} }
// Check that PushState hasn't been pref'ed off.
if (!Preferences::GetBool(aReplace ? sAllowReplaceStatePrefStr :
sAllowPushStatePrefStr, false)) {
return;
}
// AddState might run scripts, so we need to hold a strong reference to the // AddState might run scripts, so we need to hold a strong reference to the
// docShell here to keep it from going away. // docShell here to keep it from going away.
nsCOMPtr<nsIDocShell> docShell = win->GetDocShell(); nsCOMPtr<nsIDocShell> docShell = win->GetDocShell();

3
modules/libpref/init/all.js
View File

@ -4486,9 +4486,6 @@ pref("html5.flushtimer.initialdelay", 120);
pref("html5.flushtimer.subsequentdelay", 120); pref("html5.flushtimer.subsequentdelay", 120);
// Push/Pop/Replace State prefs // Push/Pop/Replace State prefs
pref("browser.history.allowPushState", true);
pref("browser.history.allowReplaceState", true);
pref("browser.history.allowPopState", true);
pref("browser.history.maxStateObjectSize", 655360); pref("browser.history.maxStateObjectSize", 655360);
pref("browser.meta_refresh_when_inactive.disabled", false); pref("browser.meta_refresh_when_inactive.disabled", false);