wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1255745 - Make Experiments AsyncShutdown state data more useful. r=dexter, a=lizzard

Browse Source 
* Make Experiments AsyncShutdown state add the time to the log entries.
* Fix other AsyncShutdown state issues.
* We were not adding forensic log entries of ExperimentEntry before, added that to be able to narrow this down more.
* This also increases the forensic log a bit to account for the additional entries and removes some unneeded big data addition to the logging.
This commit is contained in:
Georg Fritzsche 2016-03-17 14:03:49 +01:00
parent 6d29bc2559
commit 8e8fa6e41b
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
browser/experiments/Experiments.jsm
View File

@ -323,11 +323,10 @@ Experiments.Experiments = function (policy=new Experiments.Policy()) {
// crashes. For forensics purposes, keep the last few log
// messages in memory and upload them in case of crash.
this._forensicsLogs = [];
this._forensicsLogs.length = 20;
this._forensicsLogs.length = 30;
this._log = Object.create(log);
this._log.log = (level, string, params) => {
this._forensicsLogs.shift();
this._forensicsLogs.push(level + ": " + string);
this._addToForensicsLog("Experiments", string);
log.log(level, string, params);
};
@ -464,6 +463,7 @@ Experiments.Experiments.prototype = {
yield this._mainTask;
} catch (e) {
// We error out of tasks after shutdown via this exception.
this._log.trace(`uninit: caught error - ${e}`);
if (!(e instanceof AlreadyShutdownError)) {
this._latestError = e;
throw e;
@ -476,6 +476,7 @@ Experiments.Experiments.prototype = {
// Return state information, for debugging purposes.
_getState: function() {
let activeExperiment = this._getActiveExperiment();
let state = {
isShutdown: this._shutdown,
isEnabled: gExperimentsEnabled,
@ -487,8 +488,9 @@ Experiments.Experiments.prototype = {
hasTimer: !!this._hasTimer,
hasAddonProvider: !!gAddonProvider,
latestLogs: this._forensicsLogs,
experiments: this._experiments ? this._experiments.keys() : null,
experiments: this._experiments ? [...this._experiments.keys()] : null,
terminateReason: this._terminateReason,
activeExperiment: !!activeExperiment ? activeExperiment.id : null,
};
if (this._latestError) {
if (typeof this._latestError == "object") {
@ -503,6 +505,12 @@ Experiments.Experiments.prototype = {
return state;
},
_addToForensicsLog: function (what, string) {
this._forensicsLogs.shift();
let timeInSec = Math.floor(Services.telemetry.msSinceProcessStart() / 1000);
this._forensicsLogs.push(`${timeInSec}: ${what} - ${string}`);
},
_registerWithAddonManager: function (previousExperimentsProvider) {
this._log.trace("Registering instance with Addon Manager.");
@ -1356,9 +1364,16 @@ Experiments.Experiments.prototype = {
Experiments.ExperimentEntry = function (policy) {
this._policy = policy || new Experiments.Policy();
this._log = Log.repository.getLoggerWithMessagePrefix(
let log = Log.repository.getLoggerWithMessagePrefix(
"Browser.Experiments.Experiments",
"ExperimentEntry #" + gExperimentEntryCounter++ + "::");
this._log = Object.create(log);
this._log.log = (level, string, params) => {
if (gExperiments) {
gExperiments._addToForensicsLog("ExperimentEntry", string);
}
log.log(level, string, params);
};
// Is the experiment supposed to be running.
this._enabled = false;
@ -1625,8 +1640,7 @@ Experiments.ExperimentEntry.prototype = {
let startSec = (this.startDate || 0) / 1000;
this._log.trace("isApplicable() - now=" + now
+ ", randomValue=" + this._randomValue
+ ", data=" + JSON.stringify(this._manifestData));
+ ", randomValue=" + this._randomValue);
// Not applicable if it already ran.