Bug 906412 - Cleanup some random parts of the build system; r=mshal

Makefile.in

@@ -33,7 +33,7 @@ include $(topsrcdir)/config/config.mk
 GARBAGE_DIRS += dist _javagen _profile _tests staticlib
 DIST_GARBAGE = config.cache config.log config.status* config-defs.h \
    config/autoconf.mk \
-   unallmakefiles mozilla-config.h \
+   mozilla-config.h \
    netwerk/necko-config.h xpcom/xpcom-config.h xpcom/xpcom-private.h \
    $(topsrcdir)/.mozconfig.mk $(topsrcdir)/.mozconfig.out
 
@@ -107,8 +107,7 @@ include $(topsrcdir)/config/makefiles/tiers.mk
 $(foreach tier,$(TIERS),$(eval $(call CREATE_TIER_RULE,$(tier))))
 
 distclean::
-	cat unallmakefiles | $(XARGS) rm -f
+	$(RM) $(DIST_GARBAGE)
-	$(RM) unallmakefiles $(DIST_GARBAGE)
 
 ifeq ($(OS_ARCH),WINNT)
 # we want to copy PDB files on Windows

b2g/installer/Makefile.in

@@ -17,14 +17,6 @@ MOZ_PKG_REMOVALS = $(srcdir)/removed-files.in
 
 MOZ_PKG_MANIFEST_P = $(srcdir)/package-manifest.in
 
-MOZ_NONLOCALIZED_PKG_LIST = \
-	xpcom \
-	browser \
-	b2g \
-	$(NULL)
-
-MOZ_LOCALIZED_PKG_LIST = $(AB_CD) multilocale
-
 DEFINES += \
 	-DAB_CD=$(AB_CD) \
 	-DMOZ_APP_NAME=$(MOZ_APP_NAME) \

browser/extensions/Makefile.in

@@ -7,8 +7,6 @@ topsrcdir  = @top_srcdir@
 srcdir     = @srcdir@
 VPATH      = @srcdir@
 
-CHROMEDIR = $(call core_abspath,$(FINAL_TARGET))/chrome
-
 include $(DEPTH)/config/autoconf.mk
 
 ifdef MOZ_METRO

browser/installer/Makefile.in

@@ -21,13 +21,6 @@ ifndef SYSTEM_LIBXUL
 MOZ_PKG_FATAL_WARNINGS = 1
 endif
 
-MOZ_NONLOCALIZED_PKG_LIST = \
-	xpcom \
-	browser \
-	$(NULL)
-
-MOZ_LOCALIZED_PKG_LIST = $(AB_CD)
-
 DEFINES += -DAB_CD=$(AB_CD) -DMOZ_APP_NAME=$(MOZ_APP_NAME) -DPREF_DIR=$(PREF_DIR)
 
 ifdef LIBXUL_SDK

config/rules.mk

@@ -399,7 +399,6 @@ ALL_TRASH_DIRS = \
 
 ifdef QTDIR
 GARBAGE                 += $(MOCSRCS)
-GARBAGE                 += $(RCCSRCS)
 endif
 
 ifdef SIMPLE_PROGRAMS

content/base/src/Makefile.in

@@ -19,8 +19,6 @@ LOCAL_INCLUDES += \
 		$(NULL)
 endif
 
-GQI_SRCS = contentbase.gqi
-
 include $(topsrcdir)/config/rules.mk
 include $(topsrcdir)/ipc/chromium/chromium-config.mk
 

dom/src/jsurl/Makefile.in

@@ -15,10 +15,7 @@ LOCAL_INCLUDES += \
 		-I$(srcdir) \
 		-I$(topsrcdir)/dom/base \
 		-I$(topsrcdir)/netwerk/base/src \
-
+		$(NULL)
-ifdef BUILD_DEBUG_GC
-DEFINES		+= -DDEBUG_GC
-endif
 
 include $(topsrcdir)/config/rules.mk
 

editor/composer/src/Makefile.in

@@ -14,9 +14,6 @@ EXPORT_LIBRARY = 1
 LIBXUL_LIBRARY	= 1
 include $(topsrcdir)/config/rules.mk
 
-INCLUDES        += \
-	$(NULL)
-
 _FILES = \
 	$(srcdir)/res/EditorOverride.css \
 	$(srcdir)/res/grabber.gif \

editor/libeditor/base/Makefile.in

@@ -12,12 +12,7 @@ include $(DEPTH)/config/autoconf.mk
 
 LIBXUL_LIBRARY	= 1
 
-# Internal header files, needed by other editor sublibs:
+LOCAL_INCLUDES += \
-INTERNAL_HDR_DIR = ../internal
-
-include $(topsrcdir)/config/rules.mk
-
-INCLUDES	+= \
 		-I$(topsrcdir)/editor/libeditor/text \
 		-I$(topsrcdir)/editor/txmgr/src \
 		-I$(topsrcdir)/content/base/src \
@@ -25,3 +20,5 @@ INCLUDES	+= \
 		-I$(topsrcdir)/layout/style \
 		-I$(topsrcdir)/extensions/spellcheck/src \
 		$(NULL)
+
+include $(topsrcdir)/config/rules.mk

embedding/base/Makefile.in

@@ -1,18 +0,0 @@
-# vim:set ts=8 sw=8 sts=8 noet:
-# 
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-DEPTH           = @DEPTH@
-topsrcdir       = @top_srcdir@
-srcdir          = @srcdir@
-VPATH           = @srcdir@
-
-include $(DEPTH)/config/autoconf.mk
-
-DISABLED_SDK_HEADERS         = \
-                nsEmbedCID.h \
-                $(NULL)
-
-include $(topsrcdir)/config/rules.mk

embedding/components/printingui/src/mac/Makefile.in

@@ -12,8 +12,6 @@ include $(DEPTH)/config/autoconf.mk
 
 EXPORT_LIBRARY	= ..
 LIBXUL_LIBRARY	= 1
-LOCAL_INCLUDES	= \
-		$(NULL)
 
 include $(topsrcdir)/config/rules.mk
 

gfx/angle/src/libEGL/Makefile.in

@@ -15,10 +15,6 @@ FORCE_SHARED_LIB = 1
 # ANGLE uses the STL, so we can't use our derpy STL wrappers.
 STL_FLAGS =
 
-# ANGLE uses exceptions internally, so we need to have exception handling
-# support
-ENABLE_CXX_EXCEPTIONS = 1
-
 ifndef GNU_CC
 # Enable unwind semantics for exception handlers in response to warning C4530.
 OS_CPPFLAGS += -EHsc

gfx/angle/src/libGLESv2/Makefile.in

@@ -16,10 +16,6 @@ FORCE_SHARED_LIB = 1
 # ANGLE uses the STL, so we can't use our derpy STL wrappers.
 STL_FLAGS =
 
-# ANGLE uses exceptions internally, so we need to have exception handling
-# support
-ENABLE_CXX_EXCEPTIONS = 1
-
 ifndef GNU_CC
 # Enable unwind semantics for exception handlers in response to warning C4530.
 OS_CPPFLAGS += -EHsc

gfx/cairo/cairo/src/Makefile.in

@@ -154,10 +154,6 @@ CSRCS   += $(PSPDF_BASE_CSRCS) $(PDF_CSRCS)
 OS_INCLUDES += $(MOZ_QT_CFLAGS)
 endif
 
-ifdef BUILD_CAIRO_SVG
-CSRCS	+= cairo-svg-surface.c
-endif
-
 ifdef MOZ_X11
 CSRCS   += cairo-xlib-surface.c \
 	   cairo-xlib-screen.c \

gfx/cairo/cairo/src/moz.build

@@ -67,11 +67,6 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'qt':
         'cairo-qt-surface.cpp',
     ]
 
-if CONFIG['BUILD_CAIRO_SVG']:
-    EXPORTS.cairo += [
-        'cairo-svg.h'
-    ]
-
 if CONFIG['MOZ_X11']:
     EXPORTS.cairo += [
         'cairo-xlib-xrender.h',

gfx/gl/Makefile.in

@@ -19,51 +19,10 @@ DEFINES += -DMOZ_D3DCOMPILER_DLL=$(MOZ_D3DCOMPILER_DLL)
 endif
 endif
 
-# NOTE: Please keep GL_PROVIDER in sync with moz.build until all variables
-# are moved over.
-GL_PROVIDER = Null
-
-ifeq ($(MOZ_WIDGET_TOOLKIT),windows)
-GL_PROVIDER = WGL
-endif
-
-ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
-GL_PROVIDER = CGL
-endif
-
-ifdef MOZ_WIDGET_GTK
-ifdef MOZ_PLATFORM_MAEMO
-GL_PROVIDER = EGL
-else
-ifdef MOZ_EGL_XRENDER_COMPOSITE
-GL_PROVIDER = EGL
-else
-GL_PROVIDER = GLX
-endif
-endif
-endif
-
-ifeq ($(MOZ_WIDGET_TOOLKIT),qt)
-ifdef MOZ_PLATFORM_MAEMO
-GL_PROVIDER = EGL
-else
-GL_PROVIDER = GLX
-endif
-endif
-
-ifeq ($(MOZ_WIDGET_TOOLKIT),android)
-GL_PROVIDER = EGL
-endif
-
 ifeq ($(MOZ_WIDGET_TOOLKIT),gonk)
-GL_PROVIDER = EGL
 LOCAL_INCLUDES = -I$(topsrcdir)/widget/gonk
 endif
 
-ifdef MOZ_GL_PROVIDER
-GL_PROVIDER = $(MOZ_GL_PROVIDER)
-endif
-
 ifdef MOZ_ANDROID_OMTC
 DEFINES += -DMOZ_ANDROID_OMTC
 endif

gfx/gl/moz.build

@@ -6,8 +6,6 @@
 
 MODULE = 'gl'
 
-# NOTE: Please keep gl_provider in sync with Makefile.in until all variables
-# are moved over.
 gl_provider = 'Null'
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
@@ -15,7 +13,7 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
 elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
     gl_provider = 'CGL'
 elif CONFIG['MOZ_WIDGET_GTK']:
-    if CONFIG['fdef MOZ_PLATFORM_MAEMO']:
+    if CONFIG['MOZ_PLATFORM_MAEMO']:
         gl_provider = 'EGL'
     else:
         if CONFIG['MOZ_EGL_XRENDER_COMPOSITE']:
@@ -23,7 +21,7 @@ elif CONFIG['MOZ_WIDGET_GTK']:
         else:
             gl_provider = 'GLX'
 elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'qt':
-    if CONFIG['fdef MOZ_PLATFORM_MAEMO']:
+    if CONFIG['MOZ_PLATFORM_MAEMO']:
         gl_provider = 'EGL'
     else:
         gl_provider = 'GLX'

js/src/Makefile.in

@@ -158,10 +158,6 @@ endif
 
 EXTRA_DSO_LDOPTS += $(NSPR_LIBS)
 
-ifndef BUILD_OPT
-MOCHAFILE	= 1
-endif
-
 # Define keyword generator before rules.mk, see bug 323979 comment 50
 
 HOST_CPPSRCS += jskwgen.cpp
@@ -343,10 +339,9 @@ endif
 
 DIST_GARBAGE = config.cache config.log config.status* \
    config/autoconf.mk \
-   unallmakefiles $(JS_CONFIG_NAME) js-config.h js-confdefs.h
+   $(JS_CONFIG_NAME) js-config.h js-confdefs.h
 
 distclean::
-	cat unallmakefiles | $(XARGS) rm -f
 	$(RM) $(DIST_GARBAGE)
 
 DEFINES		+= -DEXPORT_JS_API

js/src/config/rules.mk

@@ -399,7 +399,6 @@ ALL_TRASH_DIRS = \
 
 ifdef QTDIR
 GARBAGE                 += $(MOCSRCS)
-GARBAGE                 += $(RCCSRCS)
 endif
 
 ifdef SIMPLE_PROGRAMS

media/libpng/Makefile.in

@@ -16,18 +16,11 @@ ifeq ($(OS_ARCH),WINNT)
 VISIBILITY_FLAGS=
 endif
 
-
+DEFINES += \
-DEFINES		+= -DMOZ_PNG_READ \
+  -DMOZ_PNG_READ \
-		-DMOZ_PNG_WRITE
+  -DMOZ_PNG_WRITE \
-
+  $(NULL)
-LOCAL_INCLUDES	= -I$(srcdir)
 
 FORCE_STATIC_LIB = 1
 
 include $(topsrcdir)/config/rules.mk
-
-ifeq ($(OS_ARCH),WINNT)
-ifdef BUILD_DEBUG_GC
-DEFINES		+= -DDEBUG_GC
-endif
-endif

mobile/android/app/Makefile.in

@@ -37,8 +37,6 @@ NSDISTMODE = copy
 
 include $(topsrcdir)/config/rules.mk
 
-APP_ICON = mobile
-
 DEFINES += \
   -DAPP_NAME=$(MOZ_APP_NAME) \
   -DAPP_VERSION=$(MOZ_APP_VERSION) \

mobile/android/installer/Makefile.in

@@ -22,14 +22,6 @@ MOZ_PKG_REMOVALS = $(srcdir)/removed-files.in
 
 MOZ_PKG_MANIFEST_P = $(srcdir)/package-manifest.in
 
-MOZ_NONLOCALIZED_PKG_LIST = \
-	xpcom \
-	browser \
-	mobile \
-	$(NULL)
-
-MOZ_LOCALIZED_PKG_LIST = $(AB_CD) multilocale
-
 DEFINES += \
 	-DAB_CD=$(AB_CD) \
 	-DMOZ_APP_NAME=$(MOZ_APP_NAME) \

toolkit/components/feeds/Makefile.in

@@ -19,8 +19,6 @@ include $(topsrcdir)/config/rules.mk
 ABS_SRCDIR := $(call core_abspath,$(srcdir))
 ifeq ($(OS_ARCH),WINNT)
 
-ABS_DEPTH := $(call core_abspath,$(DEPTH))
-
 check::
 	cd $(srcdir)/test; $(LIBXUL_DIST)/bin/xpcshell$(BIN_SUFFIX) shell.js 
 

toolkit/components/maintenanceservice/Makefile.in

@@ -25,7 +25,6 @@ LIBS += \
   $(NULL)
 
 USE_STATIC_LIBS = 1
-HAVE_PROGRESSUI = 1
 RCINCLUDE = maintenanceservice.rc
 
 OS_LIBS += $(call EXPAND_LIBNAME,comctl32 ws2_32 shell32)

toolkit/mozapps/installer/packager.mk

@@ -555,9 +555,7 @@ GARBAGE		+= $(DIST)/$(PACKAGE) $(PACKAGE)
 
 # The following target stages files into two directories: one directory for
 # core files, and one for optional extensions based on the information in
-# the MOZ_PKG_MANIFEST file and the following vars:
+# the MOZ_PKG_MANIFEST file.
-# MOZ_NONLOCALIZED_PKG_LIST
-# MOZ_LOCALIZED_PKG_LIST
 
 PKG_ARG = , "$(pkg)"
 

toolkit/xre/Makefile.in

@@ -27,7 +27,8 @@ endif
 
 DEFINES += \
   -DMOZ_APP_NAME='"$(MOZ_APP_NAME)"' \
-  -DMOZ_APP_VERSION='"$(MOZ_APP_VERSION)"'
+  -DMOZ_APP_VERSION='"$(MOZ_APP_VERSION)"' \
+  $(NULL)
 
 ifdef MOZ_UPDATER
 ifneq (android,$(MOZ_WIDGET_TOOLKIT))
@@ -37,17 +38,6 @@ endif
 
 ifeq ($(MOZ_WIDGET_TOOLKIT),windows)
 DEFINES += -DWIN32_LEAN_AND_MEAN -DUNICODE -D_UNICODE
-else
-ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
-CMMSRCS = nsNativeAppSupportCocoa.mm
-endif
-endif
-
-ifeq ($(MOZ_WIDGET_TOOLKIT),cocoa)
-CMMSRCS += MacLaunchHelper.mm
-CMMSRCS += MacApplicationDelegate.mm
-CMMSRCS += MacAutoreleasePool.mm
-ENABLE_CXX_EXCEPTIONS = 1
 endif
 
 ifeq ($(MOZ_WIDGET_TOOLKIT),android)

toolkit/xre/moz.build

@@ -31,6 +31,12 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
     CPP_SOURCES += [
         'nsCommandLineServiceMac.cpp',
     ]
+    CMMSRCS += [
+        'MacApplicationDelegate.mm',
+        'MacAutoreleasePool.mm',
+        'MacLaunchHelper.mm',
+        'nsNativeAppSupportCocoa.mm',
+    ]
 elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'qt':
     EXPORTS += ['nsQAppInstance.h']
     CPP_SOURCES += [

widget/android/Makefile.in

@@ -12,18 +12,6 @@ include $(DEPTH)/config/autoconf.mk
 LIBRARY_NAME    = widget_android
 EXPORT_LIBRARY  = 1
 LIBXUL_LIBRARY  = 1
-ifdef MOZ_WEBSMS_BACKEND
-DEFINES += -DMOZ_WEBSMS_BACKEND
-endif
-
-NOT_THERE_YET_CPPSRCS = \
-	nsQtKeyUtils.cpp \
-	nsBidiKeyboard.cpp \
-	nsDragService.cpp \
-	nsNativeThemeQt.cpp \
-	mozqwidget.cpp \
-	nsSound.cpp \
-	$(NULL)
 
 SHARED_LIBRARY_LIBS = ../xpwidgets/libxpwidgets_s.a
 

widget/qt/Makefile.in

@@ -16,11 +16,6 @@ LIBXUL_LIBRARY	= 1
 
 SHARED_LIBRARY_LIBS = ../xpwidgets/libxpwidgets_s.a
 
-# If not primary toolkit, install in secondary path
-ifneq (qt,$(MOZ_WIDGET_TOOLKIT))
-INACTIVE_COMPONENT = 1
-endif
-
 include $(topsrcdir)/config/rules.mk
 include $(topsrcdir)/ipc/chromium/chromium-config.mk
 

xpcom/tests/Makefile.in

@@ -49,13 +49,8 @@ endif
 
 abs_srcdir = $(call core_abspath,$(srcdir))
 
-DIST_PATH = $(DIST)/bin/
-RM_DIST = rm -f
 regOrderDir="$(call getnativepath,$(abs_srcdir)/regorder)";
-DOCOPY=
 
 check::
 	XPCOM_DEBUG_BREAK=stack-and-abort $(RUN_TEST_PROGRAM) \
 	  $(DIST)/bin/TestRegistrationOrder$(BIN_SUFFIX) $(regOrderDir)
-
-GARBAGE += TestScriptable.h