wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 763526 - record success/fail for every telemetry ping; r=taras

Browse Source
This commit is contained in:
Nathan Froyd 2012-06-12 11:35:28 -04:00
parent 8610f52de9
commit 8ab246e877
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
toolkit/components/telemetry/TelemetryPing.js
View File

@ -542,13 +542,13 @@ TelemetryPing.prototype = {
success = channel.QueryInterface(Ci.nsIHttpChannel).requestSucceeded;
} catch(e) {
}
if (recordSuccess) {
let hping = Telemetry.getHistogramById("TELEMETRY_PING");
let hsuccess = Telemetry.getHistogramById("TELEMETRY_SUCCESS");
hsuccess.add(success);
hping.add(new Date() - startTime);
}
let hping = Telemetry.getHistogramById("TELEMETRY_PING");
let hsuccess = Telemetry.getHistogramById("TELEMETRY_SUCCESS");
hsuccess.add(success);
hping.add(new Date() - startTime);
if (success && file.exists()) {
file.remove(true);
}

6
toolkit/components/telemetry/tests/unit/test_TelemetryPing.js
View File

@ -223,7 +223,7 @@ function checkPersistedHistogramsSync(request, response) {
}
function checkHistogramsSync(request, response) {
checkPayload(request, "test-ping", 1);
checkPayload(request, "test-ping", 2);
Services.obs.addObserver(runAsyncTestObserver, "telemetry-test-xhr-complete", false);
}
@ -249,13 +249,13 @@ function runAsyncTestObserver(aSubject, aTopic, aData) {
function checkPersistedHistogramsAsync(request, response) {
httpserver.registerPathHandler(PATH, checkHistogramsAsync);
checkPayload(request, "saved-session", 2);
checkPayload(request, "saved-session", 3);
}
function checkHistogramsAsync(request, response) {
// do not need the http server anymore
httpserver.stop(do_test_finished);
checkPayload(request, "test-ping", 2);
checkPayload(request, "test-ping", 4);
gFinished = true;
}