wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 906286 - Canonicalize NaN values stored to float arrays in JS_MORE_DETERMINISTIC builds. r=luke

Browse Source
This commit is contained in:
Jan de Mooij 2013-08-21 08:40:17 +02:00
parent 21991b1148
commit 89e2f52152
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/jit/IonMacroAssembler.h
View File

@ -579,8 +579,12 @@ class MacroAssembler : public MacroAssemblerSpecific
}
}
template<typename S, typename T>
void storeToTypedFloatArray(int arrayType, const S &value, const T &dest) {
template<typename T>
void storeToTypedFloatArray(int arrayType, FloatRegister value, const T &dest) {
#ifdef JS_MORE_DETERMINISTIC
// See the comment in ToDoubleForTypedArray.
canonicalizeDouble(value);
#endif
switch (arrayType) {
case TypedArrayObject::TYPE_FLOAT32:
convertDoubleToFloat(value, ScratchFloatReg);

8
js/src/vm/TypedArrayObject.cpp
View File

@ -1357,6 +1357,14 @@ js::ToDoubleForTypedArray(JSContext *cx, JS::HandleValue vp, double *d)
*d = js_NaN;
}
#ifdef JS_MORE_DETERMINISTIC
// It's possible to have a NaN value with the sign bit set. The spec allows
// this but it can confuse differential testing when this value is stored
// to a float array and then read back as integer. To work around this, we
// always canonicalize NaN values in more-deterministic builds.
*d = JS_CANONICALIZE_NAN(*d);
#endif
return true;
}