wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 727351 - Fix the MotionEventHelper fling code to deal with the panning threshold and re-enable the fling correctness test. r=cpeterson

Browse Source
This commit is contained in:
Kartikaya Gupta 2012-06-22 23:10:26 -04:00
parent da4103114e
commit 89721bc5c1
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
mobile/android/base/tests/MotionEventHelper.java.in
View File

@ -93,8 +93,13 @@ class MotionEventHelper {
}
public Thread flingAsync(final float startX, final float startY, final float endX, final float endY, final float velocity) {
float dx = endX - startX;
float dy = endY - startY;
// note that the first move after the touch-down is used to get over the panning threshold, and
// is basically cancelled out. this means we need to generate (at least) two move events, with
// the last move event hitting the target velocity. to do this we just slice the total distance
// in half, assuming the first half will get us over the panning threshold and the second half
// will trigger the fling.
final float dx = (endX - startX) / 2;
final float dy = (endY - startY) / 2;
float distance = FloatMath.sqrt((dx * dx) + (dy * dy));
final long time = (long)(distance / velocity);
if (time <= 0) {
@ -103,7 +108,8 @@ class MotionEventHelper {
Thread t = new Thread() {
public void run() {
long downTime = down(startX, startY);
downTime = move(downTime, downTime + time, endX, endY);
downTime = move(downTime, downTime + time, startX + dx, startY + dy);
downTime = move(downTime, downTime + time + time, endX, endY);
downTime = up(downTime, downTime + time, endX, endY);
}
};

2
mobile/android/base/tests/robocop.ini
View File

@ -5,7 +5,7 @@
[testNewTab]
[testPanCorrectness]
# [test_bug720538] # see bug 746876
# [testFlingCorrectness] # see bug 727351
[testFlingCorrectness]
[testOverscroll]
[testAxisLocking]
[testAboutPage]