Bug 1232219 (part 4) - Enable -Wunused for C code, except where it's too annoying. r=glandium.

This commit is contained in:
Nicholas Nethercote 2015-12-16 22:59:42 -08:00
parent 2fb861bdfb
commit 88dd3dcc0e
6 changed files with 12 additions and 10 deletions

View File

@ -1489,9 +1489,6 @@ if test "$GNU_CC"; then
# Turn off some non-useful warnings that -Wall turns on. # Turn off some non-useful warnings that -Wall turns on.
# -Wno-unused - lots of violations in third-party code
_WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wno-unused"
# -Wno-unused-local-typedef - catches unused typedefs, which are commonly used in assertion macros # -Wno-unused-local-typedef - catches unused typedefs, which are commonly used in assertion macros
MOZ_C_SUPPORTS_WARNING(-Wno-, unused-local-typedef, ac_c_has_wno_unused_local_typedef) MOZ_C_SUPPORTS_WARNING(-Wno-, unused-local-typedef, ac_c_has_wno_unused_local_typedef)

View File

@ -139,8 +139,9 @@ if use_arm_neon_gcc:
if CONFIG['GNU_CC']: if CONFIG['GNU_CC']:
CFLAGS += [ CFLAGS += [
'-Wno-address', '-Wno-address',
'-Wno-sign-compare',
'-Wno-missing-field-initializers', '-Wno-missing-field-initializers',
'-Wno-sign-compare',
'-Wno-unused', # too many unused warnings; ignore
] ]
if CONFIG['CLANG_CXX']: if CONFIG['CLANG_CXX']:
CFLAGS += [ CFLAGS += [

View File

@ -1232,9 +1232,6 @@ if test "$GNU_CC"; then
# Turn off some non-useful warnings that -Wall turns on. # Turn off some non-useful warnings that -Wall turns on.
# -Wno-unused - lots of violations in third-party code
_WARNINGS_CFLAGS="${_WARNINGS_CFLAGS} -Wno-unused"
# -Wno-unused-local-typedef - catches unused typedefs, which are commonly used in assertion macros # -Wno-unused-local-typedef - catches unused typedefs, which are commonly used in assertion macros
MOZ_C_SUPPORTS_WARNING(-Wno-, unused-local-typedef, ac_c_has_wno_unused_local_typedef) MOZ_C_SUPPORTS_WARNING(-Wno-, unused-local-typedef, ac_c_has_wno_unused_local_typedef)

View File

@ -83,7 +83,10 @@ if CONFIG['CLANG_CL'] or not CONFIG['_MSC_VER']:
# Suppress warnings in third-party code. # Suppress warnings in third-party code.
if CONFIG['GNU_CC']: if CONFIG['GNU_CC']:
CFLAGS += ['-Wno-sign-compare'] CFLAGS += [
'-Wno-sign-compare',
'-Wno-unused-function', # so many of these warnings; just ignore them
]
ASFLAGS += CONFIG['VPX_ASFLAGS'] ASFLAGS += CONFIG['VPX_ASFLAGS']
ASFLAGS += [ ASFLAGS += [

View File

@ -43,7 +43,10 @@ LOCAL_INCLUDES += [
] ]
if CONFIG['GNU_CC']: if CONFIG['GNU_CC']:
CFLAGS += ['-Wshadow'] CFLAGS += [
'-Wshadow',
'-Wno-unused', # too many annoying fatal warnings from mfbt/ headers
]
if CONFIG['_MSC_VER']: if CONFIG['_MSC_VER']:
CFLAGS += ['-wd4273'] # inconsistent dll linkage (bug 558163) CFLAGS += ['-wd4273'] # inconsistent dll linkage (bug 558163)

View File

@ -34,10 +34,11 @@ if CONFIG['OS_ARCH'] == 'WINNT':
] ]
elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa': elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
UNIFIED_SOURCES += [ UNIFIED_SOURCES += [
'mach_override.c',
'PoisonIOInterposerBase.cpp', 'PoisonIOInterposerBase.cpp',
'PoisonIOInterposerMac.cpp', 'PoisonIOInterposerMac.cpp',
] ]
SOURCES += ['mach_override.c']
SOURCES['mach_override.c'].flags += ['-Wno-unused-function']
else: else:
SOURCES += ['PoisonIOInterposerStub.cpp'] SOURCES += ['PoisonIOInterposerStub.cpp']