wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 981239: Use atomic ref-counting for |UnixSocketConsumer|, r=kyle

Browse Source 
|SocketSendTask| acquires a reference to |UnixSocketConsumer| on
the main thread and releases this reference on the I/O thread;
leading to race-conditions. This patch adds

  - atomicity for ref-counting of |UnixSocketConsumer|, and
  - stricter tests in the destructor of this class.
This commit is contained in:
Thomas Zimmermann 2014-04-08 09:27:47 +02:00
parent b38304a595
commit 88cf1c0e54
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ipc/unixsocket/UnixSocket.cpp
View File

@ -739,6 +739,8 @@ UnixSocketConsumer::UnixSocketConsumer() : mImpl(nullptr)
UnixSocketConsumer::~UnixSocketConsumer()
{
MOZ_ASSERT(mConnectionStatus == SOCKET_DISCONNECTED);
MOZ_ASSERT(!mImpl);
}
bool

2
ipc/unixsocket/UnixSocket.h
View File

@ -135,7 +135,7 @@ enum SocketConnectionStatus {
SOCKET_CONNECTED = 3
};
class UnixSocketConsumer : public RefCounted<UnixSocketConsumer>
class UnixSocketConsumer : public AtomicRefCounted<UnixSocketConsumer>
{
public:
MOZ_DECLARE_REFCOUNTED_TYPENAME(UnixSocketConsumer)