wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 808980 - Clicking on the empty area of the stack list produces error message: item is null, r=past

Browse Source
This commit is contained in:
Victor Porof 2012-11-10 13:14:40 +02:00
parent 7dba54f417
commit 83bab9da09
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
browser/devtools/debugger/debugger-panes.js
View File

@ -101,7 +101,10 @@ create({ constructor: StackFramesView, proto: MenuContainer.prototype }, {
*/
_onClick: function DVSF__onClick(e) {
let item = this.getItemForElement(e.target);
DebuggerController.StackFrames.selectFrame(item.attachment.depth);
if (item) {
// The container is not empty and we clicked on an actual item.
DebuggerController.StackFrames.selectFrame(item.attachment.depth);
}
},
/**
@ -512,6 +515,10 @@ create({ constructor: BreakpointsView, proto: MenuContainer.prototype }, {
*/
_onClick: function DVB__onClick(e) {
let breakpointItem = this.getItemForElement(e.target);
if (!breakpointItem) {
// The container is empty or we didn't click on an actual item.
return;
}
let { sourceLocation: url, lineNumber: line } = breakpointItem.attachment;
DebuggerView.updateEditor(url, line, { noDebug: true });
@ -522,13 +529,17 @@ create({ constructor: BreakpointsView, proto: MenuContainer.prototype }, {
* The click listener for a breakpoint checkbox.
*/
_onCheckboxClick: function DVB__onCheckboxClick(e) {
let breakpointItem = this.getItemForElement(e.target);
if (!breakpointItem) {
// The container is empty or we didn't click on an actual item.
return;
}
let { sourceLocation: url, lineNumber: line, enabled } = breakpointItem.attachment;
// Don't update the editor location.
e.preventDefault();
e.stopPropagation();
let breakpointItem = this.getItemForElement(e.target);
let { sourceLocation: url, lineNumber: line, enabled } = breakpointItem.attachment;
this[enabled
? "disableBreakpoint"
: "enableBreakpoint"](url, line, { silent: true });