Bug 486195: getItemLocation on WinRegInstallLocation should return a clone of the item location. r=robstrong

This commit is contained in:
Dave Townsend 2009-03-31 22:21:07 +01:00
parent 21a20179b4
commit 830c491783

View File

@ -1249,7 +1249,7 @@ DirectoryInstallLocation.prototype = {
* See nsIExtensionManager.idl * See nsIExtensionManager.idl
*/ */
getItemFile: function DirInstallLocation_getItemFile(id, filePath) { getItemFile: function DirInstallLocation_getItemFile(id, filePath) {
var itemLocation = this.getItemLocation(id).clone(); var itemLocation = this.getItemLocation(id);
var parts = filePath.split("/"); var parts = filePath.split("/");
for (var i = 0; i < parts.length; ++i) for (var i = 0; i < parts.length; ++i)
itemLocation.append(parts[i]); itemLocation.append(parts[i]);
@ -1478,7 +1478,7 @@ WinRegInstallLocation.prototype = {
}, },
getItemLocation: function RegInstallLocation_getItemLocation(id) { getItemLocation: function RegInstallLocation_getItemLocation(id) {
return this._IDToDirMap[id]; return this._IDToDirMap[id].clone();
}, },
getIDForLocation: function RegInstallLocation_getIDForLocation(dir) { getIDForLocation: function RegInstallLocation_getIDForLocation(dir) {
@ -1486,7 +1486,7 @@ WinRegInstallLocation.prototype = {
}, },
getItemFile: function RegInstallLocation_getItemFile(id, filePath) { getItemFile: function RegInstallLocation_getItemFile(id, filePath) {
var itemLocation = this.getItemLocation(id).clone(); var itemLocation = this.getItemLocation(id);
var parts = filePath.split("/"); var parts = filePath.split("/");
for (var i = 0; i < parts.length; ++i) for (var i = 0; i < parts.length; ++i)
itemLocation.append(parts[i]); itemLocation.append(parts[i]);