wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 460115 Setting "Authorization" request header to value without a space results in crash [@ libc-2.6.so@0x6fbcc]

Browse Source 
r=biesi sr=biesi
This commit is contained in:
timeless@mozdev.org 2008-11-03 23:08:44 +01:00
parent 5fb029b4dc
commit 8277de41ec
1 changed files with 21 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
netwerk/protocol/http/src/nsHttpChannel.cpp
View File

@ -2410,17 +2410,30 @@ nsHttpChannel::AddCacheEntryHeaders(nsICacheEntryDescriptor *entry)
return rv;
}
inline void
GetAuthType(const char *challenge, nsCString &authType)
{
const char *p;
// get the challenge type
if ((p = strchr(challenge, ' ')) != nsnull)
authType.Assign(challenge, p - challenge);
else
authType.Assign(challenge);
}
nsresult
nsHttpChannel::StoreAuthorizationMetaData(nsICacheEntryDescriptor *entry)
{
// Not applicable to proxy authorization...
const char *val = mRequestHead.PeekHeader(nsHttp::Authorization);
if (val) {
// eg. [Basic realm="wally world"]
nsCAutoString buf(Substring(val, strchr(val, ' ')));
return entry->SetMetaDataElement("auth", buf.get());
}
return NS_OK;
if (!val)
return NS_OK;
// eg. [Basic realm="wally world"]
nsCAutoString buf;
GetAuthType(val, buf);
return entry->SetMetaDataElement("auth", buf.get());
}
// Finalize the cache entry
@ -3279,14 +3292,8 @@ nsHttpChannel::GetAuthenticator(const char *challenge,
{
LOG(("nsHttpChannel::GetAuthenticator [this=%x]\n", this));
const char *p;
// get the challenge type
if ((p = strchr(challenge, ' ')) != nsnull)
authType.Assign(challenge, p - challenge);
else
authType.Assign(challenge);
GetAuthType(challenge, authType);
// normalize to lowercase
ToLowerCase(authType);