Bug 1254797 - Pre: fix variable name being negation of value. r=rnewman, a=ritu

This variable was renamed to be positive instead of negative but the value/usage wasn't adapted.

MozReview-Commit-ID: H1DeZMmvTXC
This commit is contained in:
Andrzej Hunt 2016-03-09 20:10:34 -08:00
parent 2138586c25
commit 80c0bea197

View File

@ -761,7 +761,7 @@ public class BrowserProvider extends SharedBrowserDatabaseProvider {
String[] suggestedSiteArgs = new String[0];
boolean hasProcessedAnySuggestedSites = true;
boolean hasProcessedAnySuggestedSites = false;
final int idColumnIndex = suggestedSitesCursor.getColumnIndexOrThrow(Bookmarks._ID);
final int urlColumnIndex = suggestedSitesCursor.getColumnIndexOrThrow(Bookmarks.URL);
@ -769,10 +769,10 @@ public class BrowserProvider extends SharedBrowserDatabaseProvider {
while (suggestedSitesCursor.moveToNext()) {
// We'll be using this as a subquery, hence we need to avoid the preceding UNION ALL
if (!hasProcessedAnySuggestedSites) {
if (hasProcessedAnySuggestedSites) {
suggestedSitesBuilder.append(" UNION ALL");
} else {
hasProcessedAnySuggestedSites = false;
hasProcessedAnySuggestedSites = true;
}
suggestedSitesBuilder.append(" SELECT" +
" ? AS " + Bookmarks._ID + "," +
@ -812,7 +812,7 @@ public class BrowserProvider extends SharedBrowserDatabaseProvider {
ignoreForTopSitesArgs);
if (!hasProcessedAnySuggestedSites) {
if (hasProcessedAnySuggestedSites) {
db.execSQL("INSERT INTO " + TABLE_TOPSITES +
// We need to LIMIT _after_ selecting the relevant suggested sites, which requires us to
// use an additional internal subquery, since we cannot LIMIT a subquery that is part of UNION ALL.