Bug 1252346 - Fixes missing Services definition or tweaked eslint to figure out where does it comes from. r=jryans

devtools/client/commandline/test/helpers.js

@@ -24,6 +24,7 @@ var helpers = {};
 
 var { require } = Cu.import("resource://devtools/shared/Loader.jsm", {});
 var { TargetFactory } = require("devtools/client/framework/target");
+var Services = require("Services");
 
 var assert = { ok: ok, is: is, log: info };
 var util = require('gcli/util/util');

devtools/client/debugger/content/actions/sources.js

@@ -5,6 +5,7 @@
 
 const constants = require('../constants');
 const promise = require('promise');
+const Services = require('Services');
 const { dumpn } = require("devtools/shared/DevToolsUtils");
 const { PROMISE, HISTOGRAM_ID } = require('devtools/client/shared/redux/middleware/promise');
 const { getSource, getSourceText } = require('../queries');

devtools/client/debugger/content/views/sources-view.js

@@ -1,6 +1,7 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+/* import-globals-from ../../debugger-controller.js */
 "use strict";
 
 const utils = require('../utils');

devtools/client/debugger/utils.js

@@ -4,6 +4,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 /* globals document, window */
+/* import-globals-from ./debugger-controller.js */
 "use strict";
 
 // Maps known URLs to friendly source group names and put them at the

devtools/client/framework/test/shared-redux-head.js

@@ -6,8 +6,8 @@
 "use strict";
 
 /* eslint no-unused-vars: [2, {"vars": "local"}] */
+/* import-globals-from ./shared-head.js */
 // Currently this file expects "promise" to be imported into scope.
-/* globals promise */
 
 // Common utility functions for working with Redux stores.  The file is meant
 // to be safe to load in both mochitest and xpcshell environments.

devtools/client/inspector/fonts/fonts.js

@@ -10,6 +10,7 @@ const {Cu} = require("chrome");
 const {setTimeout, clearTimeout} =
       Cu.import("resource://gre/modules/Timer.jsm", {});
 const {gDevTools} = require("devtools/client/framework/devtools");
+const Services = require("Services");
 
 const DEFAULT_PREVIEW_TEXT = "Abc";
 const PREVIEW_UPDATE_DELAY = 150;

devtools/client/inspector/markup/markup.js

@@ -28,6 +28,7 @@ const {editableField, InplaceEditor} =
       require("devtools/client/shared/inplace-editor");
 const {HTMLEditor} = require("devtools/client/inspector/markup/html-editor");
 const promise = require("promise");
+const Services = require("Services");
 const {Tooltip} = require("devtools/client/shared/widgets/Tooltip");
 const EventEmitter = require("devtools/shared/event-emitter");
 const Heritage = require("sdk/core/heritage");

devtools/client/inspector/rules/views/rule-editor.js

@@ -26,6 +26,7 @@ const {
   SELECTOR_PSEUDO_CLASS
 } = require("devtools/client/shared/css-parsing-utils");
 const promise = require("promise");
+const Services = require("Services");
 const EventEmitter = require("devtools/shared/event-emitter");
 
 XPCOMUtils.defineLazyGetter(this, "_strings", function() {

devtools/client/jsonview/test/doc_frame_script.js

@@ -4,6 +4,8 @@
 
 "use strict";
 
+/* globals Services, sendAsyncMessage, addMessageListener */
+
 // XXX Some helper API could go to testing/mochitest/tests/SimpleTest/AsyncContentUtils.js
 // (or at least to share test API in devtools)
 

devtools/client/jsonview/utils.js

@@ -7,6 +7,7 @@
 "use strict";
 
 const {Cu, Cc, Ci} = require("chrome");
+const Services = require("Services");
 const {getMostRecentBrowserWindow} = require("sdk/window/utils");
 
 const OPEN_FLAGS = {

devtools/client/responsivedesign/responsivedesign-child.js

@@ -5,7 +5,7 @@
 "use strict";
 
 /* global content, docShell, addEventListener, addMessageListener,
-   removeEventListener, removeMessageListener, sendAsyncMessage */
+   removeEventListener, removeMessageListener, sendAsyncMessage, Services */
 
 var global = this;
 

devtools/client/webaudioeditor/views/context.js

@@ -3,6 +3,8 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
+/* import-globals-from ../includes.js */
+
 const { debounce } = require("sdk/lang/functional");
 
 // Globals for d3 stuff

devtools/client/webaudioeditor/views/inspector.js

@@ -3,6 +3,8 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
+/* import-globals-from ../includes.js */
+
 const MIN_INSPECTOR_WIDTH = 300;
 
 // Strings for rendering

devtools/shared/gcli/commands/highlight.js

@@ -5,6 +5,7 @@
 "use strict";
 
 const l10n = require("gcli/l10n");
+const Services = require("Services");
 require("devtools/server/actors/inspector");
 const {
   BoxModelHighlighter,

devtools/shared/webconsole/network-helper.js

@@ -57,6 +57,7 @@
 const {components, Cc, Ci, Cu} = require("chrome");
 loader.lazyImporter(this, "NetUtil", "resource://gre/modules/NetUtil.jsm");
 const DevToolsUtils = require("devtools/shared/DevToolsUtils");
+const Services = require("Services");
 
 // The cache used in the `nsIURL` function.
 const gNSURLStore = new Map();