From 7ecd1906ce04e80b268b8c15098ac45c0e2c019e Mon Sep 17 00:00:00 2001 From: Ralph Giles Date: Fri, 11 Dec 2015 12:51:00 -0800 Subject: [PATCH] Bug 1231169 - report rust mp4parse track status in telemetry. r=kinetik,vladan --- media/libstagefright/binding/MP4Metadata.cpp | 12 ++++++++++++ toolkit/components/telemetry/Histograms.json | 16 ++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/media/libstagefright/binding/MP4Metadata.cpp b/media/libstagefright/binding/MP4Metadata.cpp index 9d526ada790..16249fb84eb 100644 --- a/media/libstagefright/binding/MP4Metadata.cpp +++ b/media/libstagefright/binding/MP4Metadata.cpp @@ -200,6 +200,18 @@ MP4Metadata::GetNumberTracks(mozilla::TrackInfo::TrackType aType) const static LazyLogModule sLog("MP4Metadata"); MOZ_LOG(sLog, LogLevel::Info, ("%s tracks found: stagefright=%u rust=%u", rust_track_type, total, rust_total)); + switch (aType) { + case mozilla::TrackInfo::kAudioTrack: + Telemetry::Accumulate(Telemetry::MEDIA_RUST_MP4PARSE_TRACK_MATCH_AUDIO, + rust_total == total); + break; + case mozilla::TrackInfo::kVideoTrack: + Telemetry::Accumulate(Telemetry::MEDIA_RUST_MP4PARSE_TRACK_MATCH_VIDEO, + rust_total == total); + break; + default: + break; + } #endif return total; } diff --git a/toolkit/components/telemetry/Histograms.json b/toolkit/components/telemetry/Histograms.json index 4eb26f0d069..4e338a442c3 100644 --- a/toolkit/components/telemetry/Histograms.json +++ b/toolkit/components/telemetry/Histograms.json @@ -6279,6 +6279,22 @@ "description": "(Bug 1220885) Whether the rust mp4 demuxer successfully parsed a stream segment.", "cpp_guard": "MOZ_RUST_MP4PARSE" }, + "MEDIA_RUST_MP4PARSE_TRACK_MATCH_AUDIO": { + "alert_emails": ["giles@mozilla.com", "kinetik@flim.org"], + "expires_in_version": "50", + "kind": "boolean", + "bug_numbers": [1231169], + "description": "Whether rust and stagefight mp4 parser audio track results match.", + "cpp_guard": "MOZ_RUST_MP4PARSE" + }, + "MEDIA_RUST_MP4PARSE_TRACK_MATCH_VIDEO": { + "alert_emails": ["giles@mozilla.com", "kinetik@flim.org"], + "expires_in_version": "50", + "kind": "boolean", + "bug_numbers": [1231169], + "description": "Whether rust and stagefight mp4 parser video track results match.", + "cpp_guard": "MOZ_RUST_MP4PARSE" + }, "MEDIA_WMF_DECODE_ERROR": { "expires_in_version": "50", "kind": "enumerated",