Bug 654369 - Part 10: Make nsFloatManager::StoreRegionFor return void r=bz

--HG--
extra : rebase_source : dcf1babec6d26cfaee2e050e1fbd8abca941c8eb
This commit is contained in:
Craig Topper 2011-05-08 01:00:29 -07:00
parent 9e5af74e62
commit 7a1b417e0b
3 changed files with 3 additions and 7 deletions

View File

@ -882,8 +882,7 @@ nsBlockReflowState::FlowAndPlaceFloat(nsIFrame* aFloat)
mFloatManager->AddFloat(aFloat, region);
NS_ABORT_IF_FALSE(NS_SUCCEEDED(rv), "bad float placement");
// store region
rv = nsFloatManager::StoreRegionFor(aFloat, region);
NS_ABORT_IF_FALSE(NS_SUCCEEDED(rv), "float region storage failed");
nsFloatManager::StoreRegionFor(aFloat, region);
// If the float's dimensions have changed, note the damage in the
// float manager.

View File

@ -338,11 +338,10 @@ nsFloatManager::GetRegionFor(nsIFrame* aFloat)
return region;
}
nsresult
void
nsFloatManager::StoreRegionFor(nsIFrame* aFloat,
nsRect& aRegion)
{
nsresult rv = NS_OK;
nsRect rect = aFloat->GetRect();
FrameProperties props = aFloat->Properties();
if (aRegion.IsEqualEdges(rect)) {
@ -357,7 +356,6 @@ nsFloatManager::StoreRegionFor(nsIFrame* aFloat,
}
*storedMargin = aRegion - rect;
}
return rv;
}
nsresult

View File

@ -100,8 +100,7 @@ public:
* as a delta against the mRect, so repositioning the frame will
* also reposition the float region.
*/
static nsresult StoreRegionFor(nsIFrame* aFloat,
nsRect& aRegion);
static void StoreRegionFor(nsIFrame* aFloat, nsRect& aRegion);
// Structure that stores the current state of a frame manager for
// Save/Restore purposes.