Bug 896049 - Define SK_OVERRIDE with a default value if it hasn't been defined previously. r=gw280

This commit is contained in:
Arnaud Sourioux 2013-07-24 09:17:15 -04:00
parent db872e5c55
commit 78a824ee58
2 changed files with 29 additions and 3 deletions

View File

@ -330,9 +330,9 @@
#define SK_OVERRIDE override
#endif
#endif
#else
// Linux GCC ignores "__attribute__((override))" and rejects "override".
#define SK_OVERRIDE
#endif
#ifndef SK_OVERRIDE
#define SK_OVERRIDE
#endif
#endif

View File

@ -0,0 +1,26 @@
diff --git a/gfx/skia/include/core/SkPostConfig.h b/gfx/skia/include/core/SkPostConfig.h
--- a/gfx/skia/include/core/SkPostConfig.h
+++ b/gfx/skia/include/core/SkPostConfig.h
@@ -325,19 +325,19 @@
// Some documentation suggests we should be using __attribute__((override)),
// but it doesn't work.
#define SK_OVERRIDE override
#elif defined(__has_extension)
#if __has_extension(cxx_override_control)
#define SK_OVERRIDE override
#endif
#endif
- #else
- // Linux GCC ignores "__attribute__((override))" and rejects "override".
- #define SK_OVERRIDE
+ #endif
+ #ifndef SK_OVERRIDE
+ #define SK_OVERRIDE
#endif
#endif
//////////////////////////////////////////////////////////////////////
#ifndef SK_PRINTF_LIKE
#if defined(__clang__) || defined(__GNUC__)
#define SK_PRINTF_LIKE(A, B) __attribute__((format(printf, (A), (B))))