Bug 1059038 - Move mozilla::unused from xpcom/glue to mfbt. r=Waldo

--HG--
rename : xpcom/glue/unused.cpp => mfbt/unused.cpp
rename : xpcom/glue/unused.h => mfbt/unused.h

mfbt/moz.build

@@ -72,6 +72,7 @@ EXPORTS.mozilla = [
     'UniquePtr.h',
     'Vector.h',
     'WeakPtr.h',
+    'unused.h',
 ]
 
 if CONFIG['OS_ARCH'] == 'WINNT':
@@ -97,6 +98,7 @@ UNIFIED_SOURCES = [
     'Poison.cpp',
     'SHA1.cpp',
     'TaggedAnonymousMemory.cpp',
+    'unused.cpp',
 ]
 
 DEFINES['IMPL_MFBT'] = True

mfbt/unused.h

@@ -7,7 +7,7 @@
 #ifndef mozilla_unused_h
 #define mozilla_unused_h
 
-#include "nscore.h"
+#include "mozilla/Types.h"
 
 namespace mozilla {
 
@@ -19,7 +19,7 @@ struct unused_t
 {
 };
 
-extern const unused_t unused;
+extern MFBT_DATA const unused_t unused;
 
 template<typename T>
 inline void

security/sandbox/linux/moz.build

@@ -13,8 +13,6 @@ EXPORTS.mozilla += [
 ]
 
 SOURCES += [
-    # Bug 1059038 workaround:
-    '../../../xpcom/glue/unused.cpp',
     '../chromium/base/shim/base/logging.cpp',
     '../chromium/sandbox/linux/seccomp-bpf/basicblock.cc',
     '../chromium/sandbox/linux/seccomp-bpf/codegen.cc',

xpcom/glue/moz.build

@@ -78,7 +78,6 @@ EXPORTS.mozilla += [
     'Mutex.h',
     'Observer.h',
     'ReentrantMonitor.h',
-    'unused.h',
 ]
 
 EXPORTS.mozilla.threads += [

xpcom/glue/objs.mozbuild

@@ -43,7 +43,6 @@ xpcom_gluens_src_lcppsrcs = [
     'GenericFactory.cpp',
     'nsProxyRelease.cpp',
     'nsTextFormatter.cpp',
-    'unused.cpp',
 ]
 
 xpcom_gluens_src_cppsrcs = [