Bug 1146065 - Logins captured but not filled on discover.com. r=mattn

This commit is contained in:
Justin Dolske 2015-03-28 12:13:17 -07:00
parent bb79e09836
commit 7774ccbfd0
2 changed files with 14 additions and 2 deletions

View File

@ -461,12 +461,17 @@ var LoginManagerContent = {
if (!usernameField) if (!usernameField)
log("(form -- no username field found)"); log("(form -- no username field found)");
log("Username field id/name/value is: ", usernameField.id, " / ",
usernameField.name, " / ", usernameField.value);
// If we're not submitting a form (it's a page load), there are no // If we're not submitting a form (it's a page load), there are no
// password field values for us to use for identifying fields. So, // password field values for us to use for identifying fields. So,
// just assume the first password field is the one to be filled in. // just assume the first password field is the one to be filled in.
if (!isSubmission || pwFields.length == 1) if (!isSubmission || pwFields.length == 1) {
return [usernameField, pwFields[0].element, null]; var passwordField = pwFields[0].element;
log("Password field id/name is: ", passwordField.id, " / ", passwordField.name);
return [usernameField, passwordField, null];
}
// Try to figure out WTF is in the form based on the password values. // Try to figure out WTF is in the form based on the password values.
@ -509,6 +514,8 @@ var LoginManagerContent = {
} }
} }
log("Password field (new) id/name is: ", newPasswordField.id, " / ", newPasswordField.name);
log("Password field (old) id/name is: ", oldPasswordField.id, " / ", oldPasswordField.name);
return [usernameField, newPasswordField, oldPasswordField]; return [usernameField, newPasswordField, oldPasswordField];
}, },

View File

@ -236,6 +236,11 @@ const DEFAULT_RECIPES = {
"description": "anthem uses a hidden password and username field to disable filling", "description": "anthem uses a hidden password and username field to disable filling",
"hosts": ["www.anthem.com"], "hosts": ["www.anthem.com"],
"passwordSelector": "#LoginContent_txtLoginPass" "passwordSelector": "#LoginContent_txtLoginPass"
},
{
"description": "An ephemeral password-shim field is incorrectly selected as the username field.",
"hosts": ["www.discover.com"],
"usernameSelector": "#login-account"
} }
] ]
}; };