wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

bug 1189277 - only coalesce reorder events when a previous one for the same target is obsolete r=surkov

Browse Source 
Having one reorder event that superseeds another does not mean that the
dependant mutation events for the first reorder are obsolete.  So we if we
coalesce a reorder event away we should leave its subordinate mutation events
alone.
This commit is contained in:
Trevor Saunders 2015-08-14 14:07:06 -04:00
parent f2dad8dee1
commit 76c5e0a04e
3 changed files with 87 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
accessible/base/EventQueue.cpp
View File

@ -248,12 +248,7 @@ EventQueue::CoalesceReorderEvents(AccEvent* aTailEvent)
// Coalesce earlier event of the same target.
if (thisEvent->mAccessible == aTailEvent->mAccessible) {
if (thisEvent->mEventRule == AccEvent::eDoNotEmit) {
AccReorderEvent* tailReorder = downcast_accEvent(aTailEvent);
tailReorder->DoNotEmitAll();
} else {
thisEvent->mEventRule = AccEvent::eDoNotEmit;
}
thisEvent->mEventRule = AccEvent::eDoNotEmit;
return;
}

1
accessible/tests/mochitest/treeupdate/a11y.ini
View File

@ -8,6 +8,7 @@
[test_bug1040735.html]
[test_bug1100602.html]
[test_bug1175913.html]
[test_bug1189277.html]
[test_canvas.html]
[test_colorpicker.xul]
[test_contextmenu.xul]

85
accessible/tests/mochitest/treeupdate/test_bug1189277.html Normal file
View File

@ -0,0 +1,85 @@
<html>
<head>
<title>Test hide/show events for HTMLListBulletAccessibles on list restyle</title>
<link rel="stylesheet" type="text/css"
href="chrome://mochikit/content/tests/SimpleTest/test.css" />
<script type="application/javascript"
src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>
<script type="application/javascript"
src="../common.js"></script>
<script type="application/javascript"
src="../name.js"></script>
<script type="application/javascript"
src="../events.js"></script>
<script type="application/javascript">
function runTest()
{
this.containerNode = getNode("outerDiv");
this.eventSeq = [
new invokerChecker(EVENT_HIDE, getNode("child")),
new invokerChecker(EVENT_REORDER, this.containerNode),
new invokerChecker(EVENT_HIDE, getNode("childDoc")),
new invokerChecker(EVENT_SHOW, "newChildDoc")
];
this.invoke = function runTest_invoke()
{
this.containerNode.removeChild(getNode("child"));
var docContainer = getNode("docContainer");
var iframe = document.createElement("iframe");
iframe.setAttribute("src", "http://example.com");
iframe.setAttribute("id", "newChildDoc");
docContainer.removeChild(getNode("childDoc"));
docContainer.appendChild(iframe);
}
this.getID = function runTest_getID()
{
return "check show events are not incorrectly coalesced";
}
}
gA11yEventDumpToConsole = true;
var gQueue = null;
function doTest()
{
gQueue = new eventQueue();
gQueue.push(new runTest());
gQueue.invoke(); // SimpleTest.finish();
}
SimpleTest.waitForExplicitFinish();
addA11yLoadEvent(doTest);
</script>
</head>
<body>
<a target="_blank"
href="https://bugzilla.mozilla.org/show_bug.cgi?id=1189277"
title="content process crash caused by missing show event">
Mozilla Bug 1189277
</a>
<p id="display"></p>
<div id="content" style="display: none"></div>
<pre id="test">
</pre>
<div id="outerDiv">
<div id="child">foo</div>
<div id="docContainer">
<iframe id="childDoc" src="about:blank">
</iframe>
</div>
</div>
</body>
</html>