wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 924410 - don't generate typedefs in Message subclasses; r=ehsan

Browse Source 
There's no reason for them to be there, since Message subclasses are nothing
more than a constructor and a logging method.
This commit is contained in:
Nathan Froyd 2013-10-01 12:50:18 -04:00
parent 778bf2197f
commit 7289391ff5
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ipc/ipdl/ipdl/lower.py
View File

@ -1566,18 +1566,17 @@ class _GenerateProtocolCode(ipdl.ast.Visitor):
ns.addstmts([ tfDecl, Whitespace.NL ])
self.funcDefns.append(tfDefn)
typedefs = self.protocol.decl.cxxtypedefs
for md in p.messageDecls:
ns.addstmts([
_generateMessageClass(md.msgClass(), md.msgId(),
typedefs, md.prettyMsgName(p.name+'::'),
md.prettyMsgName(p.name+'::'),
md.decl.type.compress),
Whitespace.NL ])
if md.hasReply():
ns.addstmts([
_generateMessageClass(
md.replyClass(), md.replyId(),
typedefs, md.prettyReplyName(p.name+'::'),
md.prettyReplyName(p.name+'::'),
md.decl.type.compress),
Whitespace.NL ])
@ -1768,12 +1767,8 @@ class _GenerateProtocolCode(ipdl.ast.Visitor):
##--------------------------------------------------
def _generateMessageClass(clsname, msgid, typedefs, prettyName, compress):
def _generateMessageClass(clsname, msgid, prettyName, compress):
cls = Class(name=clsname, inherits=[ Inherit(Type('IPC::Message')) ])
cls.addstmt(Label.PRIVATE)
cls.addstmts(typedefs)
cls.addstmt(Whitespace.NL)
cls.addstmt(Label.PUBLIC)
idenum = TypeEnum()