wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 985894 - Sending a value to a newborn generator should not raise an error r=jorendorff

Browse Source
This commit is contained in:
Andy Wingo 2014-06-26 15:32:30 +02:00
parent 38775afe87
commit 6fca650383
3 changed files with 5 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/src/jsiter.cpp
View File

@ -1921,13 +1921,6 @@ star_generator_next(JSContext *cx, CallArgs args)
return true;
}
if (gen->state == JSGEN_NEWBORN && args.hasDefined(0)) {
RootedValue val(cx, args[0]);
js_ReportValueError(cx, JSMSG_BAD_GENERATOR_SEND,
JSDVG_SEARCH_STACK, val, js::NullPtr());
return false;
}
return SendToGenerator(cx, JSGENOP_SEND, thisObj, gen, args.get(0), StarGenerator,
args.rval());
}
@ -1956,13 +1949,6 @@ legacy_generator_next(JSContext *cx, CallArgs args)
if (gen->state == JSGEN_CLOSED)
return js_ThrowStopIteration(cx);
if (gen->state == JSGEN_NEWBORN && args.hasDefined(0)) {
RootedValue val(cx, args[0]);
js_ReportValueError(cx, JSMSG_BAD_GENERATOR_SEND,
JSDVG_SEARCH_STACK, val, js::NullPtr());
return false;
}
return SendToGenerator(cx, JSGENOP_SEND, thisObj, gen, args.get(0), LegacyGenerator,
args.rval());
}

2
js/src/tests/ecma_6/Generators/iteration.js
View File

@ -31,7 +31,7 @@ function TestGenerator(g, expected_values_for_next,
function testSend(thunk) {
var iter = thunk();
for (var i = 0; i < expected_values_for_send.length; i++) {
assertIteratorResult(i ? iter.next(send_val) : iter.next(),
assertIteratorResult(iter.next(send_val),
expected_values_for_send[i],
i == expected_values_for_send.length - 1);
}

15
js/src/tests/js1_7/geniter/regress-392310.js
View File

@ -28,20 +28,13 @@ function test()
actual = 'after yield';
}
expect = /TypeError: attempt to send ("before yield"|value) to newborn generator/i;
var gen = yielder();
try
{
gen.send('before yield');
}
catch(ex)
{
actual = ex + '';
}
reportMatch(expect, actual, 'send(value) to newborn generator');
expect = 'before yield';
gen.send('foo');
reportCompare(expect, actual, 'send(value) to newborn generator');
var gen = yielder();
expect = 'before yield';
gen.send(undefined);
reportCompare(expect, actual, 'send(undefined) to newborn generator');