wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity

Bug 453254 - nsZipReaderCache::GetZip doesn't null-check the zipFile argument. r+sr=biesi

Browse Source
This commit is contained in:
Alex Vincent 2008-09-06 17:06:47 +02:00
parent 4d83879649
commit 6eb7885801
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/libjar/nsJAR.cpp
View File

@ -1115,6 +1115,7 @@ nsZipReaderCache::~nsZipReaderCache()
NS_IMETHODIMP
nsZipReaderCache::GetZip(nsIFile* zipFile, nsIZipReader* *result)
{
NS_ENSURE_ARG_POINTER(zipFile);
nsresult rv;
nsAutoLock lock(mLock);

12
modules/libjar/test/unit/test_bug453254.js Normal file
View File

@ -0,0 +1,12 @@
function run_test() {
const zipCache = Components.classes["@mozilla.org/libjar/zip-reader-cache;1"]
.createInstance(Components.interfaces.nsIZipReaderCache);
zipCache.init(1024);
try {
zipCache.getZip(null);
do_throw("Shouldn't get here!");
} catch (e if ((e instanceof Components.interfaces.nsIException) &&
(e.result == Components.results.NS_ERROR_INVALID_POINTER))) {
// do nothing, this test passes
}
}